https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/ Issue: sci-libs/gmsh-4.10.3 fails to compile (lto). Discovered on: amd64 (internal ref: lto_tinderbox) NOTE: This machine uses lto with CFLAGS=-flto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing Here is a bit of explanation: -Werror=lto-type-mismatch: User to find possible runtime issues in packages. It likely means the package is unsafe to build & use with LTO. For projects using the same identifier but with different types across different files, they must be fixed to be consistent across the codebase. -Werror=odr: Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. C++ code must comply with the One Definition Rule (ODR) - see https://en.cppreference.com/w/cpp/language/definition#One_Definition_Rule. -Werror=strict-aliasing: Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. Workarounds: - If upstream is friendly and still active, file a bug upstream. For emulators, codecs, games, or multimedia packages, it may be worth just applying a workaround instead, as upstreams sometimes aren't receptive to these bugs (VALID FOR ALL). - Use the new 'filter-lto' from flag-o-matic.eclass as it's likely to be unsafe with LTO (VALID FOR lto-type-mismatch - odr). - Fix it yourself if interested, of course (VALID FOR ALL). - Append-flags -fno-strict-aliasing (VALID FOR strict-aliasing). - Use memcpy() but a union is sometimes suitable too (VALID FOR strict-aliasing). - -fstrict-aliasing is implied by -O2, so this must be addressed in some form (VALID FOR strict-aliasing). See also: https://marc.info/?l=gentoo-dev&m=165639574126280&w=2
Created attachment 796453 [details] build.log.xz build log and emerge --info (compressed because it exceeds attachment limit, use 'xzless' to read it)
Error(s) that match a know pattern in addition to what has been reported in the summary: FAILED: gmsh /var/tmp/portage/sci-libs/gmsh-4.10.3/work/gmsh-4.10.3-source/contrib/blossom/concorde97/UTIL/safe_io.c:953: error: type of ‘write’ does not match original declaration [-Werror=lto-type-mismatch]
lto_tinderbox has reproduced this issue with version 4.11.1-r1 - Updating summary.
Works fine with upstream new releases.
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=8f8d5de4ff5fb216a253faa080fb29e7539e655d commit 8f8d5de4ff5fb216a253faa080fb29e7539e655d Author: Eli Schwartz <eschwartz93@gmail.com> AuthorDate: 2024-03-25 20:28:43 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2024-03-26 12:27:25 +0000 sci-libs/gmsh: add 4.12.2 Fixes LTO issues. Includes a backported patch. Closes: https://bugs.gentoo.org/862711 Signed-off-by: Eli Schwartz <eschwartz93@gmail.com> Signed-off-by: Sam James <sam@gentoo.org> sci-libs/gmsh/Manifest | 1 + sci-libs/gmsh/gmsh-4.12.2.ebuild | 137 +++++++++++++++++++++++++++++++++++++++ 2 files changed, 138 insertions(+)