https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/ Issue: sci-libs/dcmtk-3.6.7 fails to compile (lto). Discovered on: amd64 (internal ref: lto_tinderbox) NOTE: This machine uses lto with CFLAGS=-flto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing Here is a bit of explanation: -Werror=lto-type-mismatch: User to find possible runtime issues in packages. It likely means the package is unsafe to build & use with LTO. For projects using the same identifier but with different types across different files, they must be fixed to be consistent across the codebase. -Werror=odr: Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. C++ code must comply with the One Definition Rule (ODR) - see https://en.cppreference.com/w/cpp/language/definition#One_Definition_Rule. -Werror=strict-aliasing: Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. Workarounds: - If upstream is friendly and still active, file a bug upstream. For emulators, codecs, games, or multimedia packages, it may be worth just applying a workaround instead, as upstreams sometimes aren't receptive to these bugs (VALID FOR ALL). - Use the new 'filter-lto' from flag-o-matic.eclass as it's likely to be unsafe with LTO (VALID FOR lto-type-mismatch - odr). - Fix it yourself if interested, of course (VALID FOR ALL). - Append-flags -fno-strict-aliasing (VALID FOR strict-aliasing). - Use memcpy() but a union is sometimes suitable too (VALID FOR strict-aliasing). - -fstrict-aliasing is implied by -O2, so this must be addressed in some form (VALID FOR strict-aliasing). See also: https://marc.info/?l=gentoo-dev&m=165639574126280&w=2
Created attachment 796441 [details] build.log.xz build log and emerge --info (compressed because it exceeds attachment limit, use 'xzless' to read it)
Error(s) that match a know pattern in addition to what has been reported in the summary: FAILED: bin/dcmdata_tests /var/tmp/portage/sci-libs/dcmtk-3.6.7/work/dcmtk-3.6.7/ofstd/include/dcmtk/ofstd/oftest.h:140:7: error: type ‘struct OFTestManager’ violates the C++ One Definition Rule [-Werror=odr]
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e2086390e7aa813502ca7cdc077cd7952353d13c commit e2086390e7aa813502ca7cdc077cd7952353d13c Author: Sam James <sam@gentoo.org> AuthorDate: 2024-03-11 16:54:25 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2024-03-11 16:55:19 +0000 sci-libs/dcmtk: add 3.6.8 Reported the LTO issue upstream via email. The one reported in bug #862699 seems fixed upstream in git but another one involving JPEG appeared. Closes: https://bugs.gentoo.org/862699 Signed-off-by: Sam James <sam@gentoo.org> sci-libs/dcmtk/Manifest | 1 + sci-libs/dcmtk/dcmtk-3.6.8.ebuild | 95 +++++++++++++++++++++++++++ sci-libs/dcmtk/files/dcmtk-3.6.8-docdir.patch | 12 ++++ 3 files changed, 108 insertions(+)
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1df72e06c83c784bf07e39536681faa6a6c71db8 commit 1df72e06c83c784bf07e39536681faa6a6c71db8 Author: Sam James <sam@gentoo.org> AuthorDate: 2024-04-01 05:04:06 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2024-04-01 05:29:25 +0000 sci-libs/dcmtk: update LTO comment (fixed upstream in git!) Thank you dcmtk maintainers :) Bug: https://bugs.gentoo.org/862699 Signed-off-by: Sam James <sam@gentoo.org> sci-libs/dcmtk/dcmtk-3.6.8.ebuild | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
When bumping to 3.6.9, I see: ``` /var/tmp/portage/sci-libs/dcmtk-3.6.9/work/dcmtk-3.6.9/dcmiod/include/dcmtk/dcmiod/modbase.h:231:27: error: virtual table of type ‘struct IODModule’ violates one definition rule [-Werror =odr] 231 | class DCMTK_DCMIOD_EXPORT IODModule : public IODComponent | ^ /var/tmp/portage/sci-libs/dcmtk-3.6.9/work/dcmtk-3.6.9/dcmiod/include/dcmtk/dcmiod/modbase.h:231:27: note: the conflicting type defined in another translation unit 231 | class DCMTK_DCMIOD_EXPORT IODModule : public IODComponent | ^ /var/tmp/portage/sci-libs/dcmtk-3.6.9/work/dcmtk-3.6.9/dcmiod/libsrc/modbase.cc:137:13: note: virtual method ‘read’ 137 | OFCondition IODComponent::read(DcmItem& source, const OFBool clearOldData) | ^ <built-in>: note: ought to match virtual method ‘__cxa_pure_virtual’ but does not lto1: some warnings being treated as errors lto-wrapper: fatal error: /usr/bin/x86_64-pc-linux-gnu-g++ returned 1 exit status compilation terminated. mold: fatal: lto-wrapper failed ``` I haven't yet reported this upstream.
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1f97cb6d7e8d694f6ea9cfa4f4e5d2f0fc0b470a commit 1f97cb6d7e8d694f6ea9cfa4f4e5d2f0fc0b470a Author: Sam James <sam@gentoo.org> AuthorDate: 2024-12-24 05:46:21 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2024-12-24 05:46:21 +0000 sci-libs/dcmtk: add 3.6.9 Another ODR issue has appeared, not yet reported upstream. Bug: https://bugs.gentoo.org/862699 Closes: https://bugs.gentoo.org/936681 Closes: https://bugs.gentoo.org/937991 Signed-off-by: Sam James <sam@gentoo.org> sci-libs/dcmtk/Manifest | 1 + sci-libs/dcmtk/dcmtk-3.6.9.ebuild | 88 +++++++++++++++++++++++++++ sci-libs/dcmtk/files/dcmtk-3.6.9-docdir.patch | 15 +++++ 3 files changed, 104 insertions(+)
