Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 862609 - net-misc/r8168: error: implicit declaration of function 'netif_set_gso_max_size
Summary: net-misc/r8168: error: implicit declaration of function 'netif_set_gso_max_size
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Pacho Ramos
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2022-08-01 01:58 UTC by Peter Levine
Modified: 2022-08-02 17:36 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
r8168-8.050.03-linux-5.19.patch (r8168-8.050.03-linux-5.19.patch,849 bytes, patch)
2022-08-01 02:02 UTC, Peter Levine 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Levine 2022-08-01 01:58:58 UTC 
Building net-misc/r8168-8.050.03 against Linux kernel 5.19.* results in 

> /var/tmp/portage/net-misc/r8168-8.050.03/work/r8168-8.050.03/src/r8168_n.c: In function 'rtl8168_init_one':
> /var/tmp/portage/net-misc/r8168-8.050.03/work/r8168-8.050.03/src/r8168_n.c:26899:25: error: implicit declaration of function 'netif_set_gso_max_size'; did you mean 'netif_set_tso_max_size'? [-Werror=implicit-function-declaration]
> 26899 |                         netif_set_gso_max_size(dev, LSO_32K);
>       |                         ^~~~~~~~~~~~~~~~~~~~~~
>       |                         netif_set_tso_max_size
Comment 1 Peter Levine 2022-08-01 02:02:27 UTC 
Created attachment 796294 [details, diff]
r8168-8.050.03-linux-5.19.patch

This fixes the issue.  It was taken from ubuntu's tarball, r8168_8.050.03-1ubuntu1.debian.tar.xz.
Comment 2 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-08-01 02:03:03 UTC 
Please always include the full build.log and emerge --info for completeness.

(In reply to Peter Levine from comment #1)
> Created attachment 796294 [details, diff] [details, diff]
> r8168-8.050.03-linux-5.19.patch
> 
> This fixes the issue.  It was taken from ubuntu's tarball,
> r8168_8.050.03-1ubuntu1.debian.tar.xz.

Coould you give a link to where you found the tarball as well? (I know it's probably not hard to find, but...)

Thanks!
Comment 4 Larry the Git Cow gentoo-dev 2022-08-02 17:36:27 UTC 
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b74666ef91c8b5a079782b77e86e3fb01ffb5807

commit b74666ef91c8b5a079782b77e86e3fb01ffb5807
Author:     Pacho Ramos <pacho@gentoo.org>
AuthorDate: 2022-08-02 17:35:52 +0000
Commit:     Pacho Ramos <pacho@gentoo.org>
CommitDate: 2022-08-02 17:35:52 +0000

    net-misc/r8168: Fix kernel 5.19 support
    
    Thanks-to: Peter Levine
    Closes: https://bugs.gentoo.org/862609
    Signed-off-by: Pacho Ramos <pacho@gentoo.org>

 net-misc/r8168/files/r8168-8.050.03-5.19-fix.patch | 23 ++++++++++++++++++++++
 net-misc/r8168/r8168-8.050.03.ebuild               |  1 +
 2 files changed, 24 insertions(+)