Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 862603 - media-sound/ardour-6.9-r1: can't build against lv2-1.18.6
Summary: media-sound/ardour-6.9-r1: can't build against lv2-1.18.6
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Professional Audio Applications Maintainers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-07-31 21:39 UTC by Sergey 'L29Ah' Alirzaev
Modified: 2022-08-05 13:34 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
emerge --info (emerge.info,18.18 KB, text/plain)
2022-07-31 21:39 UTC, Sergey 'L29Ah' Alirzaev
Details
build log (build.log.xz,19.95 KB, application/x-xz)
2022-07-31 21:46 UTC, Sergey 'L29Ah' Alirzaev
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Sergey 'L29Ah' Alirzaev 2022-07-31 21:39:29 UTC
Created attachment 796270 [details]
emerge --info

In file included from ../libs/ardour/globals.cc:129:
../libs/ardour/ardour/uri_map.h:30:10: fatal error: lv2.h: No such file or directory

Apparently that's because lv2.h was moved away from /usr/include when upgrading 1.18.4 -> 1.18.6.
Comment 1 Sergey 'L29Ah' Alirzaev 2022-07-31 21:46:19 UTC
Created attachment 796273 [details]
build log
Comment 2 Miroslav Šulc gentoo-dev 2022-08-02 07:16:47 UTC
i didn't have time to dig into this yet but ardour-9999 compiles fine so i suppose there's already a fix for this issue.
Comment 4 Miroslav Šulc gentoo-dev 2022-08-02 17:13:56 UTC
nice, thanks. i guess we should do that conditionally though, so that it compiles with both lv2 versions. i'm not skilled in this tbh...
Comment 5 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-08-02 18:43:22 UTC
(In reply to Miroslav Šulc from comment #4)
> nice, thanks. i guess we should do that conditionally though, so that it
> compiles with both lv2 versions. i'm not skilled in this tbh...

This patch should be safe to conditionally apply with has_version but it'd be better if we know of some definition to check for the version.

If you look in lv2.h, do you see something mentioning the version?
Comment 6 Olivier Huber 2022-08-05 13:09:33 UTC
From this commit https://github.com/lv2/lv2/commit/e4996396487babb5007c43f42d2b68eb50f08fec it looks like the lack of "/usr/include/lv2.h" was an oversight.

Maybe an -r1 could be rolled for lv2 that includes this patch? Just patching meson.build works well locally
Comment 7 Miroslav Šulc gentoo-dev 2022-08-05 13:30:57 UTC
(In reply to Olivier Huber from comment #6)
> From this commit
> https://github.com/lv2/lv2/commit/e4996396487babb5007c43f42d2b68eb50f08fec
> it looks like the lack of "/usr/include/lv2.h" was an oversight.
> 
> Maybe an -r1 could be rolled for lv2 that includes this patch? Just patching
> meson.build works well locally

good catch, thanks, i'll fix it.
Comment 8 Larry the Git Cow gentoo-dev 2022-08-05 13:34:04 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e836a45dea181c366a63546a3b1e14d3ef0e6e56

commit e836a45dea181c366a63546a3b1e14d3ef0e6e56
Author:     Miroslav Šulc <fordfrog@gentoo.org>
AuthorDate: 2022-08-05 13:33:51 +0000
Commit:     Miroslav Šulc <fordfrog@gentoo.org>
CommitDate: 2022-08-05 13:34:00 +0000

    media-libs/lv2: fixed missing lv2.h in 1.18.6
    
    Closes: https://bugs.gentoo.org/862603
    Closes: https://bugs.gentoo.org/862630
    Closes: https://bugs.gentoo.org/863071
    Signed-off-by: Miroslav Šulc <fordfrog@gentoo.org>

 media-libs/lv2/files/lv2-1.18.6-add-missing-lv2.h.patch    | 14 ++++++++++++++
 media-libs/lv2/{lv2-1.18.6.ebuild => lv2-1.18.6-r1.ebuild} |  4 ++++
 2 files changed, 18 insertions(+)