Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 862591 - sci-geosciences/opencpn-5.6.2 fails to compile (lto): linux_devices.cpp:43:2: error: #error linux_devices requires libusb-1.0 to be available
Summary: sci-geosciences/opencpn-5.6.2 fails to compile (lto): linux_devices.cpp:43:2:...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Marc Schiffbauer
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: lto
  Show dependency tree
 
Reported: 2022-07-31 18:50 UTC by Agostino Sarubbo
Modified: 2023-06-03 11:43 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,511.96 KB, text/plain)
2022-07-31 18:50 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2022-07-31 18:50:34 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: sci-geosciences/opencpn-5.6.2 fails to compile (lto).
Discovered on: amd64 (internal ref: lto_tinderbox)

NOTE:
This machine uses lto with CFLAGS=-flto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing

Here is a bit of explanation:

-Werror=lto-type-mismatch:
User to find possible runtime issues in packages. It likely means the package is unsafe to build & use with LTO.
For projects using the same identifier but with different types across different files, they must be fixed to be consistent across the codebase.

-Werror=odr:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. C++ code must comply with the One Definition Rule (ODR) - see https://en.cppreference.com/w/cpp/language/definition#One_Definition_Rule.

-Werror=strict-aliasing:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO.

Workarounds:
- If upstream is friendly and still active, file a bug upstream. For emulators, codecs, games, or multimedia packages, it may be worth just applying a workaround instead, as upstreams sometimes aren't receptive to these bugs (VALID FOR ALL).
- Use the new 'filter-lto' from flag-o-matic.eclass as it's likely to be unsafe with LTO (VALID FOR lto-type-mismatch - odr).
- Fix it yourself if interested, of course (VALID FOR ALL).
- Append-flags -fno-strict-aliasing (VALID FOR strict-aliasing).
- Use memcpy() but a union is sometimes suitable too (VALID FOR strict-aliasing).
- -fstrict-aliasing is implied by -O2, so this must be addressed in some form (VALID FOR strict-aliasing).

See also: https://marc.info/?l=gentoo-dev&m=165639574126280&w=2
Comment 1 Agostino Sarubbo gentoo-dev 2022-07-31 18:50:38 UTC
Created attachment 796252 [details]
build.log

build log and emerge --info
Comment 2 Agostino Sarubbo gentoo-dev 2022-07-31 18:50:40 UTC
Error(s) that match a know pattern in addition to what has been reported in the summary:


--   Package 'sndfile', required by 'virtual:world', not found
-- Could NOT find EXIF (missing: EXIF_LIBRARY EXIF_INCLUDE_DIR) (found version "")
-- Could NOT find Jasper (missing: JASPER_LIBRARIES JASPER_INCLUDE_DIR) 
-- Could NOT find LIBUSB (missing: LIBUSB_INCLUDE_DIR LIBUSB_LIBRARIES) 
-- Could NOT find LibSndFile (missing: LIBSNDFILE_LIBRARY LIBSNDFILE_INCLUDE_DIR) 
-- Could NOT find wxWidgets (missing: wxWidgets_LIBRARIES) 
-- Could not find wxWidgets webview add-on
-- ENABLE_LIBSNDFILE is set but I cannot find libsndfile
-- OCPN_ENABLE_SYSTEM_CMD_SOUND is set but I cannot find aplay(1) or afplay(1) or omxplayer(1)
/var/tmp/portage/sci-geosciences/opencpn-5.6.2/work/OpenCPN-Release_5.6.2/src/linux_devices.cpp:45:10: fatal error: libusb.h: No such file or directory
FAILED: CMakeFiles/opencpn.dir/src/linux_devices.cpp.o 
/var/tmp/portage/sci-geosciences/opencpn-5.6.2/work/OpenCPN-Release_5.6.2/src/linux_devices.cpp:43:2: error: #error linux_devices requires libusb-1.0 to be available
Comment 3 Larry the Git Cow gentoo-dev 2023-06-03 11:43:11 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5d08c4cb6dc345dc7e784027cb6a8dc4717cad76

commit 5d08c4cb6dc345dc7e784027cb6a8dc4717cad76
Author:     Marc Schiffbauer <mschiff@gentoo.org>
AuthorDate: 2023-06-03 11:41:12 +0000
Commit:     Marc Schiffbauer <mschiff@gentoo.org>
CommitDate: 2023-06-03 11:43:00 +0000

    sci-geosciences/opencpn: fix build deps
    
    Closes: https://bugs.gentoo.org/862591
    Closes: https://bugs.gentoo.org/846953
    Bug: https://bugs.gentoo.org/907738
    Signed-off-by: Marc Schiffbauer <mschiff@gentoo.org>

 sci-geosciences/opencpn/opencpn-5.6.2-r2.ebuild |  7 +--
 sci-geosciences/opencpn/opencpn-5.6.2-r3.ebuild | 63 +++++++++++++++++++++++
 sci-geosciences/opencpn/opencpn-5.8.2-r2.ebuild | 67 +++++++++++++++++++++++++
 3 files changed, 134 insertions(+), 3 deletions(-)