Bug 862582 – sci-geosciences/laszip-3.4.1 fails to compile (lto): lasreaditemcompressed_v3.cpp:37:16: error: type struct LASpoint14 violates the C++ One Definition Rule [-Werror=odr]

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Agostino Sarubbo 2022-07-31 18:44:21 UTC]

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: sci-geosciences/laszip-3.4.1 fails to compile (lto).
Discovered on: amd64 (internal ref: lto_tinderbox)

NOTE:
This machine uses lto with CFLAGS=-flto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing

Here is a bit of explanation:

-Werror=lto-type-mismatch:
User to find possible runtime issues in packages. It likely means the package is unsafe to build & use with LTO.
For projects using the same identifier but with different types across different files, they must be fixed to be consistent across the codebase.

-Werror=odr:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. C++ code must comply with the One Definition Rule (ODR) - see https://en.cppreference.com/w/cpp/language/definition#One_Definition_Rule.

-Werror=strict-aliasing:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO.

Workarounds:
- If upstream is friendly and still active, file a bug upstream. For emulators, codecs, games, or multimedia packages, it may be worth just applying a workaround instead, as upstreams sometimes aren't receptive to these bugs (VALID FOR ALL).
- Use the new 'filter-lto' from flag-o-matic.eclass as it's likely to be unsafe with LTO (VALID FOR lto-type-mismatch - odr).
- Fix it yourself if interested, of course (VALID FOR ALL).
- Append-flags -fno-strict-aliasing (VALID FOR strict-aliasing).
- Use memcpy() but a union is sometimes suitable too (VALID FOR strict-aliasing).
- -fstrict-aliasing is implied by -O2, so this must be addressed in some form (VALID FOR strict-aliasing).

See also: https://marc.info/?l=gentoo-dev&m=165639574126280&w=2

[Comment 1 Agostino Sarubbo 2022-07-31 18:44:24 UTC]

Created attachment 796240 [details]
build.log

build log and emerge --info

[Comment 2 Agostino Sarubbo 2022-07-31 18:44:26 UTC]

Error(s) that match a know pattern in addition to what has been reported in the summary:


FAILED: lib64/liblaszip.so.8.0.4 
/var/tmp/portage/sci-geosciences/laszip-3.4.1/work/laszip-src-3.4.1/src/lasreaditemcompressed_v3.cpp:37:16: error: type ‘struct LASpoint14’ violates the C++ One Definition Rule [-Werror=odr]

[Comment 3 Larry the Git Cow 2024-03-15 07:03:46 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=658f0410adfff5e7f92106bdc0a4458632d8ccce

commit 658f0410adfff5e7f92106bdc0a4458632d8ccce
Author:     Eli Schwartz <[e-mail]>
AuthorDate: 2024-03-15 06:52:06 +0000
Commit:     Sam James <[e-mail]>
CommitDate: 2024-03-15 07:01:49 +0000

    sci-geosciences/laszip: mark as LTO-unsafe
    
    Closes: https://bugs.gentoo.org/862582
    Signed-off-by: Eli Schwartz <[e-mail]>
    Signed-off-by: Sam James <[e-mail]>

 sci-geosciences/laszip/laszip-3.4.1.ebuild | 13 +++++++++++--
 1 file changed, 11 insertions(+), 2 deletions(-)

Additionally, it has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5426205390c7afe9a53817e27035c76a1460cda2

commit 5426205390c7afe9a53817e27035c76a1460cda2
Author:     Eli Schwartz <[e-mail]>
AuthorDate: 2024-03-15 06:55:22 +0000
Commit:     Sam James <[e-mail]>
CommitDate: 2024-03-15 07:01:50 +0000

    sci-geosciences/laszip: add 3.4.3
    
    New version contains fix for LTO. Drop workaround.
    
    Bug: https://bugs.gentoo.org/862582
    Signed-off-by: Eli Schwartz <[e-mail]>
    Signed-off-by: Sam James <[e-mail]>

 sci-geosciences/laszip/Manifest            |  1 +
 sci-geosciences/laszip/laszip-3.4.3.ebuild | 16 ++++++++++++++++
 2 files changed, 17 insertions(+)