Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 862438 - sci-chemistry/prekin-6.51.081122-r1 fails to compile (lto): PKINCRTL.c:59:20: error: type of [-Werror=lto-type-mismatch]
Summary: sci-chemistry/prekin-6.51.081122-r1 fails to compile (lto): PKINCRTL.c:59:20:...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo Chemistry-Related Packages
URL:
Whiteboard:
Keywords: PMASKED
: 871480 (view as bug list)
Depends on:
Blocks: lto
  Show dependency tree
 
Reported: 2022-07-31 07:29 UTC by Agostino Sarubbo
Modified: 2023-04-21 08:55 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,71.56 KB, text/plain)
2022-07-31 07:29 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2022-07-31 07:29:38 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: sci-chemistry/prekin-6.51.081122-r1 fails to compile (lto).
Discovered on: amd64 (internal ref: lto_tinderbox)

NOTE:
This machine uses lto with CFLAGS=-flto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing

Here is a bit of explanation:

-Werror=lto-type-mismatch:
User to find possible runtime issues in packages. It likely means the package is unsafe to build & use with LTO.
For projects using the same identifier but with different types across different files, they must be fixed to be consistent across the codebase.

-Werror=odr:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. C++ code must comply with the One Definition Rule (ODR) - see https://en.cppreference.com/w/cpp/language/definition#One_Definition_Rule.

-Werror=strict-aliasing:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO.

Workarounds:
- If upstream is friendly and still active, file a bug upstream. For emulators, codecs, games, or multimedia packages, it may be worth just applying a workaround instead, as upstreams sometimes aren't receptive to these bugs (VALID FOR ALL).
- Use the new 'filter-lto' from flag-o-matic.eclass as it's likely to be unsafe with LTO (VALID FOR lto-type-mismatch - odr).
- Fix it yourself if interested, of course (VALID FOR ALL).
- Append-flags -fno-strict-aliasing (VALID FOR strict-aliasing).
- Use memcpy() but a union is sometimes suitable too (VALID FOR strict-aliasing).
- -fstrict-aliasing is implied by -O2, so this must be addressed in some form (VALID FOR strict-aliasing).

See also: https://marc.info/?l=gentoo-dev&m=165639574126280&w=2
Comment 1 Agostino Sarubbo gentoo-dev 2022-07-31 07:29:40 UTC
Created attachment 795964 [details]
build.log

build log and emerge --info
Comment 2 David Seifert gentoo-dev 2023-03-18 18:06:47 UTC
*** Bug 871480 has been marked as a duplicate of this bug. ***
Comment 3 Larry the Git Cow gentoo-dev 2023-03-18 18:28:33 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f40b613cc49c45dd04deaf5266f57ad0040f2f67

commit f40b613cc49c45dd04deaf5266f57ad0040f2f67
Author:     David Seifert <soap@gentoo.org>
AuthorDate: 2023-03-18 18:28:25 +0000
Commit:     David Seifert <soap@gentoo.org>
CommitDate: 2023-03-18 18:28:25 +0000

    package.mask: Last rite sci-chemistry/prekin
    
    Bug: https://bugs.gentoo.org/862438
    Signed-off-by: David Seifert <soap@gentoo.org>

 profiles/package.mask | 6 ++++++
 1 file changed, 6 insertions(+)
Comment 4 Larry the Git Cow gentoo-dev 2023-04-21 08:55:13 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e8705e27aa47338599ae10b2f412b316ddf42a31

commit e8705e27aa47338599ae10b2f412b316ddf42a31
Author:     David Seifert <soap@gentoo.org>
AuthorDate: 2023-04-21 08:54:22 +0000
Commit:     David Seifert <soap@gentoo.org>
CommitDate: 2023-04-21 08:54:22 +0000

    sci-chemistry/prekin: treeclean
    
    Closes: https://bugs.gentoo.org/862438
    Signed-off-by: David Seifert <soap@gentoo.org>

 profiles/package.mask                              |  6 ---
 sci-chemistry/prekin/Manifest                      |  1 -
 .../prekin/files/6.51.081122-Makefile.patch        | 39 -----------------
 .../prekin/files/6.51.081122-overflow.patch        | 26 ------------
 .../files/prekin-6.51.081122-fno-common.patch      | 34 ---------------
 sci-chemistry/prekin/metadata.xml                  |  8 ----
 sci-chemistry/prekin/prekin-6.51.081122-r1.ebuild  | 49 ----------------------
 7 files changed, 163 deletions(-)