Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 861959 - net-wireless/osmo-fl2k-0.1.1-r1 fails to compile (lto): <artificial>:(.text+0x839): undefined reference to dds_set_freq
Summary: net-wireless/osmo-fl2k-0.1.1-r1 fails to compile (lto): <artificial>:(.text+0...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Radio project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: lto
  Show dependency tree
 
Reported: 2022-07-29 10:48 UTC by Agostino Sarubbo
Modified: 2023-12-20 20:47 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,60.06 KB, text/plain)
2022-07-29 10:48 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2022-07-29 10:48:21 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: net-wireless/osmo-fl2k-0.1.1-r1 fails to compile (lto).
Discovered on: amd64 (internal ref: lto_tinderbox)

NOTE:
This machine uses lto with CFLAGS=-flto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing

Here is a bit of explanation:

-Werror=lto-type-mismatch:
User to find possible runtime issues in packages. It likely means the package is unsafe to build & use with LTO.
For projects using the same identifier but with different types across different files, they must be fixed to be consistent across the codebase.

-Werror=odr:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. C++ code must comply with the One Definition Rule (ODR) - see https://en.cppreference.com/w/cpp/language/definition#One_Definition_Rule.

-Werror=strict-aliasing:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO.

Workarounds:
- If upstream is friendly and still active, file a bug upstream. For emulators, codecs, games, or multimedia packages, it may be worth just applying a workaround instead, as upstreams sometimes aren't receptive to these bugs (VALID FOR ALL).
- Use the new 'filter-lto' from flag-o-matic.eclass as it's likely to be unsafe with LTO (VALID FOR lto-type-mismatch - odr).
- Fix it yourself if interested, of course (VALID FOR ALL).
- Append-flags -fno-strict-aliasing (VALID FOR strict-aliasing).
- Use memcpy() but a union is sometimes suitable too (VALID FOR strict-aliasing).
- -fstrict-aliasing is implied by -O2, so this must be addressed in some form (VALID FOR strict-aliasing).

See also: https://marc.info/?l=gentoo-dev&m=165639574126280&w=2
Comment 1 Agostino Sarubbo gentoo-dev 2022-07-29 10:48:23 UTC
Created attachment 795467 [details]
build.log

build log and emerge --info
Comment 2 Agostino Sarubbo gentoo-dev 2022-07-29 10:48:25 UTC
Error(s) that match a know pattern in addition to what has been reported in the summary:


<artificial>:(.text+0x839): undefined reference to `dds_set_freq'
FAILED: src/fl2k_fm 
fatal: not a git repository (or any parent up to mount point /var/tmp)
collect2: error: ld returned 1 exit status
Comment 3 Larry the Git Cow gentoo-dev 2023-12-20 20:47:52 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=04f21bc5e9ab20d7ee579d4afda1dcd5723d9b72

commit 04f21bc5e9ab20d7ee579d4afda1dcd5723d9b72
Author:     Rick Farina <zerochaos@gentoo.org>
AuthorDate: 2023-12-20 20:45:22 +0000
Commit:     Rick Farina <zerochaos@gentoo.org>
CommitDate: 2023-12-20 20:47:15 +0000

    net-wireless/osmo-fl2k: add 0.2.0
    
    Migrate to new upstream git service.
    Closes: https://bugs.gentoo.org/861959
    Signed-off-by: Rick Farina <zerochaos@gentoo.org>

 net-wireless/osmo-fl2k/Manifest               |  1 +
 net-wireless/osmo-fl2k/osmo-fl2k-0.2.0.ebuild | 62 +++++++++++++++++++++++++++
 net-wireless/osmo-fl2k/osmo-fl2k-9999.ebuild  |  6 +--
 3 files changed, 66 insertions(+), 3 deletions(-)