https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/ Issue: net-p2p/rtorrent-0.9.8-r1 fails to compile (lto). Discovered on: amd64 (internal ref: lto_tinderbox) NOTE: This machine uses lto with CFLAGS=-flto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing Here is a bit of explanation: -Werror=lto-type-mismatch: User to find possible runtime issues in packages. It likely means the package is unsafe to build & use with LTO. For projects using the same identifier but with different types across different files, they must be fixed to be consistent across the codebase. -Werror=odr: Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. C++ code must comply with the One Definition Rule (ODR) - see https://en.cppreference.com/w/cpp/language/definition#One_Definition_Rule. -Werror=strict-aliasing: Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. Workarounds: - If upstream is friendly and still active, file a bug upstream. For emulators, codecs, games, or multimedia packages, it may be worth just applying a workaround instead, as upstreams sometimes aren't receptive to these bugs (VALID FOR ALL). - Use the new 'filter-lto' from flag-o-matic.eclass as it's likely to be unsafe with LTO (VALID FOR lto-type-mismatch - odr). - Fix it yourself if interested, of course (VALID FOR ALL). - Append-flags -fno-strict-aliasing (VALID FOR strict-aliasing). - Use memcpy() but a union is sometimes suitable too (VALID FOR strict-aliasing). - -fstrict-aliasing is implied by -O2, so this must be addressed in some form (VALID FOR strict-aliasing). See also: https://marc.info/?l=gentoo-dev&m=165639574126280&w=2
Created attachment 795356 [details] build.log build log and emerge --info
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6708cbb7fc2c495fb9bd14dc974ad7e09f3f4a7f commit 6708cbb7fc2c495fb9bd14dc974ad7e09f3f4a7f Author: Eli Schwartz <eschwartz93@gmail.com> AuthorDate: 2024-02-29 04:21:46 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2024-02-29 04:47:16 +0000 net-p2p/rtorrent: mark as LTO-unsafe Closes: https://bugs.gentoo.org/861848 Signed-off-by: Eli Schwartz <eschwartz93@gmail.com> Signed-off-by: Sam James <sam@gentoo.org> net-p2p/rtorrent/rtorrent-0.9.8-r2.ebuild | 7 ++++++- net-p2p/rtorrent/rtorrent-0.9.8-r3.ebuild | 9 +++++++-- 2 files changed, 13 insertions(+), 3 deletions(-)
https://github.com/rakshasa/rtorrent/releases/tag/v0.10.0 There is finally a new release out since 2019 and it includes the fix that was proposed upstream for this.
0.15.0 has another ODR fix: https://github.com/rakshasa/rtorrent/commit/3c65afcf8ca94a01e1b11a5b2a53e65054d32f10
