https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/ Issue: net-p2p/airdcpp-webclient-2.11.2 fails to compile (lto). Discovered on: amd64 (internal ref: lto_tinderbox) NOTE: This machine uses lto with CFLAGS=-flto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing Here is a bit of explanation: -Werror=lto-type-mismatch: User to find possible runtime issues in packages. It likely means the package is unsafe to build & use with LTO. For projects using the same identifier but with different types across different files, they must be fixed to be consistent across the codebase. -Werror=odr: Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. C++ code must comply with the One Definition Rule (ODR) - see https://en.cppreference.com/w/cpp/language/definition#One_Definition_Rule. -Werror=strict-aliasing: Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. Workarounds: - If upstream is friendly and still active, file a bug upstream. For emulators, codecs, games, or multimedia packages, it may be worth just applying a workaround instead, as upstreams sometimes aren't receptive to these bugs (VALID FOR ALL). - Use the new 'filter-lto' from flag-o-matic.eclass as it's likely to be unsafe with LTO (VALID FOR lto-type-mismatch - odr). - Fix it yourself if interested, of course (VALID FOR ALL). - Append-flags -fno-strict-aliasing (VALID FOR strict-aliasing). - Use memcpy() but a union is sometimes suitable too (VALID FOR strict-aliasing). - -fstrict-aliasing is implied by -O2, so this must be addressed in some form (VALID FOR strict-aliasing). See also: https://marc.info/?l=gentoo-dev&m=165639574126280&w=2
Created attachment 795347 [details] build.log build log and emerge --info
Error(s) that match a know pattern in addition to what has been reported in the summary: FAILED: airdcpp-core/libairdcpp.so.2.11.2 /var/tmp/portage/net-p2p/airdcpp-webclient-2.11.2/work/airdcpp-webclient-2.11.2/airdcpp-core/airdcpp/File.h:87:14: error: type ‘dcpp::File::BufferMode’ violates the C++ One Definition Rule [-Werror=odr]
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3c87eae224d451e0433cd4338773f945fb879277 commit 3c87eae224d451e0433cd4338773f945fb879277 Author: Louis Sautier <sbraz@gentoo.org> AuthorDate: 2022-11-05 19:12:03 +0000 Commit: Louis Sautier <sbraz@gentoo.org> CommitDate: 2022-11-05 19:35:53 +0000 net-p2p/airdcpp-webclient: fix build with strict flags, add Py3.11 Closes: https://bugs.gentoo.org/861839 Signed-off-by: Louis Sautier <sbraz@gentoo.org> .../airdcpp-webclient-2.11.2.ebuild | 6 +++++- .../files/airdcpp-webclient-2.11.2-fix-odr.patch | 22 ++++++++++++++++++++++ 2 files changed, 27 insertions(+), 1 deletion(-)
