Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 861686 - net-misc/netifrc-0.7.6 installs udev rules without calling udev_reload
Summary: net-misc/netifrc-0.7.6 installs udev rules without calling udev_reload
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: netifrc Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-07-28 09:19 UTC by Agostino Sarubbo
Modified: 2023-10-03 20:43 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,48.07 KB, text/plain)
2022-07-28 09:19 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2022-07-28 09:19:34 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: net-misc/netifrc-0.7.3-r1 installs udev rules without calling udev_reload.
Discovered on: amd64 (internal ref: lto_tinderbox)

NOTE:
This machine uses lto with CFLAGS=-flto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing

Here is a bit of explanation:

-Werror=lto-type-mismatch:
User to find possible runtime issues in packages. It likely means the package is unsafe to build & use with LTO.
For projects using the same identifier but with different types across different files, they must be fixed to be consistent across the codebase.

-Werror=odr:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. C++ code must comply with the One Definition Rule (ODR) - see https://en.cppreference.com/w/cpp/language/definition#One_Definition_Rule.

-Werror=strict-aliasing:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO.

Workarounds:
- If upstream is friendly and still active, file a bug upstream. For emulators, codecs, games, or multimedia packages, it may be worth just applying a workaround instead, as upstreams sometimes aren't receptive to these bugs (VALID FOR ALL).
- Use the new 'filter-lto' from flag-o-matic.eclass as it's likely to be unsafe with LTO (VALID FOR lto-type-mismatch - odr).
- Fix it yourself if interested, of course (VALID FOR ALL).
- Append-flags -fno-strict-aliasing (VALID FOR strict-aliasing).
- Use memcpy() but a union is sometimes suitable too (VALID FOR strict-aliasing).
- -fstrict-aliasing is implied by -O2, so this must be addressed in some form (VALID FOR strict-aliasing).

See also: https://marc.info/?l=gentoo-dev&m=165639574126280&w=2
Comment 1 Agostino Sarubbo gentoo-dev 2022-07-28 09:19:37 UTC
Created attachment 795221 [details]
build.log

build log and emerge --info
Comment 2 Agostino Sarubbo gentoo-dev 2023-04-17 07:41:51 UTC
ci has reproduced this issue with version 0.7.4 - Updating summary.
Comment 3 Agostino Sarubbo gentoo-dev 2023-05-29 06:03:59 UTC
ci has reproduced this issue with version 0.7.5 - Updating summary.
Comment 4 Agostino Sarubbo gentoo-dev 2023-09-11 06:51:17 UTC
ci has reproduced this issue with version 0.7.6 - Updating summary.
Comment 5 Larry the Git Cow gentoo-dev 2023-10-03 20:43:01 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=7666992380a6ea303e04eec4457e1b11c2cda310

commit 7666992380a6ea303e04eec4457e1b11c2cda310
Author:     Patrick McLean <chutzpah@gentoo.org>
AuthorDate: 2023-10-03 20:40:51 +0000
Commit:     Patrick McLean <chutzpah@gentoo.org>
CommitDate: 2023-10-03 20:40:51 +0000

    net-misc/netifrc: revbump, add busybox to dhcp (bug #846488), bug #861686
    
    Closes: https://bugs.gentoo.org/846488
    Closes: https://bugs.gentoo.org/861686
    Signed-off-by: Patrick McLean <chutzpah@gentoo.org>

 net-misc/netifrc/netifrc-0.7.6-r1.ebuild | 91 ++++++++++++++++++++++++++++++++
 net-misc/netifrc/netifrc-9999.ebuild     | 17 +++++-
 2 files changed, 106 insertions(+), 2 deletions(-)