Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 861638 - [guru] app-shells/fzf-tab-0_pre20220331-r1 fails tests (lto)
Summary: [guru] app-shells/fzf-tab-0_pre20220331-r1 fails tests (lto)
Status: RESOLVED FIXED
Alias: None
Product: GURU
Classification: Unclassified
Component: Package issues (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: tastytea
URL: https://github.com/Aloxaf/fzf-tab/iss...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-07-28 07:13 UTC by Agostino Sarubbo
Modified: 2022-11-26 10:54 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,79.95 KB, text/plain)
2022-07-28 07:14 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2022-07-28 07:13:58 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: app-shells/fzf-tab-0_pre20220331-r1 fails tests (lto).
Discovered on: amd64 (internal ref: guru_tinderbox)

NOTE:
This machine uses lto with CFLAGS=-flto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing

Here is a bit of explanation:

-Werror=lto-type-mismatch:
User to find possible runtime issues in packages. It likely means the package is unsafe to build & use with LTO.
For projects using the same identifier but with different types across different files, they must be fixed to be consistent across the codebase.

-Werror=odr:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. C++ code must comply with the One Definition Rule (ODR) - see https://en.cppreference.com/w/cpp/language/definition#One_Definition_Rule.

-Werror=strict-aliasing:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO.

Workarounds:
- If upstream is friendly and still active, file a bug upstream. For emulators, codecs, games, or multimedia packages, it may be worth just applying a workaround instead, as upstreams sometimes aren't receptive to these bugs (VALID FOR ALL).
- Use the new 'filter-lto' from flag-o-matic.eclass as it's likely to be unsafe with LTO (VALID FOR lto-type-mismatch - odr).
- Fix it yourself if interested, of course (VALID FOR ALL).
- Append-flags -fno-strict-aliasing (VALID FOR strict-aliasing).
- Use memcpy() but a union is sometimes suitable too (VALID FOR strict-aliasing).
- -fstrict-aliasing is implied by -O2, so this must be addressed in some form (VALID FOR strict-aliasing).

See also: https://marc.info/?l=gentoo-dev&m=165639574126280&w=2
Comment 1 Agostino Sarubbo gentoo-dev 2022-07-28 07:14:00 UTC
Created attachment 795143 [details]
build.log

build log and emerge --info
Comment 2 tastytea 2022-08-20 08:04:57 UTC
The tests are passing with zsh 5.8.1 and failing with 5.9. Upstream is notified.
Comment 3 Larry the Git Cow gentoo-dev 2022-09-30 02:12:28 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/proj/guru.git/commit/?id=16318ed8adffc195bea415389111a3352e3fcc1e

commit 16318ed8adffc195bea415389111a3352e3fcc1e
Author:     Ronny (tastytea) Gutbrod <gentoo@tastytea.de>
AuthorDate: 2022-09-29 14:17:10 +0000
Commit:     Ronny (tastytea) Gutbrod <gentoo@tastytea.de>
CommitDate: 2022-09-29 14:17:10 +0000

    app-shells/fzf-tab: disable tests
    
    Bug: https://bugs.gentoo.org/861638
    Signed-off-by: Ronny (tastytea) Gutbrod <gentoo@tastytea.de>

 app-shells/fzf-tab/fzf-tab-0_pre20220331-r1.ebuild | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 4 Larry the Git Cow gentoo-dev 2022-11-26 10:54:19 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/proj/guru.git/commit/?id=49a4641c8a7ef858d6671358b832d587a15fb064

commit 49a4641c8a7ef858d6671358b832d587a15fb064
Author:     Ronny (tastytea) Gutbrod <gentoo@tastytea.de>
AuthorDate: 2022-11-24 13:18:57 +0000
Commit:     Ronny (tastytea) Gutbrod <gentoo@tastytea.de>
CommitDate: 2022-11-24 13:23:49 +0000

    app-shells/fzf-tab: add 0_pre20221124
    
    Closes: https://bugs.gentoo.org/861638
    Signed-off-by: Ronny (tastytea) Gutbrod <gentoo@tastytea.de>

 app-shells/fzf-tab/Manifest                     |  1 +
 app-shells/fzf-tab/fzf-tab-0_pre20221124.ebuild | 73 +++++++++++++++++++++++++
 2 files changed, 74 insertions(+)