Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 861611 - net-misc/dibbler-1.0.1-r3 fails to compile (lto): daemon.h:30:5: error: die violates the C++ One Definition Rule [-Werror=odr]
Summary: net-misc/dibbler-1.0.1-r3 fails to compile (lto): daemon.h:30:5: error: die v...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Bernard Cafarelli
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: lto
  Show dependency tree
 
Reported: 2022-07-28 07:04 UTC by Agostino Sarubbo
Modified: 2023-02-15 05:02 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,196.34 KB, text/plain)
2022-07-28 07:04 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2022-07-28 07:04:01 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: net-misc/dibbler-1.0.1-r3 fails to compile (lto).
Discovered on: amd64 (internal ref: lto_tinderbox)

NOTE:
This machine uses lto with CFLAGS=-flto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing

Here is a bit of explanation:

-Werror=lto-type-mismatch:
User to find possible runtime issues in packages. It likely means the package is unsafe to build & use with LTO.
For projects using the same identifier but with different types across different files, they must be fixed to be consistent across the codebase.

-Werror=odr:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. C++ code must comply with the One Definition Rule (ODR) - see https://en.cppreference.com/w/cpp/language/definition#One_Definition_Rule.

-Werror=strict-aliasing:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO.

Workarounds:
- If upstream is friendly and still active, file a bug upstream. For emulators, codecs, games, or multimedia packages, it may be worth just applying a workaround instead, as upstreams sometimes aren't receptive to these bugs (VALID FOR ALL).
- Use the new 'filter-lto' from flag-o-matic.eclass as it's likely to be unsafe with LTO (VALID FOR lto-type-mismatch - odr).
- Fix it yourself if interested, of course (VALID FOR ALL).
- Append-flags -fno-strict-aliasing (VALID FOR strict-aliasing).
- Use memcpy() but a union is sometimes suitable too (VALID FOR strict-aliasing).
- -fstrict-aliasing is implied by -O2, so this must be addressed in some form (VALID FOR strict-aliasing).

See also: https://marc.info/?l=gentoo-dev&m=165639574126280&w=2
Comment 1 Agostino Sarubbo gentoo-dev 2022-07-28 07:04:03 UTC
Created attachment 795113 [details]
build.log

build log and emerge --info
Comment 2 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-07-28 07:11:00 UTC
fwiw, from HOMEPAGE:

"Dibbler project is now concluded. I've been maintaining it for 15 years or so, but it's time to move on. Some time around 2017, I stopped maintaining or developing the project further. Feel free to use it, but there isn't anyone to fix any bugs or actively working on new features. If you're using dibbler-server, please seriously consider migrating to ISC Kea, which is far better solution. If you're using dibbler-client, consider migrating to one of many better maintained alternatives."
Comment 3 Larry the Git Cow gentoo-dev 2023-02-15 05:02:50 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f869e9bb247373e661a2f0356d90e60b8c15d775

commit f869e9bb247373e661a2f0356d90e60b8c15d775
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2023-02-15 04:14:07 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-02-15 05:02:32 +0000

    net-misc/dibbler: fix build w/ clang 16, filter lto
    
    Closes: https://bugs.gentoo.org/861611
    Signed-off-by: Sam James <sam@gentoo.org>

 net-misc/dibbler/dibbler-1.0.1-r3.ebuild | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)