Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 861443 - [guru] app-editors/helix-22.05 fails to compile (lto): undefined reference to ts_query_delete
Summary: [guru] app-editors/helix-22.05 fails to compile (lto): undefined reference to...
Status: RESOLVED FIXED
Alias: None
Product: GURU
Classification: Unclassified
Component: Package issues (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: degni.public
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-07-27 11:07 UTC by Agostino Sarubbo
Modified: 2023-03-16 08:41 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,496.09 KB, text/plain)
2022-07-27 11:07 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2022-07-27 11:07:35 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: app-editors/helix-22.05 fails to compile (lto).
Discovered on: amd64 (internal ref: guru_tinderbox)

NOTE:
This machine uses lto with CFLAGS=-flto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing

Here is a bit of explanation:

-Werror=lto-type-mismatch:
User to find possible runtime issues in packages. It likely means the package is unsafe to build & use with LTO.
For projects using the same identifier but with different types across different files, they must be fixed to be consistent across the codebase.

-Werror=odr:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. C++ code must comply with the One Definition Rule (ODR) - see https://en.cppreference.com/w/cpp/language/definition#One_Definition_Rule.

-Werror=strict-aliasing:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO.

Workarounds:
- If upstream is friendly and still active, file a bug upstream. For emulators, codecs, games, or multimedia packages, it may be worth just applying a workaround instead, as upstreams sometimes aren't receptive to these bugs (VALID FOR ALL).
- Use the new 'filter-lto' from flag-o-matic.eclass as it's likely to be unsafe with LTO (VALID FOR lto-type-mismatch - odr).
- Fix it yourself if interested, of course (VALID FOR ALL).
- Append-flags -fno-strict-aliasing (VALID FOR strict-aliasing).
- Use memcpy() but a union is sometimes suitable too (VALID FOR strict-aliasing).
- -fstrict-aliasing is implied by -O2, so this must be addressed in some form (VALID FOR strict-aliasing).

See also: https://marc.info/?l=gentoo-dev&m=165639574126280&w=2
Comment 1 Agostino Sarubbo gentoo-dev 2022-07-27 11:07:38 UTC
Created attachment 794885 [details]
build.log

build log and emerge --info
Comment 2 Larry the Git Cow gentoo-dev 2023-03-16 08:41:43 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/proj/guru.git/commit/?id=ef332c32ede95f702cb22ebe806c60b44aad18bf

commit ef332c32ede95f702cb22ebe806c60b44aad18bf
Author:     Florian Schmaus <flow@gentoo.org>
AuthorDate: 2023-03-16 08:37:41 +0000
Commit:     Florian Schmaus <flow@gentoo.org>
CommitDate: 2023-03-16 08:37:41 +0000

    app-editors/helix: treeclean, now in ::gentoo
    
    Closes: https://bugs.gentoo.org/819096
    Closes: https://bugs.gentoo.org/819099
    Closes: https://bugs.gentoo.org/831441
    Closes: https://bugs.gentoo.org/861443
    Closes: https://bugs.gentoo.org/887227
    Closes: https://bugs.gentoo.org/901007
    Signed-off-by: Florian Schmaus <flow@gentoo.org>

 app-editors/helix/Manifest             | 544 ---------------------------------
 app-editors/helix/helix-22.05.ebuild   | 294 ------------------
 app-editors/helix/helix-22.08.1.ebuild | 326 --------------------
 app-editors/helix/helix-22.12.ebuild   | 431 --------------------------
 app-editors/helix/metadata.xml         |  21 --
 5 files changed, 1616 deletions(-)