https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/ Issue: net-fs/cvmfs-2.9.2 fails to compile (lto). Discovered on: amd64 (internal ref: lto_tinderbox) NOTE: This machine uses lto with CFLAGS=-flto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing Here is a bit of explanation: -Werror=lto-type-mismatch: User to find possible runtime issues in packages. It likely means the package is unsafe to build & use with LTO. For projects using the same identifier but with different types across different files, they must be fixed to be consistent across the codebase. -Werror=odr: Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. C++ code must comply with the One Definition Rule (ODR) - see https://en.cppreference.com/w/cpp/language/definition#One_Definition_Rule. -Werror=strict-aliasing: Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. Workarounds: - If upstream is friendly and still active, file a bug upstream. For emulators, codecs, games, or multimedia packages, it may be worth just applying a workaround instead, as upstreams sometimes aren't receptive to these bugs (VALID FOR ALL). - Use the new 'filter-lto' from flag-o-matic.eclass as it's likely to be unsafe with LTO (VALID FOR lto-type-mismatch - odr). - Fix it yourself if interested, of course (VALID FOR ALL). - Append-flags -fno-strict-aliasing (VALID FOR strict-aliasing). - Use memcpy() but a union is sometimes suitable too (VALID FOR strict-aliasing). - -fstrict-aliasing is implied by -O2, so this must be addressed in some form (VALID FOR strict-aliasing). See also: https://marc.info/?l=gentoo-dev&m=165639574126280&w=2
Created attachment 794690 [details] build.log build log and emerge --info
Error(s) that match a know pattern in addition to what has been reported in the summary: FAILED: cvmfs/CMakeFiles/cvmfs_allow_helper.dir/authz/helper_log.cc.o FAILED: cvmfs/CMakeFiles/cvmfs_deny_helper.dir/authz/helper_log.cc.o /var/tmp/portage/net-fs/cvmfs-2.9.2/work/cvmfs-2.9.2/cvmfs/authz/helper_log.cc:120:5: error: ‘time’ was not declared in this scope; did you mean ‘tm’?
The compilation failure is not actually due to usage of lto, but due to a missing include of the <ctime> header (same as bug 871255, therefore marking this as duplicate). This build failure happens only with GCC 12.x. *** This bug has been marked as a duplicate of bug 871255 ***
(In reply to Guilherme Amadio from comment #3) > The compilation failure is not actually due to usage of lto, but due to a > missing include of the <ctime> header (same as bug 871255, therefore marking > this as duplicate) usually the latter is a duplicate of the original bug
Alright, I had marked this as duplicate as the other bug has the proper description, but ok, let me mark them correctly as I did not push the fix yet...
*** Bug 871255 has been marked as a duplicate of this bug. ***
(In reply to Guilherme Amadio from comment #5) > Alright, I had marked this as duplicate as the other bug has the proper > description, but ok, let me mark them correctly as I did not push the fix > yet... no problem :D this is just the first thing that comes in my mind. The (lto) tag in the summary was because people do not properly read comment 0
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=32f413af15d3563f709796756060814aca4cef9f commit 32f413af15d3563f709796756060814aca4cef9f Author: Guilherme Amadio <amadio@gentoo.org> AuthorDate: 2022-09-19 11:50:05 +0000 Commit: Guilherme Amadio <amadio@gentoo.org> CommitDate: 2022-09-19 12:11:14 +0000 net-fs/cvmfs: fix compilation with GCC 12.x, bug 871255 Closes: https://bugs.gentoo.org/861365 Signed-off-by: Guilherme Amadio <amadio@gentoo.org> net-fs/cvmfs/cvmfs-2.9.2.ebuild | 1 + 1 file changed, 1 insertion(+)
