Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 861296 - net-dns/totd-1.5.1 fails to compile (lto): <artificial>:(.text+0x577d): undefined reference to strlcat
Summary: net-dns/totd-1.5.1 fails to compile (lto): <artificial>:(.text+0x577d): undef...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: lto
  Show dependency tree
 
Reported: 2022-07-26 18:31 UTC by Agostino Sarubbo
Modified: 2024-02-10 12:10 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,72.24 KB, text/plain)
2022-07-26 18:31 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2022-07-26 18:31:25 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: net-dns/totd-1.5.1 fails to compile (lto).
Discovered on: amd64 (internal ref: lto_tinderbox)

NOTE:
This machine uses lto with CFLAGS=-flto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing

Here is a bit of explanation:

-Werror=lto-type-mismatch:
User to find possible runtime issues in packages. It likely means the package is unsafe to build & use with LTO.
For projects using the same identifier but with different types across different files, they must be fixed to be consistent across the codebase.

-Werror=odr:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. C++ code must comply with the One Definition Rule (ODR) - see https://en.cppreference.com/w/cpp/language/definition#One_Definition_Rule.

-Werror=strict-aliasing:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO.

Workarounds:
- If upstream is friendly and still active, file a bug upstream. For emulators, codecs, games, or multimedia packages, it may be worth just applying a workaround instead, as upstreams sometimes aren't receptive to these bugs (VALID FOR ALL).
- Use the new 'filter-lto' from flag-o-matic.eclass as it's likely to be unsafe with LTO (VALID FOR lto-type-mismatch - odr).
- Fix it yourself if interested, of course (VALID FOR ALL).
- Append-flags -fno-strict-aliasing (VALID FOR strict-aliasing).
- Use memcpy() but a union is sometimes suitable too (VALID FOR strict-aliasing).
- -fstrict-aliasing is implied by -O2, so this must be addressed in some form (VALID FOR strict-aliasing).

See also: https://marc.info/?l=gentoo-dev&m=165639574126280&w=2
Comment 1 Agostino Sarubbo gentoo-dev 2022-07-26 18:31:27 UTC
Created attachment 794657 [details]
build.log

build log and emerge --info
Comment 2 Agostino Sarubbo gentoo-dev 2022-07-26 18:31:29 UTC
Error(s) that match a know pattern in addition to what has been reported in the summary:


/usr/lib/gcc/x86_64-pc-linux-gnu/12.1.1/../../../../x86_64-pc-linux-gnu/bin/ld: <artificial>:(.text+0x58ae): undefined reference to `strlcat'
/usr/lib/gcc/x86_64-pc-linux-gnu/12.1.1/../../../../x86_64-pc-linux-gnu/bin/ld: <artificial>:(.text+0x92f6): undefined reference to `strlcpy'
/usr/lib/gcc/x86_64-pc-linux-gnu/12.1.1/../../../../x86_64-pc-linux-gnu/bin/ld: <artificial>:(.text+0x986b): undefined reference to `strlcpy'
<artificial>:(.text+0x577d): undefined reference to `strlcat'
<artificial>:(.text+0x6215): undefined reference to `strlcpy'
<artificial>:(.text+0x7801): undefined reference to `strlcpy'
<artificial>:(.text+0x9146): undefined reference to `strlcpy'
<artificial>:(.text+0xb248): undefined reference to `strlcat'
collect2: error: ld returned 1 exit status
Comment 3 Larry the Git Cow gentoo-dev 2024-02-10 12:10:41 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=63b794b3a21829c48815eb69dd2358470a8e1814

commit 63b794b3a21829c48815eb69dd2358470a8e1814
Author:     Jakov Smolić <jsmolic@gentoo.org>
AuthorDate: 2024-02-10 12:06:51 +0000
Commit:     Jakov Smolić <jsmolic@gentoo.org>
CommitDate: 2024-02-10 12:06:51 +0000

    net-dns/totd: treeclean
    
    Closes: https://bugs.gentoo.org/861296
    Closes: https://bugs.gentoo.org/900058
    Bug: https://bugs.gentoo.org/856466
    Bug: https://bugs.gentoo.org/865253
    Signed-off-by: Jakov Smolić <jsmolic@gentoo.org>

 net-dns/totd/Manifest                         |  1 -
 net-dns/totd/files/totd                       | 38 -------------------------
 net-dns/totd/files/totd-1.5.1-fix-CC.patch    | 11 --------
 net-dns/totd/files/totd-1.5.1-no_werror.patch | 11 --------
 net-dns/totd/metadata.xml                     | 10 -------
 net-dns/totd/totd-1.5.1.ebuild                | 40 ---------------------------
 profiles/package.mask                         |  5 ----
 7 files changed, 116 deletions(-)