Bug 861242 – net-analyzer/suricata-6.0.6 fails to compile (lto): runmode-af-packet.c:60:12: error: type of max_pending_packets does not match original declaration [-Werror=lto-type-mismatch]

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Agostino Sarubbo 2022-07-26 12:29:11 UTC]

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: net-analyzer/suricata-6.0.6 fails to compile (lto).
Discovered on: amd64 (internal ref: lto_tinderbox)

NOTE:
This machine uses lto with CFLAGS=-flto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing

Here is a bit of explanation:

-Werror=lto-type-mismatch:
User to find possible runtime issues in packages. It likely means the package is unsafe to build & use with LTO.
For projects using the same identifier but with different types across different files, they must be fixed to be consistent across the codebase.

-Werror=odr:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. C++ code must comply with the One Definition Rule (ODR) - see https://en.cppreference.com/w/cpp/language/definition#One_Definition_Rule.

-Werror=strict-aliasing:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO.

Workarounds:
- If upstream is friendly and still active, file a bug upstream. For emulators, codecs, games, or multimedia packages, it may be worth just applying a workaround instead, as upstreams sometimes aren't receptive to these bugs (VALID FOR ALL).
- Use the new 'filter-lto' from flag-o-matic.eclass as it's likely to be unsafe with LTO (VALID FOR lto-type-mismatch - odr).
- Fix it yourself if interested, of course (VALID FOR ALL).
- Append-flags -fno-strict-aliasing (VALID FOR strict-aliasing).
- Use memcpy() but a union is sometimes suitable too (VALID FOR strict-aliasing).
- -fstrict-aliasing is implied by -O2, so this must be addressed in some form (VALID FOR strict-aliasing).

See also: https://marc.info/?l=gentoo-dev&m=165639574126280&w=2

[Comment 1 Agostino Sarubbo 2022-07-26 12:29:16 UTC]

Created attachment 794576 [details]
build.log

build log and emerge --info

[Comment 2 Larry the Git Cow 2022-07-27 23:54:54 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=7f4e93388771731395d5848538531f6419f843f3

commit 7f4e93388771731395d5848538531f6419f843f3
Author:     Marek Szuba <[e-mail]>
AuthorDate: 2022-07-27 23:43:33 +0000
Commit:     Marek Szuba <[e-mail]>
CommitDate: 2022-07-27 23:43:33 +0000

    net-analyzer/suricata: filter out LTO flags
    
    Triggers type mismatches as demonstrated in the linked bug.
    Don't bother doing the same with suricata-5, it is mere days
    away from its end of life.
    
    Closes: https://bugs.gentoo.org/861242
    Signed-off-by: Marek Szuba <[e-mail]>

 net-analyzer/suricata/suricata-6.0.6.ebuild | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)