https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/ Issue: media-sound/lmms-1.2.2 fails to compile (lto). Discovered on: amd64 (internal ref: lto_tinderbox) NOTE: This machine uses lto with CFLAGS=-flto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing
Created attachment 794159 [details] build.log.xz build log and emerge --info (compressed because it exceeds attachment limit, use 'xzless' to read it)
Error(s) that match a know pattern in addition to what has been reported in the summary: Could not find a package configuration file provided by "Qt5Test" with any -- Package 'carla-native-plugin', required by 'virtual:world', not found -- Package 'carla-standalone', required by 'virtual:world', not found -- Could NOT find Doxygen (missing: DOXYGEN_EXECUTABLE) -- Could NOT find SNDIO (missing: SNDIO_LIBRARY SNDIO_INCLUDE_DIR HAVE_SIO_OPEN) FAILED: plugins/libZynAddSubFxCore.so fatal: not a git repository (or any parent up to mount point /var/tmp) /var/tmp/portage/media-sound/lmms-1.2.2/work/lmms/include/MidiEvent.h:33:7: error: type ‘struct MidiEvent’ violates the C++ One Definition Rule [-Werror=odr]
Here is a bit of explanation: -Werror=lto-type-mismatch: User to find possible runtime issues in packages. It likely means the package is unsafe to build & use with LTO. For projects using the same identifier but with different types across different files, they must be fixed to be consistent across the codebase. -Werror=odr: Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. C++ code must comply with the One Definition Rule (ODR) - see https://en.cppreference.com/w/cpp/language/definition#One_Definition_Rule. -Werror=strict-aliasing: Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. Workarounds: - If upstream is friendly and still active, file a bug upstream. For emulators, codecs, games, or multimedia packages, it may be worth just applying a workaround instead, as upstreams sometimes aren't receptive to these bugs (VALID FOR ALL). - Use the new 'filter-lto' from flag-o-matic.eclass as it's likely to be unsafe with LTO (VALID FOR lto-type-mismatch - odr). - Fix it yourself if interested, of course (VALID FOR ALL). - Append-flags -fno-strict-aliasing (VALID FOR strict-aliasing). - Use memcpy() but a union is sometimes suitable too (VALID FOR strict-aliasing). - -fstrict-aliasing is implied by -O2, so this must be addressed in some form (VALID FOR strict-aliasing). See also: https://marc.info/?l=gentoo-dev&m=165639574126280&w=2
lto_tinderbox has reproduced this issue with version 1.2.2-r1 - Updating summary.
Fixed upstream -- even before this ticket was opened, even! Unfortunately, it's been years since a release.
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2c291d432f5cd25656bb6520e02e39b3fdc97a1a commit 2c291d432f5cd25656bb6520e02e39b3fdc97a1a Author: Eli Schwartz <eschwartz@gentoo.org> AuthorDate: 2024-07-31 19:41:52 +0000 Commit: Eli Schwartz <eschwartz@gentoo.org> CommitDate: 2024-07-31 21:16:53 +0000 media-sound/lmms: mark as LTO-unsafe Fixed upstream in git, leave off of live ebuild. Closes: https://bugs.gentoo.org/860867 Signed-off-by: Eli Schwartz <eschwartz@gentoo.org> media-sound/lmms/lmms-1.2.2-r2.ebuild | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-)
