Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 860864 - media-sound/hydrogen-1.1.1 fails to compile (lto): ExportMidiDialog.cpp:39:6: error: type ExportModes violates the C++ One Definition Rule [-Werror=odr]
Summary: media-sound/hydrogen-1.1.1 fails to compile (lto): ExportMidiDialog.cpp:39:6:...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Professional Audio Applications Maintainers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: lto
  Show dependency tree
 
Reported: 2022-07-25 06:53 UTC by Agostino Sarubbo
Modified: 2023-05-10 05:25 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,300.26 KB, text/plain)
2022-07-25 06:53 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2022-07-25 06:53:17 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: media-sound/hydrogen-1.1.1 fails to compile (lto).
Discovered on: amd64 (internal ref: lto_tinderbox)

NOTE:
This machine uses lto with CFLAGS=-flto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing
Comment 1 Agostino Sarubbo gentoo-dev 2022-07-25 06:53:20 UTC
Created attachment 794156 [details]
build.log

build log and emerge --info
Comment 2 Agostino Sarubbo gentoo-dev 2022-07-25 06:53:22 UTC
Error(s) that match a know pattern in addition to what has been reported in the summary:


--   Package 'alsa', required by 'virtual:world', not found
--   Package 'cppunit', required by 'virtual:world', not found
--   Package 'jack', required by 'virtual:world', not found
--   Package 'lash-1.0', required by 'virtual:world', not found
--   Package 'liblo', required by 'virtual:world', not found
--   Package 'libpulse', required by 'virtual:world', not found
--   Package 'lrdf', required by 'virtual:world', not found
--   Package 'oss', required by 'virtual:world', not found
--   Package 'portaudio-2.0', required by 'virtual:world', not found
--   Package 'portmidi', required by 'virtual:world', not found
--   Package 'rubberband', required by 'virtual:world', not found
--   Package 'tar', required by 'virtual:world', not found
-- Could NOT find ALSA (missing: ALSA_LIBRARIES ALSA_INCLUDE_DIRS) 
-- Could NOT find CPPUNIT (missing: CPPUNIT_LIBRARIES CPPUNIT_INCLUDE_DIRS) 
-- Could NOT find Doxygen (missing: DOXYGEN_EXECUTABLE) 
-- Could NOT find JACK (missing: JACK_LIBRARIES JACK_INCLUDE_DIRS) 
-- Could NOT find LADSPA (missing: LADSPA_INCLUDE_DIR) 
-- Could NOT find LASH (missing: LASH_LIBRARIES LASH_INCLUDE_DIRS) 
-- Could NOT find LIBTAR (missing: LIBTAR_LIBRARIES) 
-- Could NOT find LRDF (missing: LRDF_LIBRARIES LRDF_INCLUDE_DIRS) 
-- Could NOT find OSC (missing: OSC_LIBRARIES OSC_INCLUDE_DIRS) 
-- Could NOT find OSS (missing: OSS_LIBRARIES) 
-- Could NOT find PORTAUDIO (missing: PORTAUDIO_LIBRARIES PORTAUDIO_INCLUDE_DIRS) 
-- Could NOT find PORTMIDI (missing: PORTMIDI_LIBRARIES PORTMIDI_INCLUDE_DIRS) 
-- Could NOT find PULSEAUDIO (missing: PULSEAUDIO_LIBRARIES PULSEAUDIO_INCLUDE_DIRS) 
-- Could NOT find RUBBERBAND (missing: RUBBERBAND_LIBRARIES RUBBERBAND_INCLUDE_DIRS) 
FAILED: src/gui/hydrogen 
fatal: not a git repository (or any parent up to mount point /var/tmp)
/var/tmp/portage/media-sound/hydrogen-1.1.1/work/hydrogen-1.1.1/src/gui/src/ExportMidiDialog.cpp:39:6: error: type ‘ExportModes’ violates the C++ One Definition Rule [-Werror=odr]
Comment 3 Agostino Sarubbo gentoo-dev 2022-07-26 09:02:50 UTC
Here is a bit of explanation:

-Werror=lto-type-mismatch:
User to find possible runtime issues in packages. It likely means the package is unsafe to build & use with LTO.
For projects using the same identifier but with different types across different files, they must be fixed to be consistent across the codebase.

-Werror=odr:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. C++ code must comply with the One Definition Rule (ODR) - see https://en.cppreference.com/w/cpp/language/definition#One_Definition_Rule.

-Werror=strict-aliasing:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO.

Workarounds:
- If upstream is friendly and still active, file a bug upstream. For emulators, codecs, games, or multimedia packages, it may be worth just applying a workaround instead, as upstreams sometimes aren't receptive to these bugs (VALID FOR ALL).
- Use the new 'filter-lto' from flag-o-matic.eclass as it's likely to be unsafe with LTO (VALID FOR lto-type-mismatch - odr).
- Fix it yourself if interested, of course (VALID FOR ALL).
- Append-flags -fno-strict-aliasing (VALID FOR strict-aliasing).
- Use memcpy() but a union is sometimes suitable too (VALID FOR strict-aliasing).
- -fstrict-aliasing is implied by -O2, so this must be addressed in some form (VALID FOR strict-aliasing).

See also: https://marc.info/?l=gentoo-dev&m=165639574126280&w=2
Comment 4 Larry the Git Cow gentoo-dev 2023-05-10 05:25:09 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b1e56be18ee653048dd45012dee01e0e67a187eb

commit b1e56be18ee653048dd45012dee01e0e67a187eb
Author:     Miroslav Šulc <fordfrog@gentoo.org>
AuthorDate: 2023-05-10 05:24:58 +0000
Commit:     Miroslav Šulc <fordfrog@gentoo.org>
CommitDate: 2023-05-10 05:24:58 +0000

    media-sound/hydrogen: dropped obsolete 1.1.1
    
    Bug: https://bugs.gentoo.org/905988
    Closes: https://bugs.gentoo.org/860864
    Signed-off-by: Miroslav Šulc <fordfrog@gentoo.org>

 media-sound/hydrogen/Manifest              |  1 -
 media-sound/hydrogen/hydrogen-1.1.1.ebuild | 97 ------------------------------
 2 files changed, 98 deletions(-)