https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/ Issue: media-sound/din-54 fails to compile (lto). Discovered on: amd64 (internal ref: lto_tinderbox) NOTE: This machine uses lto with CFLAGS=-flto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing
Created attachment 793892 [details] build.log build log and emerge --info
Here is a bit of explanation: -Werror=lto-type-mismatch: User to find possible runtime issues in packages. It likely means the package is unsafe to build & use with LTO. For projects using the same identifier but with different types across different files, they must be fixed to be consistent across the codebase. -Werror=odr: Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. C++ code must comply with the One Definition Rule (ODR) - see https://en.cppreference.com/w/cpp/language/definition#One_Definition_Rule. -Werror=strict-aliasing: Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. Workarounds: - If upstream is friendly and still active, file a bug upstream. For emulators, codecs, games, or multimedia packages, it may be worth just applying a workaround instead, as upstreams sometimes aren't receptive to these bugs (VALID FOR ALL). - Use the new 'filter-lto' from flag-o-matic.eclass as it's likely to be unsafe with LTO (VALID FOR lto-type-mismatch - odr). - Fix it yourself if interested, of course (VALID FOR ALL). - Append-flags -fno-strict-aliasing (VALID FOR strict-aliasing). - Use memcpy() but a union is sometimes suitable too (VALID FOR strict-aliasing). - -fstrict-aliasing is implied by -O2, so this must be addressed in some form (VALID FOR strict-aliasing). See also: https://marc.info/?l=gentoo-dev&m=165639574126280&w=2
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f5015f1ca119bd04486ba3e7d383da0114972122 commit f5015f1ca119bd04486ba3e7d383da0114972122 Author: Eli Schwartz <eschwartz93@gmail.com> AuthorDate: 2024-03-05 04:08:01 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2024-03-05 04:47:52 +0000 media-sound/din: mark as LTO-unsafe The upstream website has a couple quirks. The open source release tarball is "Download the complete source code from Internet Archive", and there's no bug tracker or revision control. If the author uses either one, I suppose it is internal... There *is* a clearly publicized contact email, as well as e.g. requests of: > If you can package DIN Is Noise for various GNU/Linux distributions or > other Unices, please e-mail me. So my assumption is that email is the best way to report such issues. Apologies in advance for no one else being able to easily check up on the status of the bug report. ;) I have duly sent a personal email to the author with a bug report. Closes: https://bugs.gentoo.org/860513 Signed-off-by: Eli Schwartz <eschwartz93@gmail.com> Signed-off-by: Sam James <sam@gentoo.org> media-sound/din/din-58.1.ebuild | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-)
