Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 860369 - Overlay KBrown-pub removed from listings
Summary: Overlay KBrown-pub removed from listings
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Infrastructure
Classification: Unclassified
Component: Gentoo Overlays (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Overlays Project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-07-24 02:01 UTC by Sandino Araico Sanchez
Modified: 2022-07-31 20:10 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sandino Araico Sanchez 2022-07-24 02:01:21 UTC
repository KBrown-pub has been removed from https://qa-reports.gentoo.org/output/repos/repositories.xml

eselect repository list | grep KBrown-pub shows no results

repository is still present in https://github.com/gentoo/api-gentoo-org/blob/master/files/overlays/repositories.xml

I have not received any notice about repository removal or quality issues.
Comment 1 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-07-24 02:02:56 UTC
Huh. Yeah, I have no idea why you're not there. I'll see what the others can figure out.
Comment 2 John Helmert III archtester Gentoo Infrastructure gentoo-dev Security 2022-07-24 04:38:00 UTC
Seems like KBrown-pub is not unique in this. bobwya, didos, gogooverlay (new, maybe not abnormal yet), myov, progress, raw, and ros-overlay are missing from qa-reports too.
Comment 3 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2022-07-24 06:16:35 UTC
FWICS it's been blacklisted because the connection to GitLab instance was unstable and frequently caused the whole pipeline to hang.  Unfortunately, the scripts are unable to distinguish a very long running git clone (i.e. a big repo) from a process that simply hanged, so we end up blacklisting repos that cause issues like that.
Comment 4 Sandino Araico Sanchez 2022-07-24 17:07:04 UTC
gitlab running on git.softwarelibre.mx was on maintenance for a major upgrade two weeks ago. It is back online since then.

Next time there's a programmed downtime on git.softwarelibre.mx I will send a PR removing the mirror temporarily from repositories.xml file.
Comment 5 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2022-07-24 20:17:15 UTC
It has been causing regular issues in January already.  And by that, it has caused the system to hang at least two times before.
Comment 6 Sandino Araico Sanchez 2022-07-24 20:35:28 UTC
Is a 100% uptime necessary for all overlay repositories?
Is it possible to receive automated notifications when my repo is causing issues on Gentoo infrastructure?
Comment 7 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2022-07-25 04:45:13 UTC
Uptime is not a problem.  If the repo is down, the script can handle it.  The problem is when the repo is up but connection hangs in middle of cloning.  Don't ask me why it happens, don't ask me why git doesn't timeout.  It happens, it breaks everything.  I'm open to patches.
Comment 8 Sandino Araico Sanchez 2022-07-25 16:26:17 UTC
I have dealt with hung connections problems before. If you point me to the code I might figure out a small patch.
Comment 9 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2022-07-25 16:45:53 UTC
The code is literally doing 'pmaint sync KBrown-pub'.

I think the problem lies in git itself.
Comment 10 Sandino Araico Sanchez 2022-07-26 18:36:31 UTC
To prevent hanging processes from hanging the script I use the timeout command

timeout 25 pmaint sync KBrown-pub
*** syncing KBrown-pub
Cloning into '/var/db/repos/KBrown-pub'...
remote: Enumerating objects: 4351, done.
remote: Counting objects: 100% (114/114), done.
remote: Compressing objects: 100% (109/109), done.
remote: Total 4351 (delta 32), reused 0 (delta 0), pack-reused 4237
Receiving objects: 100% (4351/4351), 1.62 MiB | 1.44 MiB/s, done.
Resolving deltas: 100% (1861/1861), done.
*** synced KBrown-pub

https://linux.die.net/man/1/timeout
Comment 11 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2022-07-27 05:23:28 UTC
(In reply to Sandino Araico Sanchez from comment #10)
> To prevent hanging processes from hanging the script I use the timeout
> command

Congratulations, you've just made cloning gentoo.git impossible.
Comment 12 Sandino Araico Sanchez 2022-07-27 20:04:27 UTC
cloning gentoo.git impossible because of a too small timeout?

Only hanging overlays should need a timeout. The timeout duration can be adjusted to ensure all working overlays have enough time to complete cloning.
Comment 13 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2022-07-28 05:36:23 UTC
Sure, because we all have nothing better to do than to maintain a long list of varying timeouts because someone needs to host his own semi-broken GitLab instance.  Honestly, at this point I'm really thinking we should ban all third-party hostings except for the few most popular *that can maintain their stability*.

I was asking for a good solution, not a cheap hack that works only for you.  If you can't provide one, it ain't gonna happen.
Comment 14 Sandino Araico Sanchez 2022-07-28 05:57:11 UTC
Would Gentoo host my overlay in overlays.gentoo.org as explained in https://wiki.gentoo.org/wiki/Project:Overlays/Overlays_guide ?

I could then stop hosting on git.softwarelibre.mx and github.
Comment 15 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-07-28 06:03:36 UTC
(In reply to Sandino Araico Sanchez from comment #14)
> Would Gentoo host my overlay in overlays.gentoo.org as explained in
> https://wiki.gentoo.org/wiki/Project:Overlays/Overlays_guide ?
> 
> I could then stop hosting on git.softwarelibre.mx and github.

File a request as described on that page and ping if we forget, I guess?
Comment 16 Sandino Araico Sanchez 2022-07-28 06:30:03 UTC
This PR should be enough in the meanwhile
https://github.com/gentoo/api-gentoo-org/pull/540
Comment 17 Sandino Araico Sanchez 2022-07-29 06:42:03 UTC
In the PR I have removed the server you are complaining about (git.softwarelibre.mx).
I am mirroring the repository to gitlab.com and github.com now.
Yoy should have no more hung connections.
Comment 18 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-07-29 06:43:27 UTC
(In reply to Sandino Araico Sanchez from comment #17)
> In the PR I have removed the server you are complaining about
> (git.softwarelibre.mx).
> I am mirroring the repository to gitlab.com and github.com now.
> Yoy should have no more hung connections.

Yes, you already posted a link to the PR yesterday. Be patient I think.
Comment 19 Sandino Araico Sanchez 2022-07-29 06:47:10 UTC
No problem.
Thank you.
Comment 20 Larry the Git Cow gentoo-dev 2022-07-31 18:45:48 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/data/api.git/commit/?id=e933ce62b9cef94ccad2584d00d22bec0f078f5b

commit e933ce62b9cef94ccad2584d00d22bec0f078f5b
Author:     Sandino Araico Sanchez <sandino@sandino.net>
AuthorDate: 2022-07-28 07:18:37 +0000
Commit:     Jakov Smolić <jsmolic@gentoo.org>
CommitDate: 2022-07-31 18:44:26 +0000

    KBrown-pub: add new mirror on gitlab.com
    
    Signed-off-by: Sandino Araico Sanchez <sandino@sandino.net>
    Bug: https://bugs.gentoo.org/860369
    Closes: https://github.com/gentoo/api-gentoo-org/pull/540
    Signed-off-by: Jakov Smolić <jsmolic@gentoo.org>

 files/overlays/repositories.xml | 1 +
 1 file changed, 1 insertion(+)

https://gitweb.gentoo.org/data/api.git/commit/?id=d6507dd7129d1d53a6231a039c8ca1e23956e772

commit d6507dd7129d1d53a6231a039c8ca1e23956e772
Author:     Sandino Araico Sanchez <sandino@sandino.net>
AuthorDate: 2022-07-28 06:26:22 +0000
Commit:     Jakov Smolić <jsmolic@gentoo.org>
CommitDate: 2022-07-31 18:44:26 +0000

    KBrown-pub: remove own semi-broken GitLab instance
    
    Signed-off-by: Sandino Araico Sanchez <sandino@sandino.net>
    Bug: https://bugs.gentoo.org/860369
    Signed-off-by: Jakov Smolić <jsmolic@gentoo.org>

 files/overlays/repositories.xml | 1 -
 1 file changed, 1 deletion(-)