Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 860360 - dev-db/postgresql[-server]: missing pgbench executable
Summary: dev-db/postgresql[-server]: missing pgbench executable
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: PgSQL Bugs
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2022-07-23 21:37 UTC by Holger Hoffstätte
Modified: 2022-08-15 16:53 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch to re-add pgbench (postgresql-14-no-server-pgbench.patch,982 bytes, patch)
2022-07-23 21:38 UTC, Holger Hoffstätte
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Holger Hoffstätte 2022-07-23 21:37:05 UTC
A client-only (hence USE=-server) installation of the postgresql libs/tools installs the man page for pgbench, but not the executable. This is quite confusing, since it *is* supposed to be part of the tools and perfectly usable e.g. over the network. It seems more senible to either not install the manpage or (better) install the binary as well.


Reproducible: Always

Steps to Reproduce:
1. emerge postgresql with USE=-server
2. no pgbench executable
3. :(

Actual Results:  
No pgbench, despite the fact that the client libs by default *do* build pgbench, just not on Gentoo (see below for analysis).


Expected Results:  
Build pgbench


The reason for the missing executable is our custom "postgresql-xy-no-server" patch, in all versions. It removes a bunch of things not to be built and pgbench apparently has become collateral damage.
I re-added pgbench by editing the patch and got the executable back.
Comment 1 Holger Hoffstätte 2022-07-23 21:38:36 UTC
Created attachment 793625 [details, diff]
Patch to re-add pgbench

Example fix for postgresql-14; the same would need to be done for the other revisions.
Comment 2 Aaron W. Swenson gentoo-dev 2022-08-15 11:32:16 UTC
Thanks for catching this typo! It is indeed supposed to be a part of the -server install.
Comment 3 Larry the Git Cow gentoo-dev 2022-08-15 16:53:13 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b02edae84b979b6a303de9a9410a57bfa33386d3

commit b02edae84b979b6a303de9a9410a57bfa33386d3
Author:     Aaron W. Swenson <titanofold@gentoo.org>
AuthorDate: 2022-08-15 16:52:47 +0000
Commit:     Aaron W. Swenson <titanofold@gentoo.org>
CommitDate: 2022-08-15 16:52:47 +0000

    dev-db/postgresql: Security bump
    
    Vulnerability CVE-2022-2625 addressed by bump to:
    - 10.22
    - 11.17
    - 12.12
    - 13.8
    - 14.5
    - 15_beta3
    
    Also, pgbench is installed with -server again.
    
    Removed unused eclasses multilib and prefix.
    
    Bug: https://bugs.gentoo.org/865255
    Closes: https://bugs.gentoo.org/860360
    
    Signed-off-by: Aaron W. Swenson <titanofold@gentoo.org>

 dev-db/postgresql/Manifest                         |   6 +
 .../files/postgresql-13.8-no-server.patch          | 144 +++++++
 .../files/postgresql-14.5-no-server.patch          | 146 +++++++
 .../files/postgresql-15_beta3-no-server.patch      | 146 +++++++
 dev-db/postgresql/postgresql-10.22.ebuild          | 453 ++++++++++++++++++++
 dev-db/postgresql/postgresql-11.17.ebuild          | 453 ++++++++++++++++++++
 dev-db/postgresql/postgresql-12.12.ebuild          | 453 ++++++++++++++++++++
 dev-db/postgresql/postgresql-13.8.ebuild           | 465 +++++++++++++++++++++
 dev-db/postgresql/postgresql-14.5.ebuild           | 462 ++++++++++++++++++++
 dev-db/postgresql/postgresql-15_beta3.ebuild       | 464 ++++++++++++++++++++
 dev-db/postgresql/postgresql-9999.ebuild           |   7 +-
 11 files changed, 3195 insertions(+), 4 deletions(-)