Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 860186 - [guru] net-im/chatterino-2.3.5-r3 fails to compile (lto): FlagsEnum.hpp:42:37: error: dereferencing type-punned pointer will break strict-aliasing rules [-Werror=strict-aliasing]
Summary: [guru] net-im/chatterino-2.3.5-r3 fails to compile (lto): FlagsEnum.hpp:42:37...
Status: RESOLVED FIXED
Alias: None
Product: GURU
Classification: Unclassified
Component: Package issues (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Maria Keating
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-07-23 06:41 UTC by Agostino Sarubbo
Modified: 2024-01-09 12:03 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,156.21 KB, text/plain)
2022-07-23 06:41 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2022-07-23 06:41:27 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: net-im/chatterino-2.3.5-r3 fails to compile (lto).
Discovered on: amd64 (internal ref: guru_tinderbox)

NOTE:
This machine uses lto with CFLAGS=-flto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing
Comment 1 Agostino Sarubbo gentoo-dev 2022-07-23 06:41:29 UTC
Created attachment 793283 [details]
build.log

build log and emerge --info
Comment 2 Agostino Sarubbo gentoo-dev 2022-07-23 06:41:30 UTC
Error(s) that match a know pattern in addition to what has been reported in the summary:


--   Package 'libsecret-1', required by 'virtual:world', not found
FAILED: src/CMakeFiles/chatterino-lib.dir/Application.cpp.o 
FAILED: src/CMakeFiles/chatterino-lib.dir/common/Channel.cpp.o 
FAILED: src/CMakeFiles/chatterino-lib.dir/common/ChannelChatters.cpp.o 
/var/tmp/portage/net-im/chatterino-2.3.5-r3/work/chatterino2-2.3.5/src/common/FlagsEnum.hpp:42:37: error: dereferencing type-punned pointer will break strict-aliasing rules [-Werror=strict-aliasing]
Comment 3 Agostino Sarubbo gentoo-dev 2022-07-26 09:08:56 UTC
Here is a bit of explanation:

-Werror=lto-type-mismatch:
User to find possible runtime issues in packages. It likely means the package is unsafe to build & use with LTO.
For projects using the same identifier but with different types across different files, they must be fixed to be consistent across the codebase.

-Werror=odr:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. C++ code must comply with the One Definition Rule (ODR) - see https://en.cppreference.com/w/cpp/language/definition#One_Definition_Rule.

-Werror=strict-aliasing:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO.

Workarounds:
- If upstream is friendly and still active, file a bug upstream. For emulators, codecs, games, or multimedia packages, it may be worth just applying a workaround instead, as upstreams sometimes aren't receptive to these bugs (VALID FOR ALL).
- Use the new 'filter-lto' from flag-o-matic.eclass as it's likely to be unsafe with LTO (VALID FOR lto-type-mismatch - odr).
- Fix it yourself if interested, of course (VALID FOR ALL).
- Append-flags -fno-strict-aliasing (VALID FOR strict-aliasing).
- Use memcpy() but a union is sometimes suitable too (VALID FOR strict-aliasing).
- -fstrict-aliasing is implied by -O2, so this must be addressed in some form (VALID FOR strict-aliasing).

See also: https://marc.info/?l=gentoo-dev&m=165639574126280&w=2
Comment 4 Larry the Git Cow gentoo-dev 2024-01-09 12:03:30 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/proj/guru.git/commit/?id=ff99ad982bbbcc5fa2aac8241403538c14b6775c

commit ff99ad982bbbcc5fa2aac8241403538c14b6775c
Author:     Takuya Wakazono <pastalian46@gmail.com>
AuthorDate: 2024-01-08 09:12:09 +0000
Commit:     Takuya Wakazono <pastalian46@gmail.com>
CommitDate: 2024-01-08 09:12:09 +0000

    net-im/chatterino: add 2.4.6
    
    Closes: https://bugs.gentoo.org/860186
    Closes: https://bugs.gentoo.org/908400
    Closes: https://bugs.gentoo.org/917398
    Signed-off-by: Takuya Wakazono <pastalian46@gmail.com>

 net-im/chatterino/Manifest                |  9 ++++
 net-im/chatterino/chatterino-2.4.6.ebuild | 80 +++++++++++++++++++++++++++++++
 2 files changed, 89 insertions(+)