Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 860165 - [guru] media-libs/amdvlk-2020.4.6 fails to compile (lto): cwpack.c:158:22: error: dereferencing type-punned pointer will break strict-aliasing rules [-Werror=strict-aliasing]
Summary: [guru] media-libs/amdvlk-2020.4.6 fails to compile (lto): cwpack.c:158:22: er...
Status: RESOLVED FIXED
Alias: None
Product: GURU
Classification: Unclassified
Component: Package issues (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Reva Denis
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-07-23 06:29 UTC by Agostino Sarubbo
Modified: 2022-12-14 16:46 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,68.89 KB, text/plain)
2022-07-23 06:29 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2022-07-23 06:29:52 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: media-libs/amdvlk-2020.4.6 fails to compile (lto).
Discovered on: amd64 (internal ref: guru_tinderbox)

NOTE:
This machine uses lto with CFLAGS=-flto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing
Comment 1 Agostino Sarubbo gentoo-dev 2022-07-23 06:29:54 UTC
Created attachment 793262 [details]
build.log

build log and emerge --info
Comment 2 Agostino Sarubbo gentoo-dev 2022-07-23 06:29:55 UTC
Error(s) that match a know pattern in addition to what has been reported in the summary:


-- Could NOT find OCaml (missing: OCAMLFIND OCAML_VERSION OCAML_STDLIB_PATH) 
-- Could NOT find Python module pygments
-- Could NOT find Python module pygments.lexers.c_cpp
-- Could NOT find Python module yaml
/var/tmp/portage/media-libs/amdvlk-2020.4.6/work/third_party/cwpack/src/cwpack.c:158:22: error: dereferencing type-punned pointer will break strict-aliasing rules [-Werror=strict-aliasing]
Comment 3 Agostino Sarubbo gentoo-dev 2022-07-26 09:08:54 UTC
Here is a bit of explanation:

-Werror=lto-type-mismatch:
User to find possible runtime issues in packages. It likely means the package is unsafe to build & use with LTO.
For projects using the same identifier but with different types across different files, they must be fixed to be consistent across the codebase.

-Werror=odr:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. C++ code must comply with the One Definition Rule (ODR) - see https://en.cppreference.com/w/cpp/language/definition#One_Definition_Rule.

-Werror=strict-aliasing:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO.

Workarounds:
- If upstream is friendly and still active, file a bug upstream. For emulators, codecs, games, or multimedia packages, it may be worth just applying a workaround instead, as upstreams sometimes aren't receptive to these bugs (VALID FOR ALL).
- Use the new 'filter-lto' from flag-o-matic.eclass as it's likely to be unsafe with LTO (VALID FOR lto-type-mismatch - odr).
- Fix it yourself if interested, of course (VALID FOR ALL).
- Append-flags -fno-strict-aliasing (VALID FOR strict-aliasing).
- Use memcpy() but a union is sometimes suitable too (VALID FOR strict-aliasing).
- -fstrict-aliasing is implied by -O2, so this must be addressed in some form (VALID FOR strict-aliasing).

See also: https://marc.info/?l=gentoo-dev&m=165639574126280&w=2
Comment 4 Reva Denis 2022-09-18 19:21:16 UTC
It's not wonder. I stopped maintaining that package two years ago because of crisis in my life. Might be I'll return.
Comment 5 Larry the Git Cow gentoo-dev 2022-12-14 16:46:05 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/proj/guru.git/commit/?id=c0c680d324fea62c1dae0774d24c322bcfc3057e

commit c0c680d324fea62c1dae0774d24c322bcfc3057e
Author:     Denis Reva <denis7774@gmail.com>
AuthorDate: 2022-12-10 06:47:48 +0000
Commit:     Denis Reva <denis7774@gmail.com>
CommitDate: 2022-12-10 06:48:08 +0000

    media-libs/amdvlk: Updated amdvlk to 2022.4.3, added use flag for raytracing support, updated metadata.xml
    
    Bug: https://bugs.gentoo.org/665590
    Closes: https://bugs.gentoo.org/860165
    Signed-off-by: Denis Reva <denis7774@gmail.com>

 media-libs/amdvlk/Manifest               |   5 ++
 media-libs/amdvlk/amdvlk-2022.4.3.ebuild | 124 +++++++++++++++++++++++++++++++
 media-libs/amdvlk/metadata.xml           |   8 +-
 3 files changed, 136 insertions(+), 1 deletion(-)