Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 860117 - media-libs/zmusic-1.1.4 fails to compile (lto): nukedopl3_174.h:59:8: error: type struct _opl3_slot violates the C++ One Definition Rule [-Werror=odr]
Summary: media-libs/zmusic-1.1.4 fails to compile (lto): nukedopl3_174.h:59:8: error: ...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Games
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: lto
  Show dependency tree
 
Reported: 2022-07-22 15:22 UTC by Agostino Sarubbo
Modified: 2024-03-18 05:31 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,326.82 KB, text/plain)
2022-07-22 15:22 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2022-07-22 15:22:45 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: media-libs/zmusic-1.1.4 fails to compile (lto).
Discovered on: amd64 (internal ref: lto_tinderbox)

NOTE:
This machine uses lto with CFLAGS=-flto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing
Comment 1 Agostino Sarubbo gentoo-dev 2022-07-22 15:22:48 UTC
Created attachment 793220 [details]
build.log

build log and emerge --info
Comment 2 Agostino Sarubbo gentoo-dev 2022-07-22 15:22:50 UTC
Error(s) that match a know pattern in addition to what has been reported in the summary:


FAILED: source/libzmusic.so.1.1.0 
/var/tmp/portage/media-libs/zmusic-1.1.4/work/ZMusic-1.1.4/thirdparty/adlmidi/chips/nuked/nukedopl3_174.h:59:8: error: type ‘struct _opl3_slot’ violates the C++ One Definition Rule [-Werror=odr]
Comment 3 Agostino Sarubbo gentoo-dev 2022-07-26 09:02:37 UTC
Here is a bit of explanation:

-Werror=lto-type-mismatch:
User to find possible runtime issues in packages. It likely means the package is unsafe to build & use with LTO.
For projects using the same identifier but with different types across different files, they must be fixed to be consistent across the codebase.

-Werror=odr:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. C++ code must comply with the One Definition Rule (ODR) - see https://en.cppreference.com/w/cpp/language/definition#One_Definition_Rule.

-Werror=strict-aliasing:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO.

Workarounds:
- If upstream is friendly and still active, file a bug upstream. For emulators, codecs, games, or multimedia packages, it may be worth just applying a workaround instead, as upstreams sometimes aren't receptive to these bugs (VALID FOR ALL).
- Use the new 'filter-lto' from flag-o-matic.eclass as it's likely to be unsafe with LTO (VALID FOR lto-type-mismatch - odr).
- Fix it yourself if interested, of course (VALID FOR ALL).
- Append-flags -fno-strict-aliasing (VALID FOR strict-aliasing).
- Use memcpy() but a union is sometimes suitable too (VALID FOR strict-aliasing).
- -fstrict-aliasing is implied by -O2, so this must be addressed in some form (VALID FOR strict-aliasing).

See also: https://marc.info/?l=gentoo-dev&m=165639574126280&w=2
Comment 4 Eli Schwartz 2024-03-17 18:05:07 UTC
This actually comes from the vendored libadlmidi library, which should be unbundled...

https://github.com/Wohlstand/libADLMIDI/
Comment 5 Larry the Git Cow gentoo-dev 2024-03-18 05:31:27 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0ebc968dfade4f0e0af7e47ad49c9b4f5cc67d3d

commit 0ebc968dfade4f0e0af7e47ad49c9b4f5cc67d3d
Author:     Eli Schwartz <eschwartz93@gmail.com>
AuthorDate: 2024-03-17 18:05:30 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-03-18 05:29:45 +0000

    media-libs/zmusic: mark as LTO-unsafe
    
    It's not actually LTO unsafe. Its bundled adlmidi dependency is.
    Unfortunately, this package uses bundled dependencies and it's only
    gotten worse in later upstream releases.
    
    Issue still present in upstream git and in the libadlmidi source as
    well.
    
    Not currently up to figuring out how to patch the heck out of this to
    devendor it, given upstream doesn't provide options for it.
    
    Bug: https://github.com/ZDoom/ZMusic/issues/56
    Closes: https://bugs.gentoo.org/860117
    Signed-off-by: Eli Schwartz <eschwartz93@gmail.com>
    Signed-off-by: Sam James <sam@gentoo.org>

 media-libs/zmusic/zmusic-1.1.4.ebuild | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)