https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/ Issue: media-libs/libfpx-1.3.1_p10 fails to compile (lto). Discovered on: amd64 (internal ref: lto_tinderbox) NOTE: This machine uses lto with CFLAGS=-flto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing
Created attachment 793001 [details] build.log build log and emerge --info
Here is a bit of explanation: -Werror=lto-type-mismatch: User to find possible runtime issues in packages. It likely means the package is unsafe to build & use with LTO. For projects using the same identifier but with different types across different files, they must be fixed to be consistent across the codebase. -Werror=odr: Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. C++ code must comply with the One Definition Rule (ODR) - see https://en.cppreference.com/w/cpp/language/definition#One_Definition_Rule. -Werror=strict-aliasing: Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. Workarounds: - If upstream is friendly and still active, file a bug upstream. For emulators, codecs, games, or multimedia packages, it may be worth just applying a workaround instead, as upstreams sometimes aren't receptive to these bugs (VALID FOR ALL). - Use the new 'filter-lto' from flag-o-matic.eclass as it's likely to be unsafe with LTO (VALID FOR lto-type-mismatch - odr). - Fix it yourself if interested, of course (VALID FOR ALL). - Append-flags -fno-strict-aliasing (VALID FOR strict-aliasing). - Use memcpy() but a union is sometimes suitable too (VALID FOR strict-aliasing). - -fstrict-aliasing is implied by -O2, so this must be addressed in some form (VALID FOR strict-aliasing). See also: https://marc.info/?l=gentoo-dev&m=165639574126280&w=2
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1ebd8326257a79006c4517d93f3a07eadd000834 commit 1ebd8326257a79006c4517d93f3a07eadd000834 Author: Eli Schwartz <eschwartz93@gmail.com> AuthorDate: 2024-03-13 19:26:45 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2024-03-13 21:04:08 +0000 media-libs/libfpx: mark as LTO-unsafe, strict-aliasing unsafe Closes: https://bugs.gentoo.org/859913 Signed-off-by: Eli Schwartz <eschwartz93@gmail.com> Signed-off-by: Sam James <sam@gentoo.org> media-libs/libfpx/libfpx-1.3.1_p10.ebuild | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-)
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=247bd57530051e238456c86dc082411a65743d9b commit 247bd57530051e238456c86dc082411a65743d9b Author: Sam James <sam@gentoo.org> AuthorDate: 2024-04-19 10:44:01 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2024-04-19 10:45:31 +0000 media-libs/libfpx: restore LTO workarounds The PR hadn't been rebased so it lost the changes from 1ebd8326257a79006c4517d93f3a07eadd000834. Bug: https://bugs.gentoo.org/847412 Bug: https://bugs.gentoo.org/859913 Fixes: a357ebd8c860107ac82c3600114b899b9df27f4b Signed-off-by: Sam James <sam@gentoo.org> media-libs/libfpx/libfpx-1.3.1_p10-r1.ebuild | 8 ++++++++ 1 file changed, 8 insertions(+)
