https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/ Issue: media-libs/embree-3.13.3 fails to compile (lto). Discovered on: amd64 (internal ref: lto_tinderbox) NOTE: This machine uses lto with CFLAGS=-flto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing
Created attachment 792929 [details] build.log build log and emerge --info
Error(s) that match a know pattern in addition to what has been reported in the summary: FAILED: libembree3.so.3.13.3 /var/tmp/portage/media-libs/embree-3.13.3/work/embree-3.13.3/kernels/common/../../common/sys/../math/../simd/varying.h:12:10: error: type ‘struct vfloat_impl’ violates the C++ One Definition Rule [-Werror=odr]
Here is a bit of explanation: -Werror=lto-type-mismatch: User to find possible runtime issues in packages. It likely means the package is unsafe to build & use with LTO. For projects using the same identifier but with different types across different files, they must be fixed to be consistent across the codebase. -Werror=odr: Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. C++ code must comply with the One Definition Rule (ODR) - see https://en.cppreference.com/w/cpp/language/definition#One_Definition_Rule. -Werror=strict-aliasing: Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. Workarounds: - If upstream is friendly and still active, file a bug upstream. For emulators, codecs, games, or multimedia packages, it may be worth just applying a workaround instead, as upstreams sometimes aren't receptive to these bugs (VALID FOR ALL). - Use the new 'filter-lto' from flag-o-matic.eclass as it's likely to be unsafe with LTO (VALID FOR lto-type-mismatch - odr). - Fix it yourself if interested, of course (VALID FOR ALL). - Append-flags -fno-strict-aliasing (VALID FOR strict-aliasing). - Use memcpy() but a union is sometimes suitable too (VALID FOR strict-aliasing). - -fstrict-aliasing is implied by -O2, so this must be addressed in some form (VALID FOR strict-aliasing). See also: https://marc.info/?l=gentoo-dev&m=165639574126280&w=2
lto_tinderbox has reproduced this issue with version 3.13.4 - Updating summary.
lto_tinderbox has reproduced this issue with version 3.13.5 - Updating summary.
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6523ef2c99db1ba28395f2d6b8ca8e8f46564f53 commit 6523ef2c99db1ba28395f2d6b8ca8e8f46564f53 Author: Eli Schwartz <eschwartz93@gmail.com> AuthorDate: 2024-03-26 04:41:01 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2024-03-26 12:27:32 +0000 media-libs/embree: mark as LTO-unsafe Closes: https://bugs.gentoo.org/859838 Signed-off-by: Eli Schwartz <eschwartz93@gmail.com> Signed-off-by: Sam James <sam@gentoo.org> media-libs/embree/embree-3.13.4.ebuild | 7 ++++++- media-libs/embree/embree-3.13.5.ebuild | 7 ++++++- media-libs/embree/embree-4.3.0.ebuild | 5 +++++ 3 files changed, 17 insertions(+), 2 deletions(-)
