Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 859823 - media-gfx/xv-3.10a-r22 fails to compile (lto): xv.h:1258:21: error: type of [-Werror=lto-type-mismatch]
Summary: media-gfx/xv-3.10a-r22 fails to compile (lto): xv.h:1258:21: error: type of [...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Ben Kohler
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: lto
  Show dependency tree
 
Reported: 2022-07-21 19:56 UTC by Agostino Sarubbo
Modified: 2024-08-12 04:22 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,78.87 KB, text/plain)
2022-07-21 19:56 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2022-07-21 19:56:40 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: media-gfx/xv-3.10a-r19 fails to compile (lto).
Discovered on: amd64 (internal ref: lto_tinderbox)

NOTE:
This machine uses lto with CFLAGS=-flto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing
Comment 1 Agostino Sarubbo gentoo-dev 2022-07-21 19:56:42 UTC
Created attachment 792914 [details]
build.log

build log and emerge --info
Comment 2 Agostino Sarubbo gentoo-dev 2022-07-26 09:02:17 UTC
Here is a bit of explanation:

-Werror=lto-type-mismatch:
User to find possible runtime issues in packages. It likely means the package is unsafe to build & use with LTO.
For projects using the same identifier but with different types across different files, they must be fixed to be consistent across the codebase.

-Werror=odr:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. C++ code must comply with the One Definition Rule (ODR) - see https://en.cppreference.com/w/cpp/language/definition#One_Definition_Rule.

-Werror=strict-aliasing:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO.

Workarounds:
- If upstream is friendly and still active, file a bug upstream. For emulators, codecs, games, or multimedia packages, it may be worth just applying a workaround instead, as upstreams sometimes aren't receptive to these bugs (VALID FOR ALL).
- Use the new 'filter-lto' from flag-o-matic.eclass as it's likely to be unsafe with LTO (VALID FOR lto-type-mismatch - odr).
- Fix it yourself if interested, of course (VALID FOR ALL).
- Append-flags -fno-strict-aliasing (VALID FOR strict-aliasing).
- Use memcpy() but a union is sometimes suitable too (VALID FOR strict-aliasing).
- -fstrict-aliasing is implied by -O2, so this must be addressed in some form (VALID FOR strict-aliasing).

See also: https://marc.info/?l=gentoo-dev&m=165639574126280&w=2
Comment 3 Agostino Sarubbo gentoo-dev 2022-10-06 08:48:15 UTC
lto_tinderbox has reproduced this issue with version 3.10a-r20 - Updating summary.
Comment 4 Agostino Sarubbo gentoo-dev 2024-03-12 08:19:28 UTC
lto_tinderbox has reproduced this issue with version 3.10a-r22 - Updating summary.
Comment 5 Larry the Git Cow gentoo-dev 2024-08-12 04:22:35 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e17e4d8bffe19eb873f7d823b19aeb4c1d1455f2

commit e17e4d8bffe19eb873f7d823b19aeb4c1d1455f2
Author:     Eli Schwartz <eschwartz@gentoo.org>
AuthorDate: 2024-08-12 04:20:26 +0000
Commit:     Eli Schwartz <eschwartz@gentoo.org>
CommitDate: 2024-08-12 04:20:58 +0000

    media-gfx/xv: mark as LTO-unsafe
    
    Closes: https://bugs.gentoo.org/859823
    Signed-off-by: Eli Schwartz <eschwartz@gentoo.org>

 media-gfx/xv/xv-3.10a-r22.ebuild | 5 +++++
 media-gfx/xv/xv-5.2.0.ebuild     | 7 ++++++-
 2 files changed, 11 insertions(+), 1 deletion(-)