Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 859778 - media-gfx/opentoonz-1.4.0 fails to compile (lto): trandom.cpp:53:9: error: dereferencing type-punned pointer will break strict-aliasing rules [-Werror=strict-aliasing]
Summary: media-gfx/opentoonz-1.4.0 fails to compile (lto): trandom.cpp:53:9: error: de...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: otakuto.gentoo
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: lto
  Show dependency tree
 
Reported: 2022-07-21 12:35 UTC by Agostino Sarubbo
Modified: 2023-02-04 23:05 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,356.64 KB, text/plain)
2022-07-21 12:35 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2022-07-21 12:35:21 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: media-gfx/opentoonz-1.4.0 fails to compile (lto).
Discovered on: amd64 (internal ref: lto_tinderbox)

NOTE:
This machine uses lto with CFLAGS=-flto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing
Comment 1 Agostino Sarubbo gentoo-dev 2022-07-21 12:35:24 UTC
Created attachment 792857 [details]
build.log

build log and emerge --info
Comment 2 Agostino Sarubbo gentoo-dev 2022-07-26 09:02:16 UTC
Here is a bit of explanation:

-Werror=lto-type-mismatch:
User to find possible runtime issues in packages. It likely means the package is unsafe to build & use with LTO.
For projects using the same identifier but with different types across different files, they must be fixed to be consistent across the codebase.

-Werror=odr:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. C++ code must comply with the One Definition Rule (ODR) - see https://en.cppreference.com/w/cpp/language/definition#One_Definition_Rule.

-Werror=strict-aliasing:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO.

Workarounds:
- If upstream is friendly and still active, file a bug upstream. For emulators, codecs, games, or multimedia packages, it may be worth just applying a workaround instead, as upstreams sometimes aren't receptive to these bugs (VALID FOR ALL).
- Use the new 'filter-lto' from flag-o-matic.eclass as it's likely to be unsafe with LTO (VALID FOR lto-type-mismatch - odr).
- Fix it yourself if interested, of course (VALID FOR ALL).
- Append-flags -fno-strict-aliasing (VALID FOR strict-aliasing).
- Use memcpy() but a union is sometimes suitable too (VALID FOR strict-aliasing).
- -fstrict-aliasing is implied by -O2, so this must be addressed in some form (VALID FOR strict-aliasing).

See also: https://marc.info/?l=gentoo-dev&m=165639574126280&w=2
Comment 3 Larry the Git Cow gentoo-dev 2023-02-04 23:05:08 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c76dcdc1473e62b98674e297b177d96ebc80e3f6

commit c76dcdc1473e62b98674e297b177d96ebc80e3f6
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2023-02-04 23:02:14 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-02-04 23:04:35 +0000

    media-gfx/opentoonz: add 1.6.0
    
    Closes: https://bugs.gentoo.org/830892
    Closes: https://bugs.gentoo.org/859778
    Signed-off-by: Sam James <sam@gentoo.org>

 media-gfx/opentoonz/Manifest               |  1 +
 media-gfx/opentoonz/opentoonz-1.6.0.ebuild | 90 ++++++++++++++++++++++++++++++
 2 files changed, 91 insertions(+)