Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 859544 - kde-apps/kdenetwork-meta please rename webengine use flag to something sane
Summary: kde-apps/kdenetwork-meta please rename webengine use flag to something sane
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo KDE team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-07-20 14:18 UTC by kavol
Modified: 2022-07-30 08:38 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description kavol 2022-07-20 14:18:21 UTC
On todays updates, I have found that depclean wants to remove the whole Plasma Telepathy.
I thought this is part of kdenetwork, but I had no clue why it doesn't pull it anymore.
Only after examining the ebuild source, I have found that this dependency is controlled by the "webengine" use flag, not something like "ktp" or "telepathy"  that I would expect ...

Now this is totally counterintuitive, the point of the USE flags is to define which functionality the user wants and then the ebuild pulls the required dependencies and not the vice versa, that the user would say which dependency to use and then the ebuild would provide, maybe, the wanted functionality.

Plus this creates mess in the use flags as "webengine" is used by many packages[*], so the user has to define it per-package instead of globally, as enabling it because of Telepathy would lead to pulling in some totally unrelated things like some Nextcloud integration ...

[*] Many of them probably candidates for the same kind of change as I am proposing here ...

Reproducible: Always
Comment 1 Andreas Sturmlechner gentoo-dev 2022-07-20 15:05:18 UTC
"Yes, but": People want easy global switches for dev-qt/qtwebengine revdeps, and Plasma Telepathy fundamentally is one. This flag was used since 2020, and now its default changed to reflect the fundamentally unmaintained and "broken by default" state it is even according to upstream.
Comment 2 Andreas Sturmlechner gentoo-dev 2022-07-20 15:13:06 UTC
An alternative I have thought about is moving plasma-telepathy-meta out of kdenetwork, into kde-apps-meta, hidden behind a new default disabled IUSE=telepathy flag.

In addition, I will likely exclude it from future KDE Gear version bumps.
Comment 3 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-07-20 15:41:17 UTC
(In reply to Andreas Sturmlechner from comment #1)
> "Yes, but": People want easy global switches for dev-qt/qtwebengine revdeps,
> and Plasma Telepathy fundamentally is one. This flag was used since 2020,
> and now its default changed to reflect the fundamentally unmaintained and
> "broken by default" state it is even according to upstream.

Agreed. In principle, I like using USE flags for features, but people want a way to disable qtwebengine easily.
Comment 4 Larry the Git Cow gentoo-dev 2022-07-21 10:23:41 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/kde.git/commit/?id=1613a8504d2ccaff9df3916b07ef8988b9353f92

commit 1613a8504d2ccaff9df3916b07ef8988b9353f92
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2022-07-21 10:10:30 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2022-07-21 10:19:30 +0000

    kde-apps/kdenetwork-meta: Update IUSE webengine, re-add IUSE telepathy
    
    - Switch back IUSE webengine->telepathy
      - With the flag by default disabled we can allow it to diverge from our
        IUSE=webengine revdep "rule", similar to kde-apps-meta[pim].
      - Also, stop enforcing a minimum ${PV} for plasma-telepathy-meta in
        anticipation of us stopping to package future zombie releases of it
        altogether.
    
    - Move kde-misc/kio-gdrive behind IUSE +webengine
      Due to the package dropping its IUSE=kaccounts option we can now move
      it behind the established anti-qtwebengine flag.
    
    Bug: https://bugs.gentoo.org/782505
    Bug: https://bugs.gentoo.org/859544
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 kde-apps/kdenetwork-meta/kdenetwork-meta-22.07.80.ebuild      | 6 +++---
 kde-apps/kdenetwork-meta/kdenetwork-meta-22.08.49.9999.ebuild | 6 +++---
 kde-apps/kdenetwork-meta/kdenetwork-meta-9999.ebuild          | 6 +++---
 kde-apps/kdenetwork-meta/metadata.xml                         | 3 ++-
 4 files changed, 11 insertions(+), 10 deletions(-)
Comment 5 Larry the Git Cow gentoo-dev 2022-07-21 10:35:37 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1c7d07f251d178f8eb288843ef69437732f1cb30

commit 1c7d07f251d178f8eb288843ef69437732f1cb30
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2022-07-21 10:10:30 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2022-07-21 10:34:32 +0000

    kde-apps/kdenetwork-meta: Update IUSE webengine, re-add IUSE telepathy
    
    - Switch back IUSE webengine->telepathy
      - With the flag by default disabled we can allow it to diverge from our
        IUSE=webengine revdep "rule", similar to kde-apps-meta[pim].
      - Also, stop enforcing a minimum ${PV} for plasma-telepathy-meta in
        anticipation of us stopping to package future zombie releases of it
        altogether.
    
    - Move kde-misc/kio-gdrive behind IUSE +webengine
      Due to the package dropping its IUSE=kaccounts option we can now move
      it behind the established anti-qtwebengine flag.
    
    Closes: https://bugs.gentoo.org/782505
    Closes: https://bugs.gentoo.org/859544
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 ...ork-meta-22.04.3-r1.ebuild => kdenetwork-meta-22.04.3-r2.ebuild} | 6 +++---
 kde-apps/kdenetwork-meta/metadata.xml                               | 3 ++-
 2 files changed, 5 insertions(+), 4 deletions(-)
Comment 6 kavol 2022-07-30 08:38:00 UTC
well, I don't get the "disable qtwebengine easily" part ... the fact that various things are provided by a single package doesn't mean that I'd want to disable/enable all those things (often very distinct) at once - and if I want to get rid of that package, it is easy to spot which thing pulls it, rather than the reverse, to figure out what things across many packages are controlled by that single package (ok, depending on how well the use flag is documented when I issue euse -i ...)

anyways, thanks for fixing

yeah, ktp "doesn't seem any deader than usual to me" :-)