https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/ Issue: games-sports/speed-dreams-2.2.3 fails to compile (lto). Discovered on: amd64 (internal ref: lto_tinderbox) NOTE: This machine uses lto with CFLAGS=-flto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing
Created attachment 792254 [details] build.log build log and emerge --info
Error(s) that match a know pattern in addition to what has been reported in the summary: -- Package 'FreeSOLID', required by 'virtual:world', not found -- Package 'SOLID', required by 'virtual:world', not found FAILED: usr/bin/sd2-trackgen /var/tmp/portage/games-sports/speed-dreams-2.2.3/work/src/tools/trackgen/easymesh.cpp:138:8: error: type ‘struct group’ violates the C++ One Definition Rule [-Werror=odr]
Here is a bit of explanation: -Werror=lto-type-mismatch: User to find possible runtime issues in packages. It likely means the package is unsafe to build & use with LTO. For projects using the same identifier but with different types across different files, they must be fixed to be consistent across the codebase. -Werror=odr: Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. C++ code must comply with the One Definition Rule (ODR) - see https://en.cppreference.com/w/cpp/language/definition#One_Definition_Rule. -Werror=strict-aliasing: Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. Workarounds: - If upstream is friendly and still active, file a bug upstream. For emulators, codecs, games, or multimedia packages, it may be worth just applying a workaround instead, as upstreams sometimes aren't receptive to these bugs (VALID FOR ALL). - Use the new 'filter-lto' from flag-o-matic.eclass as it's likely to be unsafe with LTO (VALID FOR lto-type-mismatch - odr). - Fix it yourself if interested, of course (VALID FOR ALL). - Append-flags -fno-strict-aliasing (VALID FOR strict-aliasing). - Use memcpy() but a union is sometimes suitable too (VALID FOR strict-aliasing). - -fstrict-aliasing is implied by -O2, so this must be addressed in some form (VALID FOR strict-aliasing). See also: https://marc.info/?l=gentoo-dev&m=165639574126280&w=2
ODR issue is no longer present when compiling the upstream 2.3.0 release.
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b6c6e637803a51f09fb8f4a07f672b04b4976fae commit b6c6e637803a51f09fb8f4a07f672b04b4976fae Author: Eli Schwartz <eschwartz93@gmail.com> AuthorDate: 2024-03-25 23:17:19 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2024-03-26 12:27:25 +0000 games-sports/speed-dreams: add 2.3.0 Fixes LTO. Due to upstream rework, curl is now used twice, once unconditionally, and there is another new dependency as well. Closes: https://bugs.gentoo.org/859238 Signed-off-by: Eli Schwartz <eschwartz93@gmail.com> Signed-off-by: Sam James <sam@gentoo.org> games-sports/speed-dreams/Manifest | 4 + .../speed-dreams/speed-dreams-2.3.0.ebuild | 85 ++++++++++++++++++++++ 2 files changed, 89 insertions(+)
