Thanks to Hu at https://forums.gentoo.org/viewtopic-p-8727701.html for doing the in depth research on gvim's website, apparently gvim has suddenly dropped nextaw and athena toolkit support due to validation errors they caught. Probably should reflect this in our ebuild and ensure people do not try to build gvim without gtk or motif support. I tested motif support and it gave a warning but otherwise appears to be functional. I do not know anything about aqua/carbon. Reproducible: Always Steps to Reproduce: 1. Build gvim with USE=-aqua -gtk -gtk2 -motif 2. Run resultant gvim binary 3. Actual Results: gvim will no longer start with the GUI and dump an error on the terminal: E25: GUI cannot be used: Not enabled at compile time Expected Results: gvim should bring up a GUI window
As I don't think we can add support back, the proposal is to rewrite the ebuild logic to ensure a supported USE combination is enforced so that users don't build a binary that's nonfunctional. Perhaps make one of gtk or motif as default, but error out if none of the supported toolkits are specified.
(In reply to Ben from comment #1) > As I don't think we can add support back, the proposal is to rewrite the > ebuild logic to ensure a supported USE combination is enforced so that users > don't build a binary that's nonfunctional. @Ben, thanks for reporting. > Perhaps make one of gtk or motif as default, but error out if none of the > supported toolkits are specified. I think for now we'll just have to drop neXt and athena as options, and pick one as the default? I would maybe lean towards gtk.
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=7dea592a9f4b5d2d06f26391dd8a62f7c9428215 commit 7dea592a9f4b5d2d06f26391dd8a62f7c9428215 Author: Thomas Bracht Laumann Jespersen <t@laumann.xyz> AuthorDate: 2022-07-21 21:15:32 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2022-07-26 20:34:57 +0000 app-editors/gvim: drop gtk2, nextaw, athena GUIs The Athena GUI was reported as not working in version 8.2.4514 Support for Athena GUI was removed in 9.0.0057. Drop the neXt use flag as well and the gtk2 flag as gtk+2 is EOL. Also drop the gtk use flag, and make the gtk GUI the default while still supporting aqua and motif. This only drops them from the live ebuild. See: https://github.com/vim/vim/issues/9894#issuecomment-1060673495 See: https://github.com/vim/vim/commit/0b40d086b337f14fdd0dbc035988ffb0aec8ce5f Bug: https://bugs.gentoo.org/858830 Bug: https://bugs.gentoo.org/831250 Signed-off-by: Thomas Bracht Laumann Jespersen <t@laumann.xyz> Closes: https://github.com/gentoo/gentoo/pull/26512 Signed-off-by: Sam James <sam@gentoo.org> app-editors/gvim/gvim-9999.ebuild | 43 ++++++++------------------------------- 1 file changed, 8 insertions(+), 35 deletions(-)
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e104aed53c7457e75370904e3d7d9b793239a375 commit e104aed53c7457e75370904e3d7d9b793239a375 Author: Eli Schwartz <eschwartz@gentoo.org> AuthorDate: 2024-08-28 02:51:49 +0000 Commit: Eli Schwartz <eschwartz@gentoo.org> CommitDate: 2024-08-28 04:33:18 +0000 app-editors/gvim: delete untested code for USE=aqua It was removed from vim upstream, 4 years ago in version 8.2.1422 via commit: https://github.com/vim/vim/commit/097148e849136b49052b1b5123c714fb1d74db9b The rationale was that it was "outdated" and "probably doesn't even work" -- sounds like they didn't know either. Their recommendation is that MacVim provides a gui version if you want one, and I guess vim just isn't gonna keep maintaining one??? Clearly no macOS users of Gentoo Prefix have tried enabling aqua for a very long time. This code logic is completely dead weight. This was noted as "I do not know" in a bug report about other toolkits that were dropped after aqua was ;) but nothing was done at the time... Bug: https://bugs.gentoo.org/858830 Signed-off-by: Eli Schwartz <eschwartz@gentoo.org> app-editors/gvim/gvim-9.0.2167.ebuild | 23 +++++++---------------- app-editors/gvim/gvim-9.1.0366.ebuild | 23 +++++++---------------- app-editors/gvim/gvim-9.1.0470.ebuild | 23 +++++++---------------- app-editors/gvim/gvim-9999.ebuild | 23 +++++++---------------- 4 files changed, 28 insertions(+), 64 deletions(-)
The only remaining toolkits in *any* gvim ebuild in tree, are motif or the default gtk3. And with that, we are done (more done than the original report).
