Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 858818 - estrip: fix double prefix
Summary: estrip: fix double prefix
Status: RESOLVED FIXED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Core (show other bugs)
Hardware: All Linux
: Normal major (vote)
Assignee: Portage team
URL:
Whiteboard:
Keywords: InVCS, PATCH
Depends on:
Blocks: 858824
  Show dependency tree
 
Reported: 2022-07-18 15:09 UTC by Benda Xu
Modified: 2022-07-18 23:06 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
estrip-double-prefix.patch (estrip-double-prefix.patch,758 bytes, patch)
2022-07-18 15:10 UTC, Benda Xu
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Benda Xu gentoo-dev 2022-07-18 15:09:36 UTC
This only happens in prestrip phase for EAPI=6 and older ebuilds.

The content of build-info/NEEDED is with EPREFIX, the following sed
should only prepend the paths with D.

See the patch attached.

Reproducible: Always
Comment 1 Benda Xu gentoo-dev 2022-07-18 15:10:26 UTC
Created attachment 792170 [details, diff]
estrip-double-prefix.patch
Comment 2 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-07-18 15:12:54 UTC
Nit, but git author doesn't match sign off.
Comment 3 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-07-18 15:13:36 UTC
Thanks, I'll apply now!
Comment 4 Larry the Git Cow gentoo-dev 2022-07-18 15:16:51 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/portage.git/commit/?id=095d8c5b040eb399c245db1d3923d6a85747bbcf

commit 095d8c5b040eb399c245db1d3923d6a85747bbcf
Author:     Benda Xu <heroxbd@gentoo.org>
AuthorDate: 2022-07-18 15:04:02 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-07-18 15:16:46 +0000

    estrip: fix double prefix
    
    The content of build-info/NEEDED is with EPREFIX, the following sed
    should only prepend the paths with D.
    
    Bug: https://bugs.gentoo.org/749624
    Bug: https://bugs.gentoo.org/858818
    Reference: https://github.com/gentoo/portage/pull/794
    Signed-off-by: Benda Xu <heroxbd@gentoo.org>
    Signed-off-by: Sam James <sam@gentoo.org>

 bin/estrip | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 5 Larry the Git Cow gentoo-dev 2022-07-18 21:43:20 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=12cec950b69ca41a94fdc756e4025c6ea85c41a1

commit 12cec950b69ca41a94fdc756e4025c6ea85c41a1
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2022-07-18 21:43:03 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-07-18 21:43:12 +0000

    sys-apps/portage: add 3.0.33
    
    Closes: https://bugs.gentoo.org/858824
    Closes: https://bugs.gentoo.org/857933
    Closes: https://bugs.gentoo.org/858407
    Closes: https://bugs.gentoo.org/858818
    Signed-off-by: Sam James <sam@gentoo.org>

 sys-apps/portage/Manifest              |   1 +
 sys-apps/portage/portage-3.0.33.ebuild | 273 +++++++++++++++++++++++++++++++++
 2 files changed, 274 insertions(+)
Comment 6 Benda Xu gentoo-dev 2022-07-18 23:06:31 UTC
(In reply to Sam James from comment #2)
> Nit, but git author doesn't match sign off.

oops, sorry.

Thanks Sam to taking care of the patch!