Created attachment 792155 [details] the output of build.log Hi, I am attempting to upgrade from polybar 3.5.7 to polybar 3.6.3 in my prefix, but the build fails with "Aborting due to QA concerns: there are files installed outside the prefix". I've attached the complete build logs. I previously asked in IRC if this is something to be reported as a bug here or upstream, and was recommended to discuss with upstream first. I did so at [1], and was told it's a packaging problem to be reported to the ebuild maintainers. I am not sure if this is related, but there was a commit[2] 10 months ago which edited CMakeLists.txt to hard-code /etc as the installation directory. [1] https://github.com/polybar/polybar/discussions/2763 [2] https://github.com/polybar/polybar/commit/282b0f4e73e9cbb68afd6e168c472e3f422e9a6f
Created attachment 792209 [details, diff] fix-prefix-etc.patch Can you try throwing this patch into your prefix's /etc/portage/x11-misc/polybar dir and rebuilding polybar?
Sadly that didn't help, the build output says it's applying the patch but I get the same QA error at the end.
(In reply to slondr from comment #2) > Sadly that didn't help, the build output says it's applying the patch but I > get the same QA error at the end. Can you share the new log please?
Created attachment 792395 [details] build.log, after applying proposed patch
I uploaded the new build.log, although I believe I selected the wrong content type.
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d56ad80de71cba63e8862ea32fabd6f31b8cdf00 commit d56ad80de71cba63e8862ea32fabd6f31b8cdf00 Author: John Helmert III <ajak@gentoo.org> AuthorDate: 2022-07-19 16:42:50 +0000 Commit: John Helmert III <ajak@gentoo.org> CommitDate: 2022-07-19 16:43:40 +0000 x11-misc/polybar: fix prefix installation Bug: https://bugs.gentoo.org/858797 Signed-off-by: John Helmert III <ajak@gentoo.org> .../polybar/files/polybar-3.6.3-fix-prefix.patch | 13 +++++ x11-misc/polybar/polybar-3.6.3-r1.ebuild | 64 ++++++++++++++++++++++ 2 files changed, 77 insertions(+)
Can you remove the patch from /etc/portage/patches and try the -r1?
Created attachment 792452 [details, diff] Fixed version of the previous patch There seems to be a typo in the original patch, it should be `CMAKE_INSTALL_SYSCONFDIR` and not `CMAKE_INSTALL_SYSCONF_DIR`
(In reply to Patrick Ziegler from comment #8) > Created attachment 792452 [details, diff] [details, diff] > Fixed version of the previous patch > > There seems to be a typo in the original patch, it should be > `CMAKE_INSTALL_SYSCONFDIR` and not `CMAKE_INSTALL_SYSCONF_DIR` Ins't that fixed in the version ajak committed?
> Ins't that fixed in the version ajak committed? Yes, I only noticed that later. Apologies for the noise
I can confirm that updating to the -r1 worked, and I'm happily on polybar 3.6.3 now. Thank you!
Happy to hear!
