Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 858437 - app-misc/graphlcd-base: uses legacy media-gfx/imagemagick-6
Summary: app-misc/graphlcd-base: uses legacy media-gfx/imagemagick-6
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Conrad Kostecki
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-07-16 17:39 UTC by Sam James
Modified: 2022-07-24 17:45 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-07-16 17:39:33 UTC
One of only two consumers left.

Does it work with ImageMagick 7?
Comment 1 Conrad Kostecki gentoo-dev 2022-07-16 17:46:21 UTC
No, it does not work with imagemagick-7 :-( At least in my tests is failed to compile.
Comment 2 Ionen Wolkens gentoo-dev 2022-07-16 17:51:56 UTC
(In reply to Conrad Kostecki from comment #1)
> No, it does not work with imagemagick-7 :-( At least in my tests is failed
> to compile.
Given graphicsmagick is an option, maybe only support that?
Comment 3 Conrad Kostecki gentoo-dev 2022-07-16 18:59:15 UTC
(In reply to Ionen Wolkens from comment #2)
> (In reply to Conrad Kostecki from comment #1)
> > No, it does not work with imagemagick-7 :-( At least in my tests is failed
> > to compile.
> Given graphicsmagick is an option, maybe only support that?

Yes. I will drop support for imagemagick.
Comment 4 Larry the Git Cow gentoo-dev 2022-07-16 19:05:24 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0b133d317e68d3b31760a6955619808d5c14fcd0

commit 0b133d317e68d3b31760a6955619808d5c14fcd0
Author:     Conrad Kostecki <conikost@gentoo.org>
AuthorDate: 2022-07-16 19:02:05 +0000
Commit:     Conrad Kostecki <conikost@gentoo.org>
CommitDate: 2022-07-16 19:05:11 +0000

    app-misc/graphlcd-base: drop support for imagemagick
    
    Dropping support for imagemagick, as only imagemagick-6 is supported,
    but not imagemagick-7. Code is old and does not support imagemagick-7.
    Adding support is not trival, as code needs to be rewritten.
    
    Since GraphicsMagick is supported as an alternative, we will now use
    this as default, hence dropping graphicsmagick use flag too.
    
    Closes: https://bugs.gentoo.org/858437
    Signed-off-by: Conrad Kostecki <conikost@gentoo.org>

 ...cd-base-2.0.3.ebuild => graphlcd-base-2.0.3-r1.ebuild} | 15 +++++----------
 app-misc/graphlcd-base/metadata.xml                       |  2 --
 2 files changed, 5 insertions(+), 12 deletions(-)
Comment 5 Larry the Git Cow gentoo-dev 2022-07-24 17:45:59 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=9e39d4facfd8f83377bac52dffd9c4e27c0fd1da

commit 9e39d4facfd8f83377bac52dffd9c4e27c0fd1da
Author:     Conrad Kostecki <conikost@gentoo.org>
AuthorDate: 2022-07-24 17:41:48 +0000
Commit:     Conrad Kostecki <conikost@gentoo.org>
CommitDate: 2022-07-24 17:45:40 +0000

    app-misc/graphlcd-base: add support for imagemagick7
    
    Upstream added support for ImageMagick7, so re-adding support.
    
    Bug: https://bugs.gentoo.org/858437
    Signed-off-by: Conrad Kostecki <conikost@gentoo.org>

 .../files/graphlcd-base-2.0.3-imagemagick7.patch   | 338 +++++++++++++++++++++
 ...0.3-r1.ebuild => graphlcd-base-2.0.3-r2.ebuild} |  17 +-
 app-misc/graphlcd-base/metadata.xml                |   2 +
 3 files changed, 352 insertions(+), 5 deletions(-)