Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 858320 - dev-util/boost-build-1.79.0-r1 fails to compile (lto): function.cpp:225:8: error: type [-Werror=odr]
Summary: dev-util/boost-build-1.79.0-r1 fails to compile (lto): function.cpp:225:8: er...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: David Seifert
URL:
Whiteboard:
Keywords: PMASKED
Depends on:
Blocks: lto
  Show dependency tree
 
Reported: 2022-07-16 08:59 UTC by Agostino Sarubbo
Modified: 2022-12-03 13:15 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,44.16 KB, text/plain)
2022-07-16 08:59 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2022-07-16 08:59:11 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: dev-util/boost-build-1.79.0 fails to compile (lto).
Discovered on: amd64 (internal ref: lto_tinderbox)

NOTE:
This machine uses lto with CFLAGS=-flto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing
Comment 1 Agostino Sarubbo gentoo-dev 2022-07-16 08:59:13 UTC
Created attachment 791678 [details]
build.log

build log and emerge --info
Comment 2 Agostino Sarubbo gentoo-dev 2022-07-26 09:01:23 UTC
Here is a bit of explanation:

-Werror=lto-type-mismatch:
User to find possible runtime issues in packages. It likely means the package is unsafe to build & use with LTO.
For projects using the same identifier but with different types across different files, they must be fixed to be consistent across the codebase.

-Werror=odr:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. C++ code must comply with the One Definition Rule (ODR) - see https://en.cppreference.com/w/cpp/language/definition#One_Definition_Rule.

-Werror=strict-aliasing:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO.

Workarounds:
- If upstream is friendly and still active, file a bug upstream. For emulators, codecs, games, or multimedia packages, it may be worth just applying a workaround instead, as upstreams sometimes aren't receptive to these bugs (VALID FOR ALL).
- Use the new 'filter-lto' from flag-o-matic.eclass as it's likely to be unsafe with LTO (VALID FOR lto-type-mismatch - odr).
- Fix it yourself if interested, of course (VALID FOR ALL).
- Append-flags -fno-strict-aliasing (VALID FOR strict-aliasing).
- Use memcpy() but a union is sometimes suitable too (VALID FOR strict-aliasing).
- -fstrict-aliasing is implied by -O2, so this must be addressed in some form (VALID FOR strict-aliasing).

See also: https://marc.info/?l=gentoo-dev&m=165639574126280&w=2
Comment 3 Larry the Git Cow gentoo-dev 2022-09-03 20:28:36 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=83a9d34ca794ea0fec5ea5deb5dce8fd8a56bdbf

commit 83a9d34ca794ea0fec5ea5deb5dce8fd8a56bdbf
Author:     David Seifert <soap@gentoo.org>
AuthorDate: 2022-09-03 20:28:26 +0000
Commit:     David Seifert <soap@gentoo.org>
CommitDate: 2022-09-03 20:28:26 +0000

    dev-util/boost-build: add 1.80.0
    
    Bug: https://bugs.gentoo.org/858320
    Bug: https://bugs.gentoo.org/865527
    Signed-off-by: David Seifert <soap@gentoo.org>

 dev-util/boost-build/Manifest                      |   1 +
 dev-util/boost-build/boost-build-1.80.0.ebuild     |  66 +++++++++
 ...ost-build-1.80.0-add-none-feature-options.patch |  22 +++
 ...oost-build-1.80.0-no-implicit-march-flags.patch | 148 +++++++++++++++++++++
 .../boost-build/files/boost-build-1.80.0-odr.patch |  54 ++++++++
 .../boost-build-1.80.0-respect-user-flags.patch    |  11 ++
 6 files changed, 302 insertions(+)
Comment 4 Agostino Sarubbo gentoo-dev 2022-09-26 08:41:11 UTC
lto_tinderbox has reproduced this issue with version 1.79.0-r1 - Updating summary.
Comment 5 David Seifert gentoo-dev 2022-12-03 13:15:00 UTC
# Andreas Sturmlechner <asturm@gentoo.org> (2022-12-03)
# No purpose anymore after <dev-libs/boost-1.80 cleanup.
# Removal on 2022-12-16
dev-util/boost-build