Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 857669 - sys-apps/portage-3.0.31 reporting unread news items
Summary: sys-apps/portage-3.0.31 reporting unread news items
Status: RESOLVED FIXED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Unclassified (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Portage team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 857714
  Show dependency tree
 
Reported: 2022-07-11 18:50 UTC by Patrick McLean
Modified: 2023-02-18 10:13 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
log of update and command run to get news output (portage-bug.txt,3.90 KB, text/plain)
2022-07-11 18:50 UTC, Patrick McLean
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick McLean gentoo-dev 2022-07-11 18:50:17 UTC
Created attachment 791096 [details]
log of update and command run to get news output

* IMPORTANT: 54 news items need reading for repository 'gentoo'.
Comment 1 John Helmert III archtester Gentoo Infrastructure gentoo-dev Security 2022-07-11 18:53:19 UTC
Fix is https://github.com/gentoo/portage/pull/853
Comment 2 Brian Evans (RETIRED) gentoo-dev 2022-07-11 20:18:26 UTC
To get erroneous news items to go away after this is fixed, delete /var/lib/gentoo/news/news-gentoo.unread or just read the news.

It won't go away on its own otherwise
Comment 3 Larry the Git Cow gentoo-dev 2022-07-11 23:02:05 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/proj/portage.git/commit/?id=1ffaa70544f34e93df24c0a175105a900bf272bf

commit 1ffaa70544f34e93df24c0a175105a900bf272bf
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2022-07-11 04:50:24 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-07-11 23:01:04 +0000

    news: fix isRelevant check
    
    Manifested as all news items being shown, even if
    (very) irrelevant to the running system (e.g.
    different arch, packages not installed, ...).
    
    I think the distinction here is that with the previous state,
    we'd end up with _only_ Trues, or nothing (an element
    would be omitted), whereas this commit means we end
    up considering a possible mixed sequence.
    
    Closes: https://bugs.gentoo.org/857669
    Fixes: 9e24d0143450628f334cdb62e579efafd1bfd2ba
    Reported-by: kurly
    Signed-off-by: Sam James <sam@gentoo.org>

 lib/portage/news.py | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
Comment 4 Larry the Git Cow gentoo-dev 2022-07-11 23:08:20 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0b85ac662e6f974a935a06a74ca6984baaf81175

commit 0b85ac662e6f974a935a06a74ca6984baaf81175
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2022-07-11 23:08:13 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-07-11 23:08:13 +0000

    sys-apps/portage: add 3.0.32
    
    Bug: https://bugs.gentoo.org/857714
    Bug: https://bugs.gentoo.org/857669
    Signed-off-by: Sam James <sam@gentoo.org>

 sys-apps/portage/Manifest              |   1 +
 sys-apps/portage/portage-3.0.32.ebuild | 274 +++++++++++++++++++++++++++++++++
 2 files changed, 275 insertions(+)
Comment 5 Larry the Git Cow gentoo-dev 2023-02-18 10:13:50 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/portage.git/commit/?id=5718444c3d8f21cce336c744c9afe3901c22c5d8

commit 5718444c3d8f21cce336c744c9afe3901c22c5d8
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2023-02-16 08:19:42 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-02-18 10:13:35 +0000

    tests: news: add test cases for previous news regressions
    
    These tests would've caught the 3 previous regressions we had in the news feature
    over the last year.
    
    Verified by reverting each of the relevant fix commits (see below) and confirming
    the relevant tests start to fail then pass again once the fix is cherry-picked in isolation.
    
    See: 0e56f99b34939bf38dcfc0f9edf43a51f6ccf3fe
    See: f1d98b6dc36ff2b47c36427c9938999320352eb4
    See: 1ffaa70544f34e93df24c0a175105a900bf272bf
    Bug: https://bugs.gentoo.org/857669
    Bug: https://bugs.gentoo.org/889330
    Signed-off-by: Sam James <sam@gentoo.org>

 lib/portage/tests/news/test_NewsItem.py | 329 +++++++++++++++++++++++++++++---
 1 file changed, 302 insertions(+), 27 deletions(-)