Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 856964 - net-firewall/firehol-3.1.7-r1: Provide systemd units from upstream
Summary: net-firewall/firehol-3.1.7-r1: Provide systemd units from upstream
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: AMD64 Linux
: Normal minor (vote)
Assignee: James Le Cuirot
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-07-08 05:30 UTC by mphi
Modified: 2022-07-21 22:39 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description mphi 2022-07-08 05:30:15 UTC
Would it be possible to add the systemd unit provided by upstream?

Unit files:
https://github.com/firehol/firehol/blob/master/contrib/firehol.service
https://github.com/firehol/firehol/blob/master/contrib/fireqos.service

Relevant upstream ticket (closed 2015):
https://github.com/firehol/firehol/issues/17

Thank you.

Reproducible: Always

Steps to Reproduce:
1. Install
2. Check installed systemd units
Actual Results:  
firehol.service and fireqos.service unit is not installed

Expected Results:  
firehol.service and fireqos.service unit is installed
Comment 1 James Le Cuirot gentoo-dev 2022-07-16 21:54:03 UTC
I am familiar with systemd, but only on other distros. These look straightforward enough, but I can't test them. Have you tried these on Gentoo?
Comment 2 Adrian Bassett 2022-07-16 22:01:52 UTC
(In reply to James Le Cuirot from comment #1)
> I am familiar with systemd, but only on other distros. These look
> straightforward enough, but I can't test them. Have you tried these on
> Gentoo?

(Not OP but) I use a firehol.service file which is identical to the one in the first link (probably copied it over from a local git tree at some point).  No problems with it.

Don't use the fireqos service so can't comment on that one.
Comment 3 Larry the Git Cow gentoo-dev 2022-07-21 22:39:59 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=28f7686eec572ee9d5e6c956b68c4582197f763d

commit 28f7686eec572ee9d5e6c956b68c4582197f763d
Author:     James Le Cuirot <chewi@gentoo.org>
AuthorDate: 2022-07-21 22:39:21 +0000
Commit:     James Le Cuirot <chewi@gentoo.org>
CommitDate: 2022-07-21 22:39:21 +0000

    net-firewall/firehol: Install systemd service units, EAPI 8
    
    Closes: https://bugs.gentoo.org/856964
    Signed-off-by: James Le Cuirot <chewi@gentoo.org>

 .../firehol/{firehol-3.1.7-r1.ebuild => firehol-3.1.7-r2.ebuild}    | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)