Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 856943 - media-video/mpv-9999 automagic dependency on media-video/pipewire
Summary: media-video/mpv-9999 automagic dependency on media-video/pipewire
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Mikle Kolyada (RETIRED)
URL:
Whiteboard:
Keywords:
: 857138 (view as bug list)
Depends on:
Blocks:
 
Reported: 2022-07-08 00:26 UTC by jospezial
Modified: 2022-07-09 09:00 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description jospezial 2022-07-08 00:26:31 UTC
After a depclean:

>>> Unmerging (1 of 4) kde-plasma/kpipewire-9999...
>>> Unmerging (2 of 4) media-video/wireplumber-0.4.10-r6...
>>> Unmerging (3 of 4) dev-lang/lua-5.4.4...
>>> Unmerging (4 of 4) media-video/pipewire-0.3.53_p20220705-r1...
Packages installed:   1369
Packages in world:    199
Packages in system:   43
Required packages:    1369
Number removed:       4

 * GNU info directory index is up-to-date.

!!! existing preserved libs:
>>> package: media-video/pipewire-0.3.53_p20220705-r1
 *  - /usr/lib64/libpipewire-0.3.so.0
 *  - /usr/lib64/libpipewire-0.3.so.0.353.0
 *      used by /usr/bin/mpv (media-video/mpv-9999)
 *      used by /usr/lib64/libmpv.so.2.0.0 (media-video/mpv-9999)
Use emerge @preserved-rebuild to rebuild packages using these libraries

Should we add a pipewire USE flag to mpv?

https://github.com/mpv-player/mpv/blob/master/meson_options.txt#L50
option('pipewire', type: 'feature', value: 'auto', description: 'PipeWire audio output')

https://github.com/mpv-player/mpv/blob/80e29d1851334935a77eb66cf570f7126f9ddf05/meson.build#L876-L881
pipewire = dependency('libpipewire-0.3', version: '>= 0.3', required: get_option('pipewire'))
if pipewire.found()
    dependencies += pipewire
    features += 'pipewire'
    sources += files('audio/out/ao_pipewire.c')
endif

Oh I see the mpv ebuild is not yet converted from waf to meson.
Comment 1 Larry the Git Cow gentoo-dev 2022-07-09 02:41:30 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=15ec35a786aaa2db6b77ff3af468353441b7dffd

commit 15ec35a786aaa2db6b77ff3af468353441b7dffd
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2022-07-09 02:31:23 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-07-09 02:39:15 +0000

    media-video/mpv: port live ebuild to meson
    
    Closes: https://bugs.gentoo.org/856943
    Signed-off-by: Sam James <sam@gentoo.org>

 media-video/mpv/files/mpv-9999-docdir.patch |  11 ++
 media-video/mpv/metadata.xml                |   3 +
 media-video/mpv/mpv-9999.ebuild             | 273 +++++++++++++---------------
 3 files changed, 145 insertions(+), 142 deletions(-)
Comment 2 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-07-09 02:42:00 UTC
Thanks! It's a first cut of the port to meson so there may be issues. If there are any, please file new bugs to make sure I catch them (given I don't maintain mpv).
Comment 3 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-07-09 09:00:54 UTC
*** Bug 857138 has been marked as a duplicate of this bug. ***