https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/ Issue: dev-perl/PDL-2.63.0 fails to compile (lto). Discovered on: amd64 (internal ref: lto_tinderbox) NOTE: This machine uses lto with CFLAGS=-flto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing
Created attachment 790055 [details] build.log build log and emerge --info
Here is a bit of explanation: -Werror=lto-type-mismatch: User to find possible runtime issues in packages. It likely means the package is unsafe to build & use with LTO. For projects using the same identifier but with different types across different files, they must be fixed to be consistent across the codebase. -Werror=odr: Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. C++ code must comply with the One Definition Rule (ODR) - see https://en.cppreference.com/w/cpp/language/definition#One_Definition_Rule. -Werror=strict-aliasing: Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. Workarounds: - If upstream is friendly and still active, file a bug upstream. For emulators, codecs, games, or multimedia packages, it may be worth just applying a workaround instead, as upstreams sometimes aren't receptive to these bugs (VALID FOR ALL). - Use the new 'filter-lto' from flag-o-matic.eclass as it's likely to be unsafe with LTO (VALID FOR lto-type-mismatch - odr). - Fix it yourself if interested, of course (VALID FOR ALL). - Append-flags -fno-strict-aliasing (VALID FOR strict-aliasing). - Use memcpy() but a union is sometimes suitable too (VALID FOR strict-aliasing). - -fstrict-aliasing is implied by -O2, so this must be addressed in some form (VALID FOR strict-aliasing). See also: https://marc.info/?l=gentoo-dev&m=165639574126280&w=2
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=599e1dc43dd98ed10c46df2503493c712e74c2e6 commit 599e1dc43dd98ed10c46df2503493c712e74c2e6 Author: Eli Schwartz <eschwartz93@gmail.com> AuthorDate: 2024-03-27 04:01:44 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2024-03-27 04:49:46 +0000 dev-perl/PDL: mark as LTO-unsafe Closes: https://bugs.gentoo.org/856406 Signed-off-by: Eli Schwartz <eschwartz93@gmail.com> Signed-off-by: Sam James <sam@gentoo.org> dev-perl/PDL/PDL-2.63.0.ebuild | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-)
The upstream ticket is fixed, PDL appears to build cleanly with LTO from a git checkout.
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=95b7c07b2a05902b8002a4f7ab91034247fdb810 commit 95b7c07b2a05902b8002a4f7ab91034247fdb810 Author: Sam James <sam@gentoo.org> AuthorDate: 2024-04-10 00:30:27 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2024-04-10 00:56:20 +0000 dev-perl/PDL: add 2.87.0 * Drop USE=threads. Tests fail to compile with USE=-threads with: ``` Basic/SourceFilter/../../blib/arch/auto/PDL/Core/Core.so: undefined symbol: pdl_pthread_free at /usr/lib64/perl5/5.38/x86_64-linux/DynaLoader.pm line 206. ``` and configure loudly warns too: ``` pthread disabled in perldl.conf PDL will be built without POSIX thread support. ==> *NOTE*: PDL threads are unrelated to perl threads (usethreads=y)! ==> Enabling perl threads will not help! ``` Just drop it. I don't see the value in it here. See net-misc/curl's bd4d42f83c774c36bf879a5b7ec89d373546743e for the general rationale in killing USE=threads. * Drop now-obsolete LTO filtering as it was fixed in the last release after Eli reported it upstream, yay! Bug: https://bugs.gentoo.org/856406 Signed-off-by: Sam James <sam@gentoo.org> dev-perl/PDL/Manifest | 1 + dev-perl/PDL/PDL-2.87.0.ebuild | 140 ++++++++++++++++++++++++++++ dev-perl/PDL/files/PDL-2.87.0-fortran.patch | 26 ++++++ 3 files changed, 167 insertions(+)
