https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/ Issue: dev-db/sqlitebrowser-3.12.2 fails to compile (lto). Discovered on: amd64 (internal ref: lto_tinderbox) NOTE: This machine uses lto with CFLAGS=-flto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing
Created attachment 788861 [details] build.log build log and emerge --info
Error(s) that match a know pattern in addition to what has been reported in the summary: FAILED: sqlitebrowser /var/tmp/portage/dev-db/sqlitebrowser-3.12.2/work/sqlitebrowser-3.12.2/src/sql/parser/ParserDriver.h:19:7: error: type ‘struct ParserDriver’ violates the C++ One Definition Rule [-Werror=odr]
Here is a bit of explanation: -Werror=lto-type-mismatch: User to find possible runtime issues in packages. It likely means the package is unsafe to build & use with LTO. For projects using the same identifier but with different types across different files, they must be fixed to be consistent across the codebase. -Werror=odr: Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. C++ code must comply with the One Definition Rule (ODR) - see https://en.cppreference.com/w/cpp/language/definition#One_Definition_Rule. -Werror=strict-aliasing: Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. Workarounds: - If upstream is friendly and still active, file a bug upstream. For emulators, codecs, games, or multimedia packages, it may be worth just applying a workaround instead, as upstreams sometimes aren't receptive to these bugs (VALID FOR ALL). - Use the new 'filter-lto' from flag-o-matic.eclass as it's likely to be unsafe with LTO (VALID FOR lto-type-mismatch - odr). - Fix it yourself if interested, of course (VALID FOR ALL). - Append-flags -fno-strict-aliasing (VALID FOR strict-aliasing). - Use memcpy() but a union is sometimes suitable too (VALID FOR strict-aliasing). - -fstrict-aliasing is implied by -O2, so this must be addressed in some form (VALID FOR strict-aliasing). See also: https://marc.info/?l=gentoo-dev&m=165639574126280&w=2
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f0c715b72c40a0cce096ebcb98315de5cba1b59a commit f0c715b72c40a0cce096ebcb98315de5cba1b59a Author: Mattéo Rossillol‑‑Laruelle <beatussum@protonmail.com> AuthorDate: 2023-12-22 13:02:18 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2024-01-20 12:22:55 +0000 dev-db/sqlitebrowser: revbump Closes: https://bugs.gentoo.org/855254 Closes: https://bugs.gentoo.org/913047 Signed-off-by: Mattéo Rossillol‑‑Laruelle <beatussum@protonmail.com> Closes: https://github.com/gentoo/gentoo/pull/34420 Signed-off-by: Sam James <sam@gentoo.org> dev-db/sqlitebrowser/metadata.xml | 6 ++ .../sqlitebrowser/sqlitebrowser-3.12.2-r1.ebuild | 73 ++++++++++++++++++++++ dev-db/sqlitebrowser/sqlitebrowser-9999.ebuild | 14 +++-- 3 files changed, 89 insertions(+), 4 deletions(-)
