Bug 855233 – dev-db/mariadb-10.11.6 fails to compile (lto): ma_client_plugin.c:86:39: error: type of pvio_socket_client_plugin does not match original declaration [-Werror=lto-type-mismatch]

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Agostino Sarubbo 2022-06-30 06:02:43 UTC]

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: dev-db/mariadb-10.2.44 fails to compile (lto).
Discovered on: amd64 (internal ref: lto_tinderbox)

NOTE:
This machine uses lto with CFLAGS=-flto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing

[Comment 1 Agostino Sarubbo 2022-06-30 06:02:46 UTC]

Created attachment 788840 [details]
build.log

build log and emerge --info

[Comment 2 Agostino Sarubbo 2022-06-30 06:02:48 UTC]

Error(s) that match a know pattern in addition to what has been reported in the summary:


--   Package 'heimdal-gssapi', required by 'virtual:world', not found
--   Package 'heimdal-krb5', required by 'virtual:world', not found
--   Package 'mit-krb5', required by 'virtual:world', not found
--   Package 'mit-krb5-gssapi', required by 'virtual:world', not found
FAILED: libmariadb/libmariadb/libmariadb.so.3 
/var/tmp/portage/dev-db/mariadb-10.2.44/work/mariadb-10.2.44_build/libmariadb/libmariadb/ma_client_plugin.c:86:39: error: type of ‘pvio_socket_client_plugin’ does not match original declaration [-Werror=lto-type-mismatch]

[Comment 3 Agostino Sarubbo 2022-07-26 09:00:35 UTC]

Here is a bit of explanation:

-Werror=lto-type-mismatch:
User to find possible runtime issues in packages. It likely means the package is unsafe to build & use with LTO.
For projects using the same identifier but with different types across different files, they must be fixed to be consistent across the codebase.

-Werror=odr:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. C++ code must comply with the One Definition Rule (ODR) - see https://en.cppreference.com/w/cpp/language/definition#One_Definition_Rule.

-Werror=strict-aliasing:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO.

Workarounds:
- If upstream is friendly and still active, file a bug upstream. For emulators, codecs, games, or multimedia packages, it may be worth just applying a workaround instead, as upstreams sometimes aren't receptive to these bugs (VALID FOR ALL).
- Use the new 'filter-lto' from flag-o-matic.eclass as it's likely to be unsafe with LTO (VALID FOR lto-type-mismatch - odr).
- Fix it yourself if interested, of course (VALID FOR ALL).
- Append-flags -fno-strict-aliasing (VALID FOR strict-aliasing).
- Use memcpy() but a union is sometimes suitable too (VALID FOR strict-aliasing).
- -fstrict-aliasing is implied by -O2, so this must be addressed in some form (VALID FOR strict-aliasing).

See also: https://marc.info/?l=gentoo-dev&m=165639574126280&w=2

[Comment 4 Agostino Sarubbo 2024-02-15 15:59:44 UTC]

lto_tinderbox has reproduced this issue with version 10.11.6 - Updating summary.

[Comment 5 Sam James 2024-03-04 04:48:26 UTC]

There's a lot of issues here, e.g. https://jira.mariadb.org/browse/MDEV-11914 and https://jira.mariadb.org/browse/MDEV-25633.

[Comment 6 Larry the Git Cow 2024-03-04 04:53:35 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3feee7984bf0b20f52f20dec288f152d756004da

commit 3feee7984bf0b20f52f20dec288f152d756004da
Author:     Sam James <[e-mail]>
AuthorDate: 2024-03-04 04:49:58 +0000
Commit:     Sam James <[e-mail]>
CommitDate: 2024-03-04 04:49:58 +0000

    dev-db/mariadb: filter LTO
    
    Bug: https://jira.mariadb.org/browse/MDEV-11914
    Bug: https://jira.mariadb.org/browse/MDEV-25633
    Bug: https://bugs.gentoo.org/855236
    Closes: https://bugs.gentoo.org/855233
    Signed-off-by: Sam James <[e-mail]>

 dev-db/mariadb/mariadb-10.11.5-r1.ebuild | 2 ++
 dev-db/mariadb/mariadb-10.11.5.ebuild    | 2 ++
 dev-db/mariadb/mariadb-10.11.6.ebuild    | 2 ++
 dev-db/mariadb/mariadb-10.6.14.ebuild    | 2 ++
 dev-db/mariadb/mariadb-10.6.15-r1.ebuild | 2 ++
 dev-db/mariadb/mariadb-10.6.15.ebuild    | 2 ++
 dev-db/mariadb/mariadb-10.6.16.ebuild    | 2 ++
 7 files changed, 14 insertions(+)

Additionally, it has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a75e6bb902f21f884eddfda9efebf7d8ca6f04a9

commit a75e6bb902f21f884eddfda9efebf7d8ca6f04a9
Author:     Sam James <[e-mail]>
AuthorDate: 2024-03-04 04:51:50 +0000
Commit:     Sam James <[e-mail]>
CommitDate: 2024-03-04 04:52:40 +0000

    dev-db/mariadb-connector-c: filter LTO
    
    Bug: https://jira.mariadb.org/browse/MDEV-11914
    Bug: https://jira.mariadb.org/browse/MDEV-25633
    Bug: https://bugs.gentoo.org/855233
    Closes: https://bugs.gentoo.org/855236
    Signed-off-by: Sam James <[e-mail]>

 dev-db/mariadb-connector-c/mariadb-connector-c-3.2.7.ebuild | 13 ++++++++++---
 dev-db/mariadb-connector-c/mariadb-connector-c-3.3.4.ebuild | 13 ++++++++++---
 dev-db/mariadb-connector-c/mariadb-connector-c-9999.ebuild  | 13 ++++++++++---
 3 files changed, 30 insertions(+), 9 deletions(-)