Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 855179 - net-misc/ytfzf - add USE flag "ueberzug"
Summary: net-misc/ytfzf - add USE flag "ueberzug"
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Ionen Wolkens
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-06-29 22:40 UTC by Bogdan
Modified: 2022-07-15 15:11 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Bogdan 2022-06-29 22:40:58 UTC
I call command:
  ytfzf -t some search words

But get an error:
  ueberzug is not installed

After installing media-gfx/ueberzug - I can use "ytfzf -t" command and see image of videos in the terminal.

Please, add to ebuild:

  USE="ueberzug"
  RDEPENT="ueberzug? (media-gfx/ueberzug)"
Comment 1 Ionen Wolkens gentoo-dev 2022-06-29 22:53:08 UTC
 * Messages for package net-misc/ytfzf-2.4.0:
 * Log file: /var/log/portage/net-misc:ytfzf-2.4.0:20220629-224618.log.gz

 * Install additional packages for optional runtime features:
 *   x11-misc/dmenu for external menu support
 *   media-gfx/ueberzug for in-terminal thumbnails on X11
     ^^^^^^^^^^^^^^^^^^
 *   x11-libs/libnotify for desktop notifications
 * Note that ytfzf supports many methods to display menus/thumbnails.
                            ^^^^^^^^^^^^
 * This ebuild primarily covers defaults and major features, additional
 * dependencies may be needed for others.

I'd rather not start adding USE for all of these, so opted to just warn about it.
Comment 2 Larry the Git Cow gentoo-dev 2022-07-15 15:11:39 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3e6b751c1cc24519d4c10e16987bbe87d8f16e7c

commit 3e6b751c1cc24519d4c10e16987bbe87d8f16e7c
Author:     Ionen Wolkens <ionen@gentoo.org>
AuthorDate: 2022-07-15 14:49:03 +0000
Commit:     Ionen Wolkens <ionen@gentoo.org>
CommitDate: 2022-07-15 15:11:12 +0000

    net-misc/ytfzf: add IUSE=X for ueberzug, adjust postinst message
    
    On second thought, may be fair to provide upstream's default, but given
    ueberzug is X-only put it behind IUSE=X (also allows to auto-enable on
    desktop profiles and such). No intention to add separate use for every
    option, so not using IUSE=ueberzug.
    
    IUSE=minimal will still disable everything optional should users want
    to use this differently (e.g. I use kitty to display images rather than
    ueberzug). Currently no straight-forward choice for wayland, so won't
    provide a IUSE=wayland at the moment (could use chafa but well, not
    high quality display and still requires changing settings).
    
    Closes: https://bugs.gentoo.org/855179
    Signed-off-by: Ionen Wolkens <ionen@gentoo.org>

 net-misc/ytfzf/ytfzf-2.4.0.ebuild | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)