https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/ Issue: app-misc/bb-1.3.0_rc1-r5 fails to compile (lto). Discovered on: amd64 (internal ref: lto_tinderbox) NOTE: This machine uses lto with CFLAGS=-flto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing
Created attachment 788210 [details] build.log build log and emerge --info
Here is a bit of explanation: -Werror=lto-type-mismatch: User to find possible runtime issues in packages. It likely means the package is unsafe to build & use with LTO. For projects using the same identifier but with different types across different files, they must be fixed to be consistent across the codebase. -Werror=odr: Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. C++ code must comply with the One Definition Rule (ODR) - see https://en.cppreference.com/w/cpp/language/definition#One_Definition_Rule. -Werror=strict-aliasing: Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. Workarounds: - If upstream is friendly and still active, file a bug upstream. For emulators, codecs, games, or multimedia packages, it may be worth just applying a workaround instead, as upstreams sometimes aren't receptive to these bugs (VALID FOR ALL). - Use the new 'filter-lto' from flag-o-matic.eclass as it's likely to be unsafe with LTO (VALID FOR lto-type-mismatch - odr). - Fix it yourself if interested, of course (VALID FOR ALL). - Append-flags -fno-strict-aliasing (VALID FOR strict-aliasing). - Use memcpy() but a union is sometimes suitable too (VALID FOR strict-aliasing). - -fstrict-aliasing is implied by -O2, so this must be addressed in some form (VALID FOR strict-aliasing). See also: https://marc.info/?l=gentoo-dev&m=165639574126280&w=2
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1b00803e385f59726a20018c9911566af6646951 commit 1b00803e385f59726a20018c9911566af6646951 Author: Pascal Jäger <pascal.jaeger@leimstift.de> AuthorDate: 2022-11-11 21:59:27 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2022-11-15 02:10:56 +0000 app-misc/bb: revbump, fix build for clang16 and lto Closes: https://bugs.gentoo.org/880385 Closes: https://bugs.gentoo.org/854720 Signed-off-by: Pascal Jäger <pascal.jaeger@leimstift.de> Closes: https://github.com/gentoo/gentoo/pull/28233 Signed-off-by: Sam James <sam@gentoo.org> .../files/bb-1.3.0_rc1-fix-build-for-clang16.patch | 23 ++++++++++++++++++++++ .../files/bb-1.3.0_rc1-fix-lto-type-mismatch.patch | 18 +++++++++++++++++ 2 files changed, 41 insertions(+)
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=996809c0e52057ec8e5f32dd1d9f8f9bea559c18 commit 996809c0e52057ec8e5f32dd1d9f8f9bea559c18 Author: Pascal Jäger <pascal.jaeger@leimstift.de> AuthorDate: 2022-11-11 21:59:27 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2022-11-22 06:48:42 +0000 app-misc/bb: revbump, fix build for clang16 and lto Closes: https://bugs.gentoo.org/880385 Closes: https://bugs.gentoo.org/854720 Signed-off-by: Pascal Jäger <pascal.jaeger@leimstift.de> Closes: https://github.com/gentoo/gentoo/pull/28233 Signed-off-by: Sam James <sam@gentoo.org> ...-1.3.0_rc1-r5.ebuild => bb-1.3.0_rc1-r6.ebuild} | 7 +++- .../files/bb-1.3.0_rc1-fix-build-for-clang16.patch | 23 +++++++++++ .../files/bb-1.3.0_rc1-fix-lto-type-mismatch.patch | 18 +++++++++ .../bb-1.3.0_rc1-fix-return-type-and-QA.patch | 47 ++++++++++++++++++++++ 4 files changed, 93 insertions(+), 2 deletions(-)
