Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 854615 - app-text/xournalpp-1.1.1-r1: fails to compile (luapi_application.h:907: undefined reference to `luaL_checkversion_')
Summary: app-text/xournalpp-1.1.1-r1: fails to compile (luapi_application.h:907: undef...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: AMD64 Linux
: Normal normal (vote)
Assignee: Andreas K. Hüttel
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-06-27 17:29 UTC by Odín Miguel Escorza Soria
Modified: 2023-04-10 03:38 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
emerge --info (emergeInfo.txt,7.21 KB, text/plain)
2022-06-27 17:30 UTC, Odín Miguel Escorza Soria
Details
Build log (file_854615.txt,699.64 KB, text/plain)
2022-06-27 17:33 UTC, Odín Miguel Escorza Soria
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Odín Miguel Escorza Soria 2022-06-27 17:29:43 UTC
I'm almost sure this has something to do with my setup, but I can't figure out what is wrong with it. I've already rebuilt binutils, binutils-lib and gcc but still no luck
Comment 1 Odín Miguel Escorza Soria 2022-06-27 17:30:28 UTC
Created attachment 788084 [details]
emerge --info
Comment 2 Odín Miguel Escorza Soria 2022-06-27 17:33:12 UTC
Created attachment 788087 [details]
Build log
Comment 3 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-06-28 09:06:50 UTC
1. Has this built for you before?
2. Missing Lua dep, maybe?
Comment 4 Odín Miguel Escorza Soria 2022-06-28 15:57:27 UTC
1. Before a world update I was able to build and install app-text/xournalpp-1.0.20, uninstalled it thinking it would be useful after failed upgrade :-( I've just tried to install that old version again and I faced the #836783 issue.

2. I also rebuilt =dev-lang/lua-5.4.2-r1... wrong package or version perhaps?
Comment 5 Odín Miguel Escorza Soria 2022-06-28 16:37:38 UTC
Yep, downgrading to dev-lang/lua-5.3.6-r2 did te trick... Should I mark this issue as resolved?
Comment 6 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-07-01 09:04:11 UTC
(In reply to Odín Miguel Escorza Soria from comment #5)
> Yep, downgrading to dev-lang/lua-5.3.6-r2 did te trick... Should I mark this
> issue as resolved?

If it still fails with newer Lua, then it's a valid bug, as the ebuild should be fixed in some form.

Are you saying it works with Lua 5.3 and not Lua 5.4, or that it works with certain 5.3 / 5.4 versions?
Comment 7 Odín Miguel Escorza Soria 2022-07-01 15:39:09 UTC
I'm saying it works with Lua 5.3 but not with Lua 5.4

To reproduce:

1. Install Lua 5.3
2. Install Xournalpp-1.1.1-r1
3. Upgrade to Lua 5.4 (removing version 5.3)
4. Try to rebuild Xournalpp
Comment 8 Larry the Git Cow gentoo-dev 2022-07-02 15:10:33 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=241acff2f4cfdcd385aff4837b3ac73f87c6ce9d

commit 241acff2f4cfdcd385aff4837b3ac73f87c6ce9d
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2022-07-02 15:10:20 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-07-02 15:10:27 +0000

    app-text/xournalpp: add missing Lua dep
    
    Closes: https://bugs.gentoo.org/854615
    Signed-off-by: Sam James <sam@gentoo.org>

 app-text/xournalpp/xournalpp-1.1.1-r2.ebuild | 49 ++++++++++++++++++++++++++++
 app-text/xournalpp/xournalpp-9999.ebuild     | 23 ++++++-------
 2 files changed, 59 insertions(+), 13 deletions(-)
Comment 9 Bernd Feige 2023-04-09 10:09:52 UTC
Actually Lua5.4 works with current xournalpp-1.1.3:

CMakeList comment "# Lua 5.4 is only supported with cmake >=3.18"

During configure (with current dev-util/cmake-3.26.3):
-- Could NOT find Lua (missing: LUA_LIBRARIES LUA_INCLUDE_DIR) (Required is exact version "5.3")
-- Found Lua: /usr/lib64/liblua5.4.so;/usr/lib64/libm.so (found suitable version "5.4.4", minimum required is "5.3") 
Enable Xournal++ Plugins


Tried it, and plugins are actually enabled.
Comment 10 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-04-10 03:29:27 UTC
(In reply to Bernd Feige from comment #9)
> Actually Lua5.4 works with current xournalpp-1.1.3:
> 
> CMakeList comment "# Lua 5.4 is only supported with cmake >=3.18"
> 
> During configure (with current dev-util/cmake-3.26.3):
> -- Could NOT find Lua (missing: LUA_LIBRARIES LUA_INCLUDE_DIR) (Required is
> exact version "5.3")
> -- Found Lua: /usr/lib64/liblua5.4.so;/usr/lib64/libm.so (found suitable
> version "5.4.4", minimum required is "5.3") 
> Enable Xournal++ Plugins
> 
> 
> Tried it, and plugins are actually enabled.

I think we should still tweak:
>(Required is exact version "5.3")

But that sounds good if it actually works.
Comment 11 Larry the Git Cow gentoo-dev 2023-04-10 03:38:45 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=92eb2acc80acbdc7874a07fea529201047ea9dee

commit 92eb2acc80acbdc7874a07fea529201047ea9dee
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2023-04-10 03:37:19 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-04-10 03:37:19 +0000

    app-text/xournalpp: support Lua 5.4, fix build w/ gcc 13
    
    Bug: https://bugs.gentoo.org/854615
    Closes: https://bugs.gentoo.org/894720
    Closes: https://bugs.gentoo.org/895536
    Signed-off-by: Sam James <sam@gentoo.org>

 .../xournalpp/files/xournalpp-1.1.3-gcc13.patch    | 12 +++++
 .../xournalpp/files/xournalpp-1.1.3-lua-5-4.patch  | 14 ++++++
 app-text/xournalpp/xournalpp-1.1.3-r1.ebuild       | 58 ++++++++++++++++++++++
 app-text/xournalpp/xournalpp-9999.ebuild           | 15 ++++--
 4 files changed, 96 insertions(+), 3 deletions(-)