Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 854312 - www-plugins/browserpass - add support for www-client/vivaldi
Summary: www-plugins/browserpass - add support for www-client/vivaldi
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Matt Turner
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-06-25 19:53 UTC by Neil
Modified: 2023-04-09 02:10 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Neil 2022-06-25 19:53:56 UTC
Would it be possible to include support for www-client/vivaldi to www-plugins/browserpass?

browserpass supports it as a make target (see https://github.com/browserpass/browserpass-native#configure-browsers=).

I thought it would be a straight-forward copy of the lines in the ebuild but after looking at the Makefile I see that because Vivaldi is based on chrome its more appropriate to use...

--- /usr/portage/www-plugins/browserpass/browserpass-3.0.10.ebuild	2022-06-04 21:10:34.000000000 +0100
+++ browserpass-3.0.10-r1.ebuild	2022-06-25 20:41:14.752098637 +0100
@@ -40,4 +40,7 @@
 
 	insinto /etc/opt/chrome/native-messaging-hosts
 	newins browser-files/chromium-host.json com.github.browserpass.native.json
+
+	insinto /etc/opt/vivaldi/native-messaging-hosts
+	newins browser-files/chromium-host.json com.github.browserpass.native.json
 }


It appears to work ok on my system.
Comment 1 Larry the Git Cow gentoo-dev 2023-04-09 02:10:40 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1cba0e8028af3f310ce88fd5bb4fa8560431e1af

commit 1cba0e8028af3f310ce88fd5bb4fa8560431e1af
Author:     Matt Turner <mattst88@gentoo.org>
AuthorDate: 2023-04-09 01:49:12 +0000
Commit:     Matt Turner <mattst88@gentoo.org>
CommitDate: 2023-04-09 02:10:20 +0000

    www-plugins/browserpass: Version bump to 3.1.0
    
    Also add Vivaldi support (bug #854312)
    
    Closes: https://bugs.gentoo.org/854312
    Signed-off-by: Matt Turner <mattst88@gentoo.org>

 www-plugins/browserpass/Manifest                 |  2 ++
 www-plugins/browserpass/browserpass-3.1.0.ebuild | 46 ++++++++++++++++++++++++
 www-plugins/browserpass/metadata.xml             |  3 ++
 3 files changed, 51 insertions(+)