Created attachment 786338 [details] Build log Fails to buils with: In file included from ./../../../../qtwebengine-5.15.5_p20220618/src/3rdparty/chromium/content/renderer/media/batching_media_log.cc:5: ../../../../qtwebengine-5.15.5_p20220618/src/3rdparty/chromium/content/renderer/media/batching_media_log.h:75:49: error: use of undeclared identifier 'LOCK' const base::TickClock* tick_clock_ GUARDED_BY(LOCK); ^ ../../../../qtwebengine-5.15.5_p20220618/src/3rdparty/chromium/content/renderer/media/batching_media_log.h:76:50: error: use of undeclared identifier 'LOCK' base::TimeTicks last_ipc_send_time_ GUARDED_BY(LOCK); ^ ../../../../qtwebengine-5.15.5_p20220618/src/3rdparty/chromium/content/renderer/media/batching_media_log.h:77:70: error: use of undeclared identifier 'LOCK' std::vector<media::MediaLogRecord> queued_media_events_ GUARDED_BY(LOCK); ^ ../../../../qtwebengine-5.15.5_p20220618/src/3rdparty/chromium/content/renderer/media/batching_media_log.h:80:73: error: use of undeclared identifier 'LOCK' std::vector<std::unique_ptr<EventHandler>> event_handlers_ GUARDED_BY(LOCK); ^ ../../../../qtwebengine-5.15.5_p20220618/src/3rdparty/chromium/content/renderer/media/batching_media_log.h:83:37: error: use of undeclared identifier 'LOCK' bool ipc_send_pending_ GUARDED_BY(LOCK); ^ ../../../../qtwebengine-5.15.5_p20220618/src/3rdparty/chromium/content/renderer/media/batching_media_log.h:86:82: error: use of undeclared identifier 'LOCK' std::unique_ptr<media::MediaLogRecord> last_duration_changed_event_ GUARDED_BY(LOCK); ^ Built with clang-14, libstdc++ gcc-11. emerge --info qtwebengine Portage 3.0.30 (python 3.10.4-final-0, default/linux/amd64/17.1/desktop/plasma, gcc-11.3.0, glibc-2.34-r13, 5.18.5 x86_64) ================================================================= System Settings ================================================================= System uname: Linux-5.18.5-x86_64-AMD_Ryzen_7_2700_Eight-Core_Processor-with-glibc2.34 KiB Mem: 24568580 total, 13178000 free KiB Swap: 0 total, 0 free Timestamp of repository gentoo: Sun, 19 Jun 2022 14:48:00 +0000 Head commit of repository gentoo: abaa9ca002bf8c190bc55c4b0f89e6a8dd450609 Timestamp of repository kde: Sun, 19 Jun 2022 09:18:45 +0000 Head commit of repository kde: 73ca08d6b3780f00a825b43f9194be6dcfc9c8cc Timestamp of repository palemoon: Sat, 11 Jun 2022 00:32:58 +0000 Head commit of repository palemoon: c6994d87a04f42655035043bd7969f1a066f9891 Head commit of repository rion: b6488f30a66eb65bef1e23f51b3b10ff18cfaf1f Timestamp of repository steam-overlay: Sun, 12 Jun 2022 09:02:56 +0000 Head commit of repository steam-overlay: 23a727b7f9d868134563b44dcf4ebba5dd46b5a2 Timestamp of repository torbrowser: Sun, 12 Jun 2022 08:49:05 +0000 Head commit of repository torbrowser: 755dc3dae27d38a0f39609370bf34a6629c8d591 sh bash 5.1_p16 ld GNU ld (Gentoo 2.37_p1 p2) 2.37 app-misc/pax-utils: 1.3.3::gentoo app-shells/bash: 5.1_p16::gentoo dev-java/java-config: 2.3.1::gentoo dev-lang/perl: 5.34.1-r3::gentoo dev-lang/python: 3.10.4::gentoo dev-util/cmake: 3.23.2::gentoo dev-util/meson: 0.61.4-r2::gentoo sys-apps/baselayout: 2.8::gentoo sys-apps/openrc: 0.45.1::gentoo sys-apps/sandbox: 2.29::gentoo sys-devel/autoconf: 2.71-r1::gentoo sys-devel/automake: 1.16.5::gentoo sys-devel/binutils: 2.37_p1-r2::gentoo sys-devel/binutils-config: 5.4.1::gentoo sys-devel/clang: 14.0.4::gentoo sys-devel/gcc: 11.3.0::gentoo sys-devel/gcc-config: 2.5-r1::gentoo sys-devel/libtool: 2.4.7::gentoo sys-devel/lld: 14.0.4::gentoo sys-devel/llvm: 14.0.4::gentoo sys-devel/make: 4.3::gentoo sys-kernel/linux-headers: 5.18-r1::gentoo (virtual/os-headers) sys-libs/glibc: 2.34-r13::gentoo Repositories: gentoo location: /mnt/portage/portage sync-type: git sync-uri: https://github.com/gentoo-mirror/gentoo.git priority: -1000 kde location: /mnt/portage/layman/kde sync-type: git sync-uri: https://github.com/gentoo-mirror/kde.git masters: gentoo local location: /mnt/portage/layman/local masters: gentoo palemoon location: /mnt/portage/layman/palemoon sync-type: git sync-uri: https://github.com/gentoo-mirror/palemoon.git masters: gentoo rion location: /mnt/portage/layman/rion sync-type: git sync-uri: https://github.com/gentoo-mirror/rion.git masters: gentoo steam-overlay location: /mnt/portage/layman/steam-overlay sync-type: git sync-uri: https://github.com/gentoo-mirror/steam-overlay.git masters: gentoo torbrowser location: /mnt/portage/layman/torbrowser sync-type: git sync-uri: https://github.com/gentoo-mirror/torbrowser.git masters: gentoo ACCEPT_KEYWORDS="amd64" ACCEPT_LICENSE="* AdobeFlash-10.1 skype-eula Q3AEULA AdobeFlash-10.3 skype-4.0.0.7-copyright AdobeFlash-11.x TeamViewer Oracle-BCLA-JavaSE OPERA-12 OPERA-2014" CBUILD="x86_64-pc-linux-gnu" CFLAGS="-mtune=native -O2 -pipe" CHOST="x86_64-pc-linux-gnu" CONFIG_PROTECT="/etc /usr/lib64/libreoffice/program/sofficerc /usr/share/config /usr/share/gnupg/qualified.txt" CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo" CXXFLAGS="-mtune=native -O2 -pipe" DISTDIR="/home/distfiles" EMERGE_DEFAULT_OPTS="--quiet-build=n " ENV_UNSET="CARGO_HOME DBUS_SESSION_BUS_ADDRESS DISPLAY GOBIN GOPATH PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR" FCFLAGS="-O2 -pipe" FEATURES="assume-digests binpkg-docompress binpkg-dostrip binpkg-logs binpkg-multi-instance buildpkg-live config-protect-if-modified distlocks ebuild-locks fixlafiles ipc-sandbox merge-sync multilib-strict network-sandbox news parallel-fetch pid-sandbox preserve-libs protect-owned qa-unresolved-soname-deps sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr" FFLAGS="-O2 -pipe" GENTOO_MIRRORS="http://distfiles.gentoo.org" LANG="ru_RU.UTF-8" LC_ALL="ru_RU.UTF-8" LDFLAGS="-Wl,-O1 -Wl,--as-needed" LINGUAS="ru ru_RU" MAKEOPTS="-j14" PKGDIR="/home/packages" PORTAGE_CONFIGROOT="/" PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git" PORTAGE_TMPDIR="/var/tmp" SHELL="/bin/bash" USE="X a52 aac acl acpi activities alsa amd64 branding bzip2 cairo cdr cli corefont crypt dbus declarative dist-kernel dri dts dvd dvdr elogind encode exif ffmpeg flac fortran gdbm gif gpm gtk gui iconv icu idn ip6 ipv6 jgp jpeg kde kwallet lcms libglvnd libnotify libtirpc mad matroska midi mmx mng mp3 mp4 mpeg multilib ncurses nls nptl offensive ogg opengl openmp pam pango pcre pdf plasma png policykit ppds private-headers pulseaudio qml qt qt3support qt5 rar readline samba sdl seccomp spell split-usr sse sse2 sse3 ssl startup-notification svg symlink taglib theora tiff truetype udev udisks unicode unrar upower usb utf8 vdpau vorbis widgets wxwidgets x264 xattr xcb xml xorg xv xvid zlib zstd" ABI_X86="64" ADA_TARGET="gnat_2020" ALSA_CARDS="hda-intel" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="karbon sheets words" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="mmx mmxext sse sse2 sse3" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock greis isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" GRUB_PLATFORMS="efi-64" INPUT_DEVICES="libinput" KERNEL="linux" L10N="ru en" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LUA_SINGLE_TARGET="lua5-1" LUA_TARGETS="lua5-1" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php7-4 php8-0" POSTGRES_TARGETS="postgres12 postgres13" PYTHON_SINGLE_TARGET="python3_10" PYTHON_TARGETS="python3_10" RUBY_TARGETS="ruby27" USERLAND="GNU" VIDEO_CARDS="nouveau" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq proto steal rawnat logmark ipmark dhcpmac delude chaos account" Unset: ADDR2LINE, AR, ARFLAGS, AS, ASFLAGS, CC, CCLD, CONFIG_SHELL, CPP, CPPFLAGS, CTARGET, CXX, CXXFILT, ELFEDIT, EXTRA_ECONF, F77FLAGS, FC, GCOV, GPROF, INSTALL_MASK, LD, LEX, LFLAGS, LIBTOOL, MAKE, MAKEFLAGS, NM, OBJCOPY, OBJDUMP, PORTAGE_BINHOST, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, RANLIB, READELF, RUSTFLAGS, SIZE, STRINGS, STRIP, YACC, YFLAGS ================================================================= Package Settings ================================================================= dev-qt/qtwebengine-5.15.4_p20220526::gentoo was built with the following: USE="alsa jumbo-build pulseaudio system-ffmpeg system-icu widgets -bindist -debug -designer -geolocation -kerberos -screencast -test" ABI_X86="(64)" FEATURES="binpkg-logs xattr config-protect-if-modified multilib-strict ipc-sandbox preserve-libs merge-sync assume-digests userpriv qa-unresolved-soname-deps pid-sandbox distlocks usersync buildpkg-live binpkg-docompress parallel-fetch unmerge-orphans unmerge-logs sfperms network-sandbox protect-owned fixlafiles strict userfetch binpkg-multi-instance ebuild-locks sandbox news unknown-features-warn binpkg-dostrip usersandbox" LDFLAGS="-fuse-ld=lld -unwindlib=libunwind -rtlib=compiler-rt"
So, this is a weird one. This is what that fragment should look like: https://chromium.googlesource.com/chromium/src/+/refs/heads/main/content/renderer/media/batching_media_log.h#78 > GUARDED_BY(lock_) instead of LOCK. I just went and s/(LOCK)/(lock_) those 6 instances and it compiled just fine.
Created attachment 786470 [details, diff] PATCH
This issue introduced in: https://github.com/qt/qtwebengine-chromium/commit/ecc2bb74f1f7140fc52650042299be18e826b27b#diff-27c6d5f27d6d44db9ce274ac52e9acb5c6a864d5031384b1d832c8579b239035
I don't believe the Qt maintainers really monitor that GitHub mirror... at all, but I mentioned the issue at the qtwebengine IRC channel, and a fixup is on its way [1]. Thanks for the report! 1. https://codereview.qt-project.org/c/qt/qtwebengine-chromium/+/417398
(In reply to Chiitoo from comment #4) > I don't believe the Qt maintainers really monitor that GitHub mirror... at > all, but I mentioned the issue at the qtwebengine IRC channel, and a fixup > is on its way [1]. > > Thanks for the report! > > 1. https://codereview.qt-project.org/c/qt/qtwebengine-chromium/+/417398 Thanks for relaying it upstream. :-)
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=25cd576ef58a97ee613b2f8e97640109a598cbb3 commit 25cd576ef58a97ee613b2f8e97640109a598cbb3 Author: Andreas Sturmlechner <asturm@gentoo.org> AuthorDate: 2022-06-20 18:53:23 +0000 Commit: Andreas Sturmlechner <asturm@gentoo.org> CommitDate: 2022-06-20 18:53:39 +0000 dev-qt/qtwebengine: Fixup fix for CVE-2022-0796 Thanks-to: Michael <voron1@gmail.com> Thanks-to: Jimi Huotari <chiitoo@gentoo.org> Closes: https://bugs.gentoo.org/853097 Package-Manager: Portage-3.0.30, Repoman-3.0.3 Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org> ...gine-5.15.5_p20220618-fixup-CVE-2022-0796.patch | 48 ++++++++++++++++++++++ .../qtwebengine-5.15.5_p20220618.ebuild | 1 + 2 files changed, 49 insertions(+)
