Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 852965 - dev-util/gitlab-runner: incorrect GIT_COMMIT values
Summary: dev-util/gitlab-runner: incorrect GIT_COMMIT values
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: William Hubbs
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-06-19 01:43 UTC by Sam James
Modified: 2022-06-21 17:40 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-06-19 01:43:05 UTC
Bad (current) values of GIT_COMMIT in each ebuild:
14.0.1: GIT_COMMIT=c6bb62f6a
14.10.1: GIT_COMMIT=c6bb62f6a
15.0.0: GIT_COMMIT=c6bb62f6a

The correct values of GIT_COMMIT, I think, should be:
14.0.1: GIT_COMMIT=c1edb4783
14.10.1: GIT_COMMIT=f761588fb
15.0.0: GIT_COMMIT=febb2a096

Few suggestions:
1. Add a comment above GIT_COMMIT saying how important it is to update it for every release (it seems to affect the images which get grabbed, but also let's be correct anyway);

2. Allow specifying GIT_COMMIT as the full standard SHA1 hash and truncate it using Bash to 9 characters, e.g.
GIT_COMMIT=${GIT_COMMIT:9}.

It'll be easier to copy/paste or w/e that way and also makes clear it must be 9 characters.
Comment 1 Larry the Git Cow gentoo-dev 2022-06-21 17:40:59 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1f90796daa7e56b712dcb795fc9bac8c0aaa8970

commit 1f90796daa7e56b712dcb795fc9bac8c0aaa8970
Author:     William Hubbs <williamh@gentoo.org>
AuthorDate: 2022-06-21 17:39:35 +0000
Commit:     William Hubbs <williamh@gentoo.org>
CommitDate: 2022-06-21 17:40:52 +0000

    dev-util/gitlab-runner: add 14.10.1-r1, 15.0.0-r1
    
    This is to fix the commit hashes.
    Closes: https://bugs.gentoo.org/852965
    Signed-off-by: William Hubbs <williamh@gentoo.org>

 .../gitlab-runner/gitlab-runner-14.10.1-r1.ebuild  | 62 ++++++++++++++++++++++
 .../gitlab-runner/gitlab-runner-15.0.0-r1.ebuild   | 62 ++++++++++++++++++++++
 2 files changed, 124 insertions(+)