Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 852929 - sys-apps/pciutils-3.8.0: build fails with -flto=thin: default version symbol pci_fill_info@@LIBPCI_3.8 must be defined
Summary: sys-apps/pciutils-3.8.0: build fails with -flto=thin: default version symbol ...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: lto
  Show dependency tree
 
Reported: 2022-06-18 15:19 UTC by nvinson234
Modified: 2023-06-11 20:44 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (pciutils-3.8.0.build.log,14.92 KB, text/x-log)
2022-06-18 15:20 UTC, nvinson234
Details
pciutils-3.8.0.ebuild (pciutils-3.8.0.ebuild,4.64 KB, text/plain)
2022-06-18 15:21 UTC, nvinson234
Details

Note You need to log in before you can comment on or make changes to this bug.
Description nvinson234 2022-06-18 15:19:53 UTC
Using clang version 14.0.5 and ld.lld version LLD 14.0.5 (compatible with GNU linkers), libxcript fails to build when '-flto=thin' is added to CFLAGS.

Reproducible: Always

Steps to Reproduce:
1. follow https://wiki.gentoo.org/wiki/Clang#Link-time_optimizations_with_Clang
2. Enable LTO using -flto=thin
3. Attempt to build package
4. Observe build failure
Actual Results:  
package fails to build

Expected Results:  
package builds successfully.

Portage 3.0.30 (python 3.9.13-final-0, default/linux/amd64/17.1/desktop, gcc-11.3.0, glibc-2.35-r7, 5.18.2-gentoo x86_64)
=================================================================
System uname: Linux-5.18.2-gentoo-x86_64-Intel-R-_Core-TM-_i7-4771_CPU_@_3.50GHz-with-glibc2.35
KiB Mem:    32557860 total,  16475372 free
KiB Swap:    2097148 total,   2097148 free
Timestamp of repository gentoo: Sat, 18 Jun 2022 11:17:58 +0000
Head commit of repository gentoo: 10b5536dbd7cb80d8361b278068a94aaf579403c

Timestamp of repository brother-overlay: Wed, 08 Jun 2022 00:33:02 +0000
Head commit of repository brother-overlay: e5d2ebd754627638211575780ae3fef06dba4971

Head commit of repository magpie: 9bfed877e5190207efcaf3a0bc3d327977559d67

sh bash 5.1_p16
ld GNU ld (Gentoo 2.38 p4) 2.38
app-misc/pax-utils:        1.3.4::gentoo
app-shells/bash:           5.1_p16::gentoo
dev-java/java-config:      2.3.1::gentoo
dev-lang/perl:             5.36.0::gentoo
dev-lang/python:           3.9.13::gentoo, 3.10.5::gentoo, 3.11.0_beta3::gentoo
dev-lang/rust:             1.61.0-r1::gentoo
dev-util/cmake:            3.23.2::gentoo
dev-util/meson:            0.62.2::gentoo
sys-apps/baselayout:       2.8::gentoo
sys-apps/openrc:           0.45.1::gentoo
sys-apps/sandbox:          2.29::gentoo
sys-devel/autoconf:        2.13-r1::gentoo, 2.71-r1::gentoo
sys-devel/automake:        1.16.5::gentoo
sys-devel/binutils:        2.38-r2::gentoo
sys-devel/binutils-config: 5.4.1::gentoo
sys-devel/clang:           14.0.5::gentoo
sys-devel/gcc:             11.3.0::gentoo
sys-devel/gcc-config:      2.5-r1::gentoo
sys-devel/libtool:         2.4.7::gentoo
sys-devel/lld:             14.0.5::gentoo
sys-devel/llvm:            14.0.5::gentoo
sys-devel/make:            4.3::gentoo
sys-kernel/linux-headers:  5.18-r1::gentoo (virtual/os-headers)
sys-libs/glibc:            2.35-r7::gentoo
Repositories:

gentoo
    location: /var/db/repos/gentoo
    sync-type: git
    sync-uri: https://github.com/gentoo-mirror/gentoo.git
    priority: -1000
    sync-git-verify-commit-signature: true

brother-overlay
    location: /var/db/repos/brother-overlay
    sync-type: git
    sync-uri: https://github.com/gentoo-mirror/brother-overlay.git
    masters: gentoo

magpie
    location: /var/db/repos/magpie
    sync-type: git
    sync-uri: https://github.com/nvinson/magpie.git
    masters: gentoo

ACCEPT_KEYWORDS="amd64 ~amd64"
ACCEPT_LICENSE="* -@EULA"
AR="llvm-ar"
CBUILD="x86_64-pc-linux-gnu"
CC="clang"
CFLAGS="-march=native -O2 -pipe -D_FORTIFY_SOURCE=2 -fstack-protector-strong -flto=thin"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /opt/brother/scanner/brscan4/brsanenetdevice4.cfg /usr/lib64/libreoffice/program/sofficerc /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c"
CXX="clang++"
CXXFLAGS="-march=native -O2 -pipe -D_FORTIFY_SOURCE=2 -fstack-protector-strong -flto=thin"
DISTDIR="/var/cache/portage/distfiles"
EMERGE_DEFAULT_OPTS="--quiet-build"
ENV_UNSET="CARGO_HOME DBUS_SESSION_BUS_ADDRESS DISPLAY GOBIN GOPATH PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR"
FCFLAGS="-march=native -O2 -pipe"
FEATURES="assume-digests binpkg-docompress binpkg-dostrip binpkg-logs binpkg-multi-instance buildpkg-live config-protect-if-modified distlocks ebuild-locks fixlafiles ipc-sandbox merge-sync multilib-strict network-sandbox news parallel-fetch pid-sandbox preserve-libs protect-owned qa-unresolved-soname-deps sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS="-march=native -O2 -pipe"
GENTOO_MIRRORS="http://distfiles.gentoo.org"
LANG="en_US.utf8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed -fuse-ld=lld -rtlib=compiler-rt -unwindlib=libunwind"
MAKEOPTS="-j8"
NM="llvm-nm"
PKGDIR="/var/cache/binpkgs"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
PORTAGE_TMPDIR="/var/tmp"
RANLIB="llvm-ranlib"
SHELL="/bin/zsh"
USE="X a52 aac acl acpi alsa amd64 branding bzip2 cairo cdda cdr clang cleartype cli corefonts crypt cups dbus dri dts dvd dvdr elogind encode exif flac fortran gdbm gif glamor gpm gtk gui iconv icu ipv6 jpeg lcms libglvnd libnotify libtirpc mad mng mp3 mp4 mpeg multilib ncurses nls nptl ogg opengl openmp pam pango pcre pdf png policykit ppds qt5 readline sdl seccomp spell split-usr ssl startup-notification svg theora tiff truetype udev udisks unicode upower usb vaapi vorbis vpx wxwidgets x264 xattr xcb xml xv xvid zlib" ABI_X86="64" ADA_TARGET="gnat_2020" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="karbon sheets words" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="aes avx avx2 fma3 mmx mmxext popcnt sse sse2 sse3 sse4 sse4_1 sse4_2 ssse3" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock greis isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="libinput" KERNEL="linux" L10N="en-US en" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LUA_SINGLE_TARGET="lua5-1" LUA_TARGETS="lua5-1" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php7-4 php8-0" POSTGRES_TARGETS="postgres12 postgres13" PYTHON_SINGLE_TARGET="python3_9" PYTHON_TARGETS="python3_9" RUBY_TARGETS="ruby27" USERLAND="GNU" VIDEO_CARDS="intel i965" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq proto steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  ADDR2LINE, ARFLAGS, AS, ASFLAGS, CCLD, CONFIG_SHELL, CPP, CPPFLAGS, CTARGET, CXXFILT, ELFEDIT, EXTRA_ECONF, F77FLAGS, FC, GCOV, GPROF, INSTALL_MASK, LC_ALL, LD, LEX, LFLAGS, LIBTOOL, LINGUAS, MAKE, MAKEFLAGS, OBJCOPY, OBJDUMP, PORTAGE_BINHOST, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, READELF, RUSTFLAGS, SIZE, STRINGS, STRIP, YACC, YFLAGS
Comment 1 nvinson234 2022-06-18 15:20:19 UTC
Created attachment 786071 [details]
build.log
Comment 2 nvinson234 2022-06-18 15:21:08 UTC
Created attachment 786074 [details]
pciutils-3.8.0.ebuild

updated ebuild that replaces -flto=thin with -flto as pciutils builds when -flto is set.
Comment 3 Larry the Git Cow gentoo-dev 2022-07-17 15:24:47 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=590037827fb0b839373745692ca239609c56562e

commit 590037827fb0b839373745692ca239609c56562e
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2022-07-17 15:23:38 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-07-17 15:23:56 +0000

    sys-apps/pciutils: filter LTO
    
    Similar logic to the alsa-lib commit (31c929441087eb65c4cdcfc61b29acb3a50cb954).
    
    If it works with LTO and not thin LTO, it seems to me it's
    still seriously broken and there may be other issues lurking.
    
    It's a warning sign and we shouldn't ignore it, hence filter
    LTO entirely.
    
    Closes: https://bugs.gentoo.org/852929
    Closes: https://bugs.gentoo.org/640836
    See: 31c929441087eb65c4cdcfc61b29acb3a50cb954
    Signed-off-by: Sam James <sam@gentoo.org>

 sys-apps/pciutils/pciutils-3.8.0-r1.ebuild | 3 +++
 1 file changed, 3 insertions(+)
Comment 4 Larry the Git Cow gentoo-dev 2023-05-01 18:20:26 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1f6e00fbb2e1491e868b5b10472023fe8854a75b

commit 1f6e00fbb2e1491e868b5b10472023fe8854a75b
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2023-05-01 18:18:48 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-05-01 18:19:56 +0000

    sys-apps/pciutils: add 3.10.0
    
    Drops filtering LTO as https://github.com/pciutils/pciutils/commit/2d16e3a7875a9cb5abd60713bb2e39b536a7dec4
    seems to fix it.
    
    Bug: https://bugs.gentoo.org/640836
    Bug: https://bugs.gentoo.org/852929
    Signed-off-by: Sam James <sam@gentoo.org>

 sys-apps/pciutils/Manifest               |   1 +
 sys-apps/pciutils/pciutils-3.10.0.ebuild | 174 +++++++++++++++++++++++++++++++
 2 files changed, 175 insertions(+)
Comment 5 Larry the Git Cow gentoo-dev 2023-06-11 20:44:14 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=61452f5cca7c880842782fb1594ef0f22e511859

commit 61452f5cca7c880842782fb1594ef0f22e511859
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2023-06-11 20:43:35 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-06-11 20:44:04 +0000

    sys-apps/pciutils: put back filter-lto
    
    Naib and username234 pointed this out a while ago but I forgot to restore the filter.
    
    Bug: https://bugs.gentoo.org/640836
    Bug: https://bugs.gentoo.org/852929
    Bug: https://github.com/pciutils/pciutils/pull/144
    Signed-off-by: Sam James <sam@gentoo.org>

 sys-apps/pciutils/pciutils-3.10.0.ebuild | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)