Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 852830 - net-misc/tigervnc-0.12.0[-server] fails to build without pam.
Summary: net-misc/tigervnc-0.12.0[-server] fails to build without pam.
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Viorel Munteanu
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2022-06-17 19:15 UTC by Nick Bowler
Modified: 2022-07-04 00:32 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build log (net-misc:tigervnc-1.12.0-r6:20220617-191307.log,7.16 KB, text/x-log)
2022-06-17 19:15 UTC, Nick Bowler
Details
ebuild patch (tigervnc-ebuild.patch,879 bytes, patch)
2022-06-17 19:21 UTC, Nick Bowler
Details | Diff
tigervnc-1.12.0-disable-server-and-pam.patch (tigervnc-1.12.0-disable-server-and-pam.patch,1.63 KB, patch)
2022-06-17 19:23 UTC, Nick Bowler
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Bowler 2022-06-17 19:15:53 UTC
Created attachment 785996 [details]
build log

The tigervnc ebuild has a dependency on sys-libs/pam conditional on the server
USE flag.

With USE=-server, there is no ebuild dependency on pam, but the build
nevertheless fails if pam is missing:

  -- Looking for include file security/pam_appl.h
  -- Looking for include file security/pam_appl.h - not found
  -- Looking for pam_start
  -- Looking for pam_start - not found
  CMake Error at CMakeLists.txt:287 (message):
    Could not find PAM development files

Patching the build to remove the configure check mostly works, except the
build system still builds the server even with USE=-server (this obviously
fails).  Patching the build system to not build the server works, but then
src_install in the ebuild fails since it expects the server to be installed
(so that it can delete it).  Patching the ebuild to not do that allows the
package to install successfully.

Some of the test cases that are unconditionally built also seem to depend on
pam, I had to remove those too (the ebuild does not seem to run the tests
anyway).

Previous versions of tigervnc ebuild install OK without pam.

Portage 3.0.30 (python 3.9.13-final-0, default/linux/amd64/17.0, gcc-11.3.0, glibc-2.33-r1, 3.10.0-1160.11.1.el7.x86_64 x86_64)
=================================================================
System uname: Linux-3.10.0-1160.11.1.el7.x86_64-x86_64-Intel-R-_Core-TM-_i7-4790_CPU_@_3.60GHz-with-glibc2.33
KiB Mem:    16204164 total,   7393732 free
KiB Swap:   32605180 total,  32604660 free
Timestamp of repository gentoo: Fri, 17 Jun 2022 00:45:01 +0000
sh bash 5.1_p16
ld GNU ld (Gentoo 2.38 p4) 2.38
ccache version 4.6.1 [enabled]
app-misc/pax-utils:        1.3.4::gentoo
app-shells/bash:           5.1_p16::gentoo
dev-lang/perl:             5.36.0::gentoo
dev-lang/python:           2.7.18_p13::gentoo, 3.6.15-r1::gentoo, 3.7.12_p1-r1::gentoo, 3.8.12_p1-r2::gentoo, 3.9.13::gentoo, 3.10.5::gentoo, 3.11.0_beta3::gentoo
dev-lang/rust:             1.61.0-r1::gentoo
dev-lang/rust-bin:         1.61.0::gentoo
dev-util/ccache:           4.6.1::gentoo
dev-util/cmake:            3.23.2::gentoo
dev-util/meson:            0.62.2::gentoo
sys-apps/baselayout:       2.8::gentoo
sys-apps/openrc:           0.45.1::gentoo
sys-apps/sandbox:          2.29::gentoo
sys-devel/autoconf:        2.13-r1::gentoo, 2.69-r5::gentoo, 2.71-r1::gentoo
sys-devel/automake:        1.16.5::gentoo
sys-devel/binutils:        2.38-r2::gentoo
sys-devel/binutils-config: 5.4.1::gentoo
sys-devel/clang:           13.0.1::gentoo, 14.0.5::gentoo
sys-devel/gcc:             9.3.0-r2::gentoo, 11.3.0::gentoo
sys-devel/gcc-config:      2.5-r1::gentoo
sys-devel/libtool:         2.4.7::gentoo
sys-devel/llvm:            11.1.0::gentoo, 13.0.1::gentoo, 14.0.5::gentoo
sys-devel/make:            4.3::gentoo
sys-kernel/linux-headers:  5.18-r1::gentoo (virtual/os-headers)
sys-libs/glibc:            2.33-r1::gentoo
Repositories:

gentoo
    location: /SCRATCH/gentoo/srv/repos/gentoo
    sync-type: webrsync
    sync-uri: rsync://rsync.gentoo.org/gentoo-portage
    priority: -1000
    sync-webrsync-verify-signature: true

gentoo-draconx
    location: /SCRATCH/gentoo/srv/repos/gentoo-draconx
    masters: gentoo

gentoo-fixes
    location: /SCRATCH/gentoo/srv/repos/gentoo-fixes
    masters: gentoo

ACCEPT_KEYWORDS="amd64 ~amd64"
ACCEPT_LICENSE="@FREE"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-O2 -march=haswell -pipe"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/SCRATCH/gentoo/etc /etc /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/SCRATCH/gentoo/etc/env.d /SCRATCH/gentoo/etc/gentoo-release /etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c"
CONFIG_SHELL="/SCRATCH/gentoo/bin/bash"
CXXFLAGS="-O2 -march=haswell -pipe"
DISTDIR="/SCRATCH/gentoo/var/cache/distfiles"
EMERGE_DEFAULT_OPTS="--quiet-build --keep-going --autounmask=n --autounmask-write=n --dynamic-deps=n --unordered-display --verbose-conflicts --with-bdeps-auto=n"
ENV_UNSET="CARGO_HOME DBUS_SESSION_BUS_ADDRESS DISPLAY GOBIN GOPATH PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR"
FCFLAGS="-O2 -pipe"
FEATURES="assume-digests binpkg-docompress binpkg-dostrip binpkg-logs binpkg-multi-instance buildpkg-live ccache config-protect-if-modified distlocks ebuild-locks fixlafiles force-prefix ipc-sandbox merge-sync multilib-strict network-sandbox news parallel-fetch pid-sandbox preserve-libs protect-owned qa-unresolved-soname-deps sfperms strict unknown-features-warn unmerge-logs unmerge-orphans unprivileged xattr"
FFLAGS="-O2 -pipe"
GENTOO_MIRRORS="http://distfiles.gentoo.org"
LANG="en_CA.UTF-8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
MAKEOPTS="-j5"
PKGDIR="/SCRATCH/gentoo/var/cache/binpkgs"
PORTAGE_CONFIGROOT="/SCRATCH/gentoo/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
PORTAGE_TMPDIR="/SCRATCH/gentoo/var/tmp"
SHELL="/SCRATCH/gentoo/bin/zsh"
USE="X acl amd64 bzip2 cli crypt cups dri exif fbcon fontconfig fortran gdbm iconv icu ipv6 jpeg lcms libglvnd libtirpc lzma multilib ncurses nls nptl openmp pcre perl png prefix python readline seccomp split-usr ssl svg truetype unicode xattr xft xinerama zlib" ABI_X86="64" ADA_TARGET="gnat_2020" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="karbon sheets words" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="aes avx avx2 f16c fma3 mmx mmxext pclmul popcnt sse sse2 sse3 sse4_1 sse4_2 ssse3" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock greis isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="libinput" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LUA_SINGLE_TARGET="lua5-1" LUA_TARGETS="lua5-1" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php7-4 php8-0" POSTGRES_TARGETS="postgres12 postgres13" PYTHON_SINGLE_TARGET="python3_9" PYTHON_TARGETS="python3_9" RUBY_TARGETS="ruby27" USERLAND="GNU" VIDEO_CARDS="amdgpu fbdev intel nouveau radeon radeonsi vesa dummy v4l" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq proto steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  ADDR2LINE, AR, ARFLAGS, AS, ASFLAGS, CC, CCLD, CPP, CPPFLAGS, CTARGET, CXX, CXXFILT, ELFEDIT, EXTRA_ECONF, F77FLAGS, FC, GCOV, GPROF, INSTALL_MASK, LC_ALL, LD, LEX, LFLAGS, LIBTOOL, LINGUAS, MAKE, MAKEFLAGS, NM, OBJCOPY, OBJDUMP, PORTAGE_BINHOST, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, RANLIB, READELF, RUSTFLAGS, SIZE, STRINGS, STRIP, YACC, YFLAGS
Comment 1 Nick Bowler 2022-06-17 19:21:24 UTC
Created attachment 785999 [details, diff]
ebuild patch

This removes src_install logic to delete the installed server components, instead patching the build system to not build or install them in the first place.
Comment 2 Nick Bowler 2022-06-17 19:23:05 UTC
Created attachment 786002 [details, diff]
tigervnc-1.12.0-disable-server-and-pam.patch

this patch is applied to disable building the tests and server components that depend on pam.

(vncconfig will build fine without pam but USE=-server originally deletes it so I disabled it too).
Comment 3 Viorel Munteanu gentoo-dev 2022-06-18 09:46:02 UTC
Hi,

Please read this https://www.gentoo.org/glep/glep-0076.html#certificate-of-origin and if you agree please add a Gentoo Certificate of Origin (you can add it here, as a comment).
Comment 4 Sandino Araico Sanchez 2022-06-21 04:51:52 UTC
tigervnc with USE=-server and tigervnc-1.12.0-disable-server-and-pam.patch compiles on amd64
Comment 5 Nick Bowler 2022-06-22 13:25:53 UTC
(In reply to Viorel from comment #3)
> Hi,
> 
> Please read this
> https://www.gentoo.org/glep/glep-0076.html#certificate-of-origin and if you
> agree please add a Gentoo Certificate of Origin (you can add it here, as a
> comment).

In case it still matters:

Signed-off-by: Nick Bowler <nbowler@draconx.ca>
Comment 6 Viorel Munteanu gentoo-dev 2022-06-22 13:26:56 UTC
Yes, I will add it to the commit message.  Thank you!
Comment 7 Larry the Git Cow gentoo-dev 2022-07-04 00:32:59 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=81782dbff6cb3d7c601a09f3e4cdf84fea4b36c2

commit 81782dbff6cb3d7c601a09f3e4cdf84fea4b36c2
Author:     Viorel Munteanu <ceamac.paragon@gmail.com>
AuthorDate: 2022-06-18 09:53:32 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-07-04 00:32:53 +0000

    net-misc/tigervnc: Fix for USE=-server and no pam
    
    Don't build server files instead of erasing them afterwards
    Drop xorgmodule local use flag from metadata (no longer used)
    
    Closes: https://bugs.gentoo.org/852830
    Signed-off-by: Nick Bowler <nbowler@draconx.ca>
    Signed-off-by: Viorel Munteanu <ceamac.paragon@gmail.com>
    Closes: https://github.com/gentoo/gentoo/pull/26034
    Signed-off-by: Sam James <sam@gentoo.org>

 .../tigervnc-1.12.0-disable-server-and-pam.patch   |  57 ++++++
 .../tigervnc-1.12.80-disable-server-and-pam.patch  |  57 ++++++
 net-misc/tigervnc/metadata.xml                     |   1 -
 net-misc/tigervnc/tigervnc-1.12.0-r7.ebuild        | 199 +++++++++++++++++++++
 net-misc/tigervnc/tigervnc-9999.ebuild             |  30 ++--
 5 files changed, 325 insertions(+), 19 deletions(-)